Merge branch 'busybox' into merge

6 files changed, 356 insertions, 29 deletions

diff --git a/shell/ash.c b/shell/ash.c
index 3d6f25802..14712ef54 100644
--- a/shell/ash.c
+++ b/shell/ash.c
@@ -262,6 +262,14 @@
 #define    BASH_READ_D          ENABLE_ASH_BASH_COMPAT
 #define IF_BASH_READ_D              IF_ASH_BASH_COMPAT
 #define    BASH_WAIT_N          ENABLE_ASH_BASH_COMPAT
+/* <(...) and >(...) */
+#if HAVE_DEV_FD
+# define    BASH_PROCESS_SUBST   ENABLE_ASH_BASH_COMPAT
+# define IF_BASH_PROCESS_SUBST       IF_ASH_BASH_COMPAT
+#else
+# define    BASH_PROCESS_SUBST 0
+# define IF_BASH_PROCESS_SUBST(...)
+#endif
 
 #if defined(__ANDROID_API__) && __ANDROID_API__ <= 24
 /* Bionic at least up to version 24 has no glob() */
@@ -973,6 +981,12 @@ out2str(const char *p)
 #define CTLENDARI    ((unsigned char)'\207')
 #define CTLQUOTEMARK ((unsigned char)'\210')
 #define CTL_LAST CTLQUOTEMARK
+#if BASH_PROCESS_SUBST
+# define CTLTOPROC    ((unsigned char)'\211')
+# define CTLFROMPROC  ((unsigned char)'\212')
+# undef CTL_LAST
+# define CTL_LAST CTLFROMPROC
+#endif
 
 /* variable substitution byte (follows CTLVAR) */
 #define VSTYPE  0x0f            /* type of variable substitution */
@@ -1244,6 +1258,10 @@ trace_puts_quoted(char *s)
                 case CTLESC: c = 'e'; goto backslash;
                 case CTLVAR: c = 'v'; goto backslash;
                 case CTLBACKQ: c = 'q'; goto backslash;
+#if BASH_PROCESS_SUBST
+                case CTLTOPROC: c = 'p'; goto backslash;
+                case CTLFROMPROC: c = 'P'; goto backslash;
+#endif
  backslash:
                         putc('\\', tracefile);
                         putc(c, tracefile);
@@ -1405,8 +1423,17 @@ sharg(union node *arg, FILE *fp)
                 case CTLENDVAR:
                         putc('}', fp);
                         break;
+#if BASH_PROCESS_SUBST
+                case CTLTOPROC:
+                        putc('>', fp);
+                        goto backq;
+                case CTLFROMPROC:
+                        putc('<', fp);
+                        goto backq;
+#endif
                 case CTLBACKQ:
                         putc('$', fp);
+ IF_BASH_PROCESS_SUBST(backq:)
                         putc('(', fp);
                         shtree(bqlist->n, -1, NULL, fp);
                         putc(')', fp);
@@ -3663,8 +3690,13 @@ static const uint8_t syntax_index_table[] ALIGN1 = {
         /* 134 CTLARI       */ CCTL_CCTL_CCTL_CCTL,
         /* 135 CTLENDARI    */ CCTL_CCTL_CCTL_CCTL,
         /* 136 CTLQUOTEMARK */ CCTL_CCTL_CCTL_CCTL,
+#if BASH_PROCESS_SUBST
+        /* 137 CTLTOPROC    */ CCTL_CCTL_CCTL_CCTL,
+        /* 138 CTLFROMPROC  */ CCTL_CCTL_CCTL_CCTL,
+#else
         /* 137      */ CWORD_CWORD_CWORD_CWORD,
         /* 138      */ CWORD_CWORD_CWORD_CWORD,
+#endif
         /* 139      */ CWORD_CWORD_CWORD_CWORD,
         /* 140      */ CWORD_CWORD_CWORD_CWORD,
         /* 141      */ CWORD_CWORD_CWORD_CWORD,
@@ -5377,9 +5409,24 @@ cmdputs(const char *s)
                         quoted >>= 1;
                         subtype = 0;
                         goto dostr;
+#if BASH_PROCESS_SUBST
+                case CTLBACKQ:
+                        c = '$';
+                        str = "(...)";
+                        break;
+                case CTLTOPROC:
+                        c = '>';
+                        str = "(...)";
+                        break;
+                case CTLFROMPROC:
+                        c = '<';
+                        str = "(...)";
+                        break;
+#else
                 case CTLBACKQ:
                         str = "$(...)";
                         goto dostr;
+#endif
 #if ENABLE_FEATURE_SH_MATH
                 case CTLARI:
                         str = "$((";
@@ -6446,6 +6493,21 @@ redirectsafe(union node *redir, int flags)
         return err;
 }
 
+#if BASH_PROCESS_SUBST
+static void
+pushfd(int fd)
+{
+        struct redirtab *sv;
+
+        sv = ckzalloc(sizeof(*sv) + sizeof(sv->two_fd[0]));
+        sv->pair_count = 1;
+        sv->two_fd[0].orig_fd = fd;
+        sv->two_fd[0].moved_to = CLOSED;
+        sv->next = redirlist;
+        redirlist = sv;
+}
+#endif
+
 static struct redirtab*
 pushredir(union node *redir)
 {
@@ -7084,10 +7146,20 @@ evaltreenr(union node *n, int flags)
 }
 
 static void FAST_FUNC
-evalbackcmd(union node *n, struct backcmd *result)
+evalbackcmd(union node *n, struct backcmd *result
+                                IF_BASH_PROCESS_SUBST(, int ctl))
 {
         int pip[2];
         struct job *jp;
+#if BASH_PROCESS_SUBST
+        /* determine end of pipe used by parent (ip) and child (ic) */
+        const int ip = (ctl == CTLTOPROC);
+        const int ic = !(ctl == CTLTOPROC);
+#else
+        const int ctl = CTLBACKQ;
+        const int ip = 0;
+        const int ic = 1;
+#endif
         IF_PLATFORM_MINGW32(struct forkshell fs);
 
         result->fd = -1;
@@ -7100,23 +7172,26 @@ evalbackcmd(union node *n, struct backcmd *result)
 
         if (pipe(pip) < 0)
                 ash_msg_and_raise_perror("can't create pipe");
-        jp = makejob(/*n,*/ 1);
+        /* process substitution uses NULL job/node, like openhere() */
+        jp = (ctl == CTLBACKQ) ? makejob(/*n,*/ 1) : NULL;
 #if ENABLE_PLATFORM_MINGW32
         memset(&fs, 0, sizeof(fs));
         fs.fpid = FS_EVALBACKCMD;
         fs.n = n;
         fs.fd[0] = pip[0];
         fs.fd[1] = pip[1];
-        spawn_forkshell(&fs, jp, n, FORK_NOJOB);
+        fs.fd[2] = ctl;
+        spawn_forkshell(&fs, jp, (ctl == CTLBACKQ) ? n : NULL, FORK_NOJOB);
 #else
-        if (forkshell(jp, n, FORK_NOJOB) == 0) {
+        if (forkshell(jp, (ctl == CTLBACKQ) ? n : NULL, FORK_NOJOB) == 0) {
                 /* child */
                 FORCE_INT_ON;
-                close(pip[0]);
-                if (pip[1] != 1) {
-                        /*close(1);*/
-                        dup2_or_raise(pip[1], 1);
-                        close(pip[1]);
+                close(pip[ip]);
+                /* ic is index of child end of pipe *and* fd to connect it to */
+                if (pip[ic] != ic) {
+                        /*close(ic);*/
+                        dup2_or_raise(pip[ic], ic);
+                        close(pip[ic]);
                 }
 /* TODO: eflag clearing makes the following not abort:
  *  ash -c 'set -e; z=$(false;echo foo); echo $z'
@@ -7133,8 +7208,18 @@ evalbackcmd(union node *n, struct backcmd *result)
         }
 #endif
         /* parent */
-        close(pip[1]);
-        result->fd = pip[0];
+#if BASH_PROCESS_SUBST
+        if (ctl != CTLBACKQ) {
+                int fd = fcntl(pip[ip], F_DUPFD, 64);
+                if (fd > 0) {
+                        close(pip[ip]);
+                        pip[ip] = fd;
+                }
+                pushfd(pip[ip]);
+        }
+#endif
+        close(pip[ic]);
+        result->fd = pip[ip];
         result->jp = jp;
 
  out:
@@ -7146,8 +7231,11 @@ evalbackcmd(union node *n, struct backcmd *result)
  * Expand stuff in backwards quotes.
  */
 static void
-expbackq(union node *cmd, int flag)
+expbackq(union node *cmd, int flag IF_BASH_PROCESS_SUBST(, int ctl))
 {
+#if !BASH_PROCESS_SUBST
+        const int ctl = CTLBACKQ;
+#endif
         struct backcmd in;
         int i;
         char buf[128];
@@ -7162,9 +7250,15 @@ expbackq(union node *cmd, int flag)
         INT_OFF;
         startloc = expdest - (char *)stackblock();
         pushstackmark(&smark, startloc);
-        evalbackcmd(cmd, &in);
+        evalbackcmd(cmd, &in IF_BASH_PROCESS_SUBST(, ctl));
         popstackmark(&smark);
 
+        if (ctl != CTLBACKQ) {
+                sprintf(buf, DEV_FD_PREFIX"%d", in.fd);
+                strtodest(buf, BASESYNTAX);
+                goto done;
+        }
+
         p = in.buf;
         i = in.nleft;
         if (i == 0)
@@ -7186,6 +7280,7 @@ expbackq(union node *cmd, int flag)
                 close(in.fd);
                 back_exitstatus = waitforjob(in.jp);
         }
+ done:
         INT_ON;
 
         /* Eat all trailing newlines */
@@ -7274,6 +7369,10 @@ argstr(char *p, int flag)
                 CTLESC,
                 CTLVAR,
                 CTLBACKQ,
+#if BASH_PROCESS_SUBST
+                CTLTOPROC,
+                CTLFROMPROC,
+#endif
 #if ENABLE_FEATURE_SH_MATH
                 CTLARI,
                 CTLENDARI,
@@ -7373,8 +7472,12 @@ argstr(char *p, int flag)
                         p = evalvar(p, flag | inquotes);
                         TRACE(("argstr: evalvar:'%s'\n", (char *)stackblock()));
                         goto start;
+#if BASH_PROCESS_SUBST
+                case CTLTOPROC:
+                case CTLFROMPROC:
+#endif
                 case CTLBACKQ:
-                        expbackq(argbackq->n, flag | inquotes);
+                        expbackq(argbackq->n, flag | inquotes IF_BASH_PROCESS_SUBST(, c));
                         goto start;
 #if ENABLE_FEATURE_SH_MATH
                 case CTLARI:
@@ -12995,8 +13098,9 @@ realeofmark(const char *eofmark)
 #define CHECKEND()      {goto checkend; checkend_return:;}
 #define PARSEREDIR()    {goto parseredir; parseredir_return:;}
 #define PARSESUB()      {goto parsesub; parsesub_return:;}
-#define PARSEBACKQOLD() {oldstyle = 1; goto parsebackq; parsebackq_oldreturn:;}
-#define PARSEBACKQNEW() {oldstyle = 0; goto parsebackq; parsebackq_newreturn:;}
+#define PARSEBACKQOLD() {style = OLD; goto parsebackq; parsebackq_oldreturn:;}
+#define PARSEBACKQNEW() {style = NEW; goto parsebackq; parsebackq_newreturn:;}
+#define PARSEPROCSUB()  {style = PSUB; goto parsebackq; parsebackq_psreturn:;}
 #define PARSEARITH()    {goto parsearith; parsearith_return:;}
 static int
 readtoken1(int c, int syntax, char *eofmark, int striptabs)
@@ -13007,7 +13111,9 @@ readtoken1(int c, int syntax, char *eofmark, int striptabs)
         size_t len;
         struct nodelist *bqlist;
         smallint quotef;
-        smallint oldstyle;
+        smallint style;
+        enum { OLD, NEW, PSUB };
+#define oldstyle (style == OLD)
         smallint pssyntax;   /* we are expanding a prompt string */
         IF_BASH_DOLLAR_SQUOTE(smallint bash_dollar_squote = 0;)
         /* syntax stack */
@@ -13189,6 +13295,15 @@ readtoken1(int c, int syntax, char *eofmark, int striptabs)
                                         pungetc();
                                 }
 #endif
+#if BASH_PROCESS_SUBST
+                                if (c == '<' || c == '>') {
+                                        if (pgetc() == '(') {
+                                                PARSEPROCSUB();
+                                                break;
+                                        }
+                                        pungetc();
+                                }
+#endif
                                 goto endword;   /* exit outer loop */
                         }
                         IF_ASH_ALIAS(if (c != PEOA))
@@ -13673,9 +13788,18 @@ parsebackq: {
                 memcpy(out, str, savelen);
                 STADJUST(savelen, out);
         }
-        USTPUTC(CTLBACKQ, out);
+#if BASH_PROCESS_SUBST
+        if (style == PSUB)
+                USTPUTC(c == '<' ? CTLFROMPROC : CTLTOPROC, out);
+        else
+#endif
+                USTPUTC(CTLBACKQ, out);
         if (oldstyle)
                 goto parsebackq_oldreturn;
+#if BASH_PROCESS_SUBST
+        else if (style == PSUB)
+                goto parsebackq_psreturn;
+#endif
         goto parsebackq_newreturn;
 }
 
@@ -14130,6 +14254,9 @@ cmdloop(int top)
                 if (doing_jobctl)
                         showjobs(SHOW_CHANGED|SHOW_STDERR);
 #endif
+#if BASH_PROCESS_SUBST
+                unwindredir(NULL);
+#endif
                 inter = 0;
                 if (iflag && top) {
                         inter++;
@@ -14864,6 +14991,10 @@ readcmd(int argc UNUSED_PARAM, char **argv UNUSED_PARAM)
                 }
         }
 
+        if (!ENABLE_ASH_BASH_COMPAT && !argptr) {
+                bb_simple_error_msg("read: need variable name");
+                return 1;
+        }
         params.argv = argptr;
         params.setvar = setvar0;
         params.ifs = bltinlookup("IFS"); /* can be NULL */
@@ -15578,15 +15709,27 @@ forkshell_openhere(struct forkshell *fs)
 static void
 forkshell_evalbackcmd(struct forkshell *fs)
 {
+#if BASH_PROCESS_SUBST
+        /* determine end of pipe used by parent (ip) and child (ic) */
+        const int ctl = fs->fd[2];
+        const int ip = (ctl == CTLTOPROC);
+        const int ic = !(ctl == CTLTOPROC);
+#else
+        const int ip = 0;
+        const int ic = 1;
+#endif
         union node *n = fs->n;
-        int pip[2] = {fs->fd[0], fs->fd[1]};
+        int pip[2];
+
+        pip[ip] = fs->fd[ip];
+        pip[ic] = fs->fd[ic];
 
         FORCE_INT_ON;
-        close(pip[0]);
-        if (pip[1] != 1) {
-                /*close(1);*/
-                dup2_or_raise(pip[1], 1);
-                close(pip[1]);
+        close(pip[ip]);
+        if (pip[ic] != ic) {
+                /*close(ic);*/
+                dup2_or_raise(pip[ic], ic);
+                close(pip[ic]);
         }
         eflag = 0;
         ifsfree();
diff --git a/shell/ash_remove_unnecessary_code_in_backquote_expansion.patch b/shell/ash_remove_unnecessary_code_in_backquote_expansion.patch
new file mode 100644
index 000000000..06067dde0
--- /dev/null
+++ b/shell/ash_remove_unnecessary_code_in_backquote_expansion.patch
@@ -0,0 +1,135 @@
+From: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
+Date: Thu, 19 Apr 2018 18:16:12 +0800
+
+> ash originally had support for omitting the fork when expanding a
+> builtin in backquotes.  dash has gradually been removing this support,
+> most recently in commit 66b614e29038e31745c4a5d296f64f8d64f5c377
+> ("[EVAL] Remove unused EV_BACKCMD flag").
+>
+> Some traces still remain, however.  Remove:
+>
+> - the buf and nleft elements of the backcmd structure;
+> - a misleading comment regarding handling of builtins.
+>
+> Signed-off-by: Ron Yorston <rmy@xxxxxxxxxxxx>
+
+Unfortunately we may need this at some point in the future due
+to changes in POSIX.  So let's keep it around for now until we
+get things such as `jobs -p` to work.
+
+*************************************
+
+From: Ron Yorston <rmy@xxxxxxxxxxxx>
+Date: Thu, 19 Apr 2018 17:18:47 +0100
+
+>Unfortunately we may need this at some point in the future due
+>to changes in POSIX.  So let's keep it around for now until we
+>get things such as `jobs -p` to work.
+
+As you wish.
+
+Something even more trivial I noticed later:  the TRACE at the end of
+expbackq incorrectly refers to the function as evalbackq.
+
+*************************************
+
+Date: Tue, 10 Apr 2018 13:23:35 +0100
+From: Ron Yorston <rmy@pobox.com>
+To: busybox@busybox.net
+Subject: [PATCH] ash: remove unnecessary code in backquote expansion
+
+Some traces remain of ash's ancient support for omitting the fork when
+expanding a builtin command in backquotes.
+
+Remove:
+
+- the buf and nleft elements of the backcmd structure;
+- a misleading comment regarding handling of builtins.
+
+I've submitted a similar patch to dash.
+
+Signed-off-by: Ron Yorston <rmy@pobox.com>
+---
+ shell/ash.c | 37 +++++++++----------------------------
+ 1 file changed, 9 insertions(+), 28 deletions(-)
+
+diff --git a/shell/ash.c b/shell/ash.c
+index 45c747dbc..6f1458722 100644
+--- a/shell/ash.c
++++ b/shell/ash.c
+@@ -6356,15 +6356,12 @@ exptilde(char *startp, char *p, int flags)
+ }
+ 
+ /*
+- * Execute a command inside back quotes.  If it's a builtin command, we
+- * want to save its output in a block obtained from malloc.  Otherwise
+- * we fork off a subprocess and get the output of the command via a pipe.
+- * Should be called with interrupts off.
++ * Execute a command inside back quotes.  We fork off a subprocess and
++ * get the output of the command via a pipe.  Should be called with
++ * interrupts off.
+  */
+ struct backcmd {                /* result of evalbackcmd */
+        int fd;                 /* file descriptor to read from */
+-       int nleft;              /* number of chars in buffer */
+-       char *buf;              /* buffer */
+        struct job *jp;         /* job structure for command */
+ };
+ 
+@@ -6394,8 +6391,6 @@ evalbackcmd(union node *n, struct backcmd *result)
+        struct job *jp;
+ 
+        result->fd = -1;
+-       result->buf = NULL;
+-       result->nleft = 0;
+        result->jp = NULL;
+        if (n == NULL) {
+                goto out;
+@@ -6432,8 +6427,7 @@ evalbackcmd(union node *n, struct backcmd *result)
+        result->jp = jp;
+ 
+  out:
+-       TRACE(("evalbackcmd done: fd=%d buf=0x%x nleft=%d jp=0x%x\n",
+-               result->fd, result->buf, result->nleft, result->jp));
++       TRACE(("evalbackcmd done: fd=%d jp=0x%x\n", result->fd, result->jp));
+ }
+ 
+ /*
+@@ -6445,7 +6439,6 @@ expbackq(union node *cmd, int flag)
+        struct backcmd in;
+        int i;
+        char buf[128];
+-       char *p;
+        char *dest;
+        int startloc;
+        int syntax = flag & EXP_QUOTED ? DQSYNTAX : BASESYNTAX;
+@@ -6457,24 +6450,12 @@ expbackq(union node *cmd, int flag)
+        evalbackcmd(cmd, &in);
+        popstackmark(&smark);
+ 
+-       p = in.buf;
+-       i = in.nleft;
+-       if (i == 0)
+-               goto read;
+-       for (;;) {
+-               memtodest(p, i, syntax, flag & QUOTES_ESC);
+- read:
+-               if (in.fd < 0)
+-                       break;
+-               i = nonblock_immune_read(in.fd, buf, sizeof(buf));
+-               TRACE(("expbackq: read returns %d\n", i));
+-               if (i <= 0)
+-                       break;
+-               p = buf;
+-       }
+-
+-       free(in.buf);
+        if (in.fd >= 0) {
++               while ((i = nonblock_immune_read(in.fd, buf, sizeof(buf))) > 0) {
++                       TRACE(("expbackq: read returns %d\n", i));
++                       memtodest(buf, i, syntax, flag & QUOTES_ESC);
++               }
++
+                close(in.fd);
+                back_exitstatus = waitforjob(in.jp);
+        }
diff --git a/shell/ash_test/ash-psubst/bash_procsub.right b/shell/ash_test/ash-psubst/bash_procsub.right
new file mode 100644
index 000000000..aa16a96be
--- /dev/null
+++ b/shell/ash_test/ash-psubst/bash_procsub.right
@@ -0,0 +1,9 @@
+hello 1
+hello 2
+hello 3
+<(echo "hello 0")
+hello 4
+HI THERE
+hello error
+hello error
+hello stderr
diff --git a/shell/ash_test/ash-psubst/bash_procsub.tests b/shell/ash_test/ash-psubst/bash_procsub.tests
new file mode 100755
index 000000000..63b836782
--- /dev/null
+++ b/shell/ash_test/ash-psubst/bash_procsub.tests
@@ -0,0 +1,33 @@
+# simplest case
+cat <(echo "hello 1")
+
+# can have more than one
+cat <(echo "hello 2") <(echo "hello 3")
+
+# doesn't work in quotes
+echo "<(echo \"hello 0\")"
+
+# process substitution can be nested inside command substitution
+echo $(cat <(echo "hello 4"))
+
+# example from http://wiki.bash-hackers.org/syntax/expansion/proc_subst
+# process substitutions can be passed to a function as parameters or
+# variables
+f() {
+        cat "$1" >"$x"
+}
+x=>(tr '[:lower:]' '[:upper:]') f <(echo 'hi there')
+
+# process substitution can be combined with redirection on exec
+rm -f err
+# save stderr
+exec 4>&2
+# copy stderr to a file
+exec 2> >(tee err)
+echo "hello error" >&2
+sync
+# restore stderr
+exec 2>&4
+cat err
+rm -f err
+echo "hello stderr" >&2
diff --git a/shell/hush.c b/shell/hush.c
index 144ad3edd..77921e11c 100644
--- a/shell/hush.c
+++ b/shell/hush.c
@@ -4251,7 +4251,7 @@ static int done_word(struct parse_context *ctx)
                  || endofname(command->argv[0])[0] != '\0'
                 ) {
                         /* bash says just "not a valid identifier" */
-                        syntax_error("not a valid identifier in for");
+                        syntax_error("bad variable name in for");
                         return 1;
                 }
                 /* Force FOR to have just one word (variable name) */
@@ -10799,10 +10799,17 @@ static int FAST_FUNC builtin_read(char **argv)
          */
         params.read_flags = getopt32(argv,
 # if BASH_READ_D
-                "!srn:p:t:u:d:", &params.opt_n, &params.opt_p, &params.opt_t, &params.opt_u, &params.opt_d
+                IF_NOT_HUSH_BASH_COMPAT("^")
+                "!srn:p:t:u:d:" IF_NOT_HUSH_BASH_COMPAT("\0" "-1"/*min 1 arg*/),
+                &params.opt_n, &params.opt_p, &params.opt_t, &params.opt_u, &params.opt_d
 # else
-                "!srn:p:t:u:", &params.opt_n, &params.opt_p, &params.opt_t, &params.opt_u
+                IF_NOT_HUSH_BASH_COMPAT("^")
+                "!srn:p:t:u:" IF_NOT_HUSH_BASH_COMPAT("\0" "-1"/*min 1 arg*/),
+                &params.opt_n, &params.opt_p, &params.opt_t, &params.opt_u
 # endif
+//TODO: print "read: need variable name"
+//for the case of !BASH "read" with no args (now it fails silently)
+//(or maybe extend getopt32() to emit a message if "-1" fails)
         );
         if ((uint32_t)params.read_flags == (uint32_t)-1)
                 return EXIT_FAILURE;
diff --git a/shell/shell_common.c b/shell/shell_common.c
index 1897fee3b..fff356c04 100644
--- a/shell/shell_common.c
+++ b/shell/shell_common.c
@@ -65,7 +65,7 @@ shell_builtin_read(struct builtin_read_params *params)
         while (*pp) {
                 if (endofname(*pp)[0] != '\0') {
                         /* Mimic bash message */
-                        bb_error_msg("read: '%s': not a valid identifier", *pp);
+                        bb_error_msg("read: '%s': bad variable name", *pp);
                         return (const char *)(uintptr_t)1;
                 }
                 pp++;
@@ -296,7 +296,7 @@ shell_builtin_read(struct builtin_read_params *params)
                  * without variable names (bash compat).
                  * Thus, "read" and "read REPLY" are not the same.
                  */
-                if (!params->opt_d && argv[0]) {
+                if (argv[0]) {
 /* http://www.opengroup.org/onlinepubs/9699919799/utilities/V3_chap02.html#tag_18_06_05 */
                         const char *is_ifs = strchr(ifs, c);
                         if (startword && is_ifs) {