diff options
author | Denis Vlasenko <vda.linux@googlemail.com> | 2008-10-20 08:15:51 +0000 |
---|---|---|
committer | Denis Vlasenko <vda.linux@googlemail.com> | 2008-10-20 08:15:51 +0000 |
commit | b730474bda4a964930e8013301ace7b49a0c5726 (patch) | |
tree | 67a8c0ebd37a6231017e8e8dc3598b63a8c4402c /shell | |
parent | d1660cb9ad3adb4b99c098de88f79cbeb74c3a5d (diff) | |
download | busybox-w32-b730474bda4a964930e8013301ace7b49a0c5726.tar.gz busybox-w32-b730474bda4a964930e8013301ace7b49a0c5726.tar.bz2 busybox-w32-b730474bda4a964930e8013301ace7b49a0c5726.zip |
ash: fix NOEXEC mode - we were forgetting to pass environment!
env: promote to NOEXEC
hd: promote to NOEXEC, as hexdump is NOEXEC already
Diffstat (limited to 'shell')
-rw-r--r-- | shell/ash.c | 7 | ||||
-rw-r--r-- | shell/ash_test/ash-standalone/noexec_gets_no_env.right | 2 | ||||
-rwxr-xr-x | shell/ash_test/ash-standalone/noexec_gets_no_env.tests | 3 |
3 files changed, 10 insertions, 2 deletions
diff --git a/shell/ash.c b/shell/ash.c index 70b7ae32a..81ac563fb 100644 --- a/shell/ash.c +++ b/shell/ash.c | |||
@@ -7008,8 +7008,11 @@ tryexec(USE_FEATURE_SH_STANDALONE(int applet_no,) char *cmd, char **argv, char * | |||
7008 | 7008 | ||
7009 | #if ENABLE_FEATURE_SH_STANDALONE | 7009 | #if ENABLE_FEATURE_SH_STANDALONE |
7010 | if (applet_no >= 0) { | 7010 | if (applet_no >= 0) { |
7011 | if (APPLET_IS_NOEXEC(applet_no)) | 7011 | if (APPLET_IS_NOEXEC(applet_no)) { |
7012 | while (*envp) | ||
7013 | putenv(*envp++); | ||
7012 | run_applet_no_and_exit(applet_no, argv); | 7014 | run_applet_no_and_exit(applet_no, argv); |
7015 | } | ||
7013 | /* re-exec ourselves with the new arguments */ | 7016 | /* re-exec ourselves with the new arguments */ |
7014 | execve(bb_busybox_exec_path, argv, envp); | 7017 | execve(bb_busybox_exec_path, argv, envp); |
7015 | /* If they called chroot or otherwise made the binary no longer | 7018 | /* If they called chroot or otherwise made the binary no longer |
@@ -12094,7 +12097,7 @@ exportcmd(int argc UNUSED_PARAM, char **argv) | |||
12094 | char *name; | 12097 | char *name; |
12095 | const char *p; | 12098 | const char *p; |
12096 | char **aptr; | 12099 | char **aptr; |
12097 | int flag = argv[0][0] == 'r'? VREADONLY : VEXPORT; | 12100 | int flag = argv[0][0] == 'r' ? VREADONLY : VEXPORT; |
12098 | 12101 | ||
12099 | if (nextopt("p") != 'p') { | 12102 | if (nextopt("p") != 'p') { |
12100 | aptr = argptr; | 12103 | aptr = argptr; |
diff --git a/shell/ash_test/ash-standalone/noexec_gets_no_env.right b/shell/ash_test/ash-standalone/noexec_gets_no_env.right new file mode 100644 index 000000000..3d55d73b8 --- /dev/null +++ b/shell/ash_test/ash-standalone/noexec_gets_no_env.right | |||
@@ -0,0 +1,2 @@ | |||
1 | VAR7=VAL | ||
2 | 0 | ||
diff --git a/shell/ash_test/ash-standalone/noexec_gets_no_env.tests b/shell/ash_test/ash-standalone/noexec_gets_no_env.tests new file mode 100755 index 000000000..5e12e5a25 --- /dev/null +++ b/shell/ash_test/ash-standalone/noexec_gets_no_env.tests | |||
@@ -0,0 +1,3 @@ | |||
1 | export VAR7=VAL | ||
2 | env | grep ^VAR7= | ||
3 | echo $? | ||