Per some comments from Lars Kellogg-Stedman <lars@larsshack.org>,

make xreadlink() return NULL on failure, and make sure everyone
uses the interface correctly.
 -Erik


git-svn-id: svn://busybox.net/trunk/busybox@2551 69ca8d6d-28ef-0310-b511-8ec308f3f277

1 files changed, 2 insertions, 0 deletions

diff --git a/tar.c b/tar.c
index eb085c770..135bfd186 100644
--- a/tar.c
+++ b/tar.c
@@ -922,6 +922,8 @@ writeTarHeader(struct TarBallInfo *tbInfo, const char *header_name,
                 strncpy(header.linkname, tbInfo->hlInfo->name, sizeof(header.linkname));
         } else if (S_ISLNK(statbuf->st_mode)) {
                 char *lpath = xreadlink(real_name);
+                if (!lpath) /* Already printed err msg inside xreadlink() */
+                        return ( FALSE);
                 header.typeflag  = SYMTYPE;
                 strncpy(header.linkname, lpath, sizeof(header.linkname)); 
                 free(lpath);