win32/regex: fix compile warnings

There are plenty of warnings that were not detected in Git's source
code, due to some warnings being turned off in Git's build by default
(even with DEVELOPER=1).

The warnings fall into three categories:

- constants being tested via `#if <name>` instead of `#ifdef <name>`

- unused function parameters

- one instance of an unnecessarily-shadowing variable

This patch fixes all of them.

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>

1 files changed, 1 insertions, 1 deletions

diff --git a/win32/regex_internal.c b/win32/regex_internal.c
index d4121f2f4..c33561743 100644
--- a/win32/regex_internal.c
+++ b/win32/regex_internal.c
@@ -685,7 +685,7 @@ re_string_reconstruct (re_string_t *pstr, int idx, int eflags)
                          pstr->valid_len - offset);
               pstr->valid_len -= offset;
               pstr->valid_raw_len -= offset;
-#if DEBUG
+#ifdef DEBUG
               assert (pstr->valid_len > 0);
 #endif
             }