diff options
-rw-r--r-- | NOFORK_NOEXEC.lst | 6 | ||||
-rw-r--r-- | util-linux/readprofile.c | 6 |
2 files changed, 7 insertions, 5 deletions
diff --git a/NOFORK_NOEXEC.lst b/NOFORK_NOEXEC.lst index ab58df50d..02e2ba956 100644 --- a/NOFORK_NOEXEC.lst +++ b/NOFORK_NOEXEC.lst | |||
@@ -48,7 +48,7 @@ ash - interactive, longterm | |||
48 | awk - noexec. runner | 48 | awk - noexec. runner |
49 | base64 - runner | 49 | base64 - runner |
50 | basename - NOFORK | 50 | basename - NOFORK |
51 | beep | 51 | beep - longterm: beep -r 999999999 |
52 | blkdiscard - noexec. leaks: open+xioctl | 52 | blkdiscard - noexec. leaks: open+xioctl |
53 | blkid - noexec | 53 | blkid - noexec |
54 | blockdev - noexec. leaks fd | 54 | blockdev - noexec. leaks fd |
@@ -127,7 +127,7 @@ findfs - suid | |||
127 | flash_eraseall | 127 | flash_eraseall |
128 | flash_lock | 128 | flash_lock |
129 | flash_unlock | 129 | flash_unlock |
130 | flashcp | 130 | flashcp - needs ^C. flash writing may be slow, better to free memory memory by execing |
131 | flock - spawner, changes state (file locks), let's play safe and not be noexec | 131 | flock - spawner, changes state (file locks), let's play safe and not be noexec |
132 | fold - noexec. runner | 132 | fold - noexec. runner |
133 | free - nofork candidate(struct globals, needs to close /proc/meminfo fd) | 133 | free - nofork candidate(struct globals, needs to close /proc/meminfo fd) |
@@ -278,7 +278,7 @@ raidautorun - noexec. very simple. leaks: open+xioctl | |||
278 | rdate - needs ^C (may talk to DNS servers, which may be down) | 278 | rdate - needs ^C (may talk to DNS servers, which may be down) |
279 | rdev - leaks: find_block_device -> readdir+xstrdup | 279 | rdev - leaks: find_block_device -> readdir+xstrdup |
280 | readlink - NOFORK | 280 | readlink - NOFORK |
281 | readprofile | 281 | readprofile - reads /boot/System.map and /proc/profile, better to free more memory memory by execing? |
282 | realpath - NOFORK | 282 | realpath - NOFORK |
283 | reboot - rare | 283 | reboot - rare |
284 | reformime - runner | 284 | reformime - runner |
diff --git a/util-linux/readprofile.c b/util-linux/readprofile.c index b045657d8..394ece1dd 100644 --- a/util-linux/readprofile.c +++ b/util-linux/readprofile.c | |||
@@ -266,8 +266,10 @@ int readprofile_main(int argc UNUSED_PARAM, char **argv) | |||
266 | printf("%6u %-40s %8.4f\n", | 266 | printf("%6u %-40s %8.4f\n", |
267 | total, "total", total/(double)(fn_add-add0)); | 267 | total, "total", total/(double)(fn_add-add0)); |
268 | 268 | ||
269 | fclose(map); | 269 | if (ENABLE_FEATURE_CLEAN_UP) { |
270 | free(buf); | 270 | fclose(map); |
271 | free(buf); | ||
272 | } | ||
271 | 273 | ||
272 | return EXIT_SUCCESS; | 274 | return EXIT_SUCCESS; |
273 | } | 275 | } |