aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
-rw-r--r--coreutils/sleep.c15
-rw-r--r--procps/kill.c2
2 files changed, 15 insertions, 2 deletions
diff --git a/coreutils/sleep.c b/coreutils/sleep.c
index 442841210..667db558d 100644
--- a/coreutils/sleep.c
+++ b/coreutils/sleep.c
@@ -65,15 +65,28 @@ int sleep_main(int argc UNUSED_PARAM, char **argv)
65{ 65{
66 duration_t duration; 66 duration_t duration;
67 67
68 /* Note: sleep_main may be directly called from ash as a builtin.
69 * This brings some complications:
70 * + we can't use xfunc here
71 * + we can't use bb_show_usage
72 * + applet_name can be the name of the shell
73 */
68 ++argv; 74 ++argv;
69 if (!*argv) 75 if (!*argv) {
76 /* Without this, bare "sleep" in ash shows _ash_ --help */
77 if (ENABLE_ASH_SLEEP && applet_name[0] != 's') {
78 bb_simple_error_msg("sleep: missing operand");
79 return EXIT_FAILURE;
80 }
70 bb_show_usage(); 81 bb_show_usage();
82 }
71 83
72 /* GNU sleep accepts "inf", "INF", "infinity" and "INFINITY" */ 84 /* GNU sleep accepts "inf", "INF", "infinity" and "INFINITY" */
73 if (strncasecmp(argv[0], "inf", 3) == 0) 85 if (strncasecmp(argv[0], "inf", 3) == 0)
74 for (;;) 86 for (;;)
75 sleep(INT_MAX); 87 sleep(INT_MAX);
76 88
89//FIXME: in ash, "sleep 123qwerty" as a builtin aborts the shell
77#if ENABLE_FEATURE_FANCY_SLEEP 90#if ENABLE_FEATURE_FANCY_SLEEP
78 duration = 0; 91 duration = 0;
79 do { 92 do {
diff --git a/procps/kill.c b/procps/kill.c
index 8f10e21ab..208efebde 100644
--- a/procps/kill.c
+++ b/procps/kill.c
@@ -85,8 +85,8 @@
85 * This brings some complications: 85 * This brings some complications:
86 * 86 *
87 * + we can't use xfunc here 87 * + we can't use xfunc here
88 * + we can't use applet_name
89 * + we can't use bb_show_usage 88 * + we can't use bb_show_usage
89 * + applet_name can be the name of the shell
90 * (doesn't apply for killall[5], still should be careful b/c NOFORK) 90 * (doesn't apply for killall[5], still should be careful b/c NOFORK)
91 * 91 *
92 * kill %n gets translated into kill ' -<process group>' by shell (note space!) 92 * kill %n gets translated into kill ' -<process group>' by shell (note space!)