aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
-rw-r--r--procps/sysctl.c6
1 files changed, 4 insertions, 2 deletions
diff --git a/procps/sysctl.c b/procps/sysctl.c
index 5fa7646d1..42de374d2 100644
--- a/procps/sysctl.c
+++ b/procps/sysctl.c
@@ -119,14 +119,16 @@ static int sysctl_act_on_setting(char *setting)
119 if (cptr) 119 if (cptr)
120 writing = 1; 120 writing = 1;
121 if (writing) { 121 if (writing) {
122 if (cptr == NULL) { 122 if (!cptr) {
123 bb_error_msg("error: '%s' must be of the form name=value", 123 bb_error_msg("error: '%s' must be of the form name=value",
124 outname); 124 outname);
125 retval = EXIT_FAILURE; 125 retval = EXIT_FAILURE;
126 goto end; 126 goto end;
127 } 127 }
128 value = cptr + 1; /* point to the value in name=value */ 128 value = cptr + 1; /* point to the value in name=value */
129 if (setting == cptr || !*value) { 129 if (setting == cptr /* "name" can't be empty */
130 /* || !*value - WRONG: "sysctl net.ipv4.ip_local_reserved_ports=" is a valid syntax (clears the value) */
131 ) {
130 bb_error_msg("error: malformed setting '%s'", outname); 132 bb_error_msg("error: malformed setting '%s'", outname);
131 retval = EXIT_FAILURE; 133 retval = EXIT_FAILURE;
132 goto end; 134 goto end;