aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
-rw-r--r--TODO15
-rw-r--r--e2fsprogs/old_e2fsprogs/blkid/cache.c3
-rw-r--r--e2fsprogs/old_e2fsprogs/blkid/dev.c3
-rw-r--r--e2fsprogs/old_e2fsprogs/blkid/tag.c3
-rw-r--r--libbb/appletlib.c1
-rw-r--r--libbb/dump.c4
-rwxr-xr-xtestsuite/all_sourcecode.tests2
7 files changed, 8 insertions, 23 deletions
diff --git a/TODO b/TODO
index f68c9de73..fa9a2078d 100644
--- a/TODO
+++ b/TODO
@@ -7,19 +7,16 @@ have any suggestions how they plan to go about it, and to minimize conflicts
7between your work and theirs. But otherwise, all of these are fair game. 7between your work and theirs. But otherwise, all of these are fair game.
8 8
9Rob Landley <rob@landley.net>: 9Rob Landley <rob@landley.net>:
10 Add BB_NOMMU to platform.h and migrate __uClinux__ tests to that.
11 #if defined __UCLIBC__ && !defined __ARCH_USE_MMU__
12 Add a libbb/platform.c 10 Add a libbb/platform.c
13 Implement fdprintf() for platforms that haven't got one. 11 Implement fdprintf() for platforms that haven't got one.
14 Implement bb_realpath() that can handle NULL on non-glibc. 12 Implement bb_realpath() that can handle NULL on non-glibc.
15 Cleanup bb_asprintf() 13 Cleanup bb_asprintf()
16 14
17 Migrate calloc() and bb_calloc() occurrences to bb_xzalloc().
18 Remove obsolete _() wrapper crud for internationalization we don't do. 15 Remove obsolete _() wrapper crud for internationalization we don't do.
19 Figure out where we need utf8 support, and add it. 16 Figure out where we need utf8 support, and add it.
20 17
21 sh 18 sh
22 The command shell situation is a big mess. We have three or four different 19 The command shell situation is a big mess. We have three different
23 shells that don't really share any code, and the "standalone shell" doesn't 20 shells that don't really share any code, and the "standalone shell" doesn't
24 work all that well (especially not in a chroot environment), due to apps not 21 work all that well (especially not in a chroot environment), due to apps not
25 being reentrant. 22 being reentrant.
@@ -124,9 +121,6 @@ Bernhard Fischer <busybox@busybox.net> suggests to look at these:
124As yet unclaimed: 121As yet unclaimed:
125 122
126---- 123----
127find
128 doesn't understand (), lots of susv3 stuff.
129----
130diff 124diff
131 Make sure we handle empty files properly: 125 Make sure we handle empty files properly:
132 From the patch man page: 126 From the patch man page:
@@ -143,10 +137,6 @@ patch
143 And while we're at it, a new patch filename quoting format is apparently 137 And while we're at it, a new patch filename quoting format is apparently
144 coming soon: http://marc.theaimsgroup.com/?l=git&m=112927316408690&w=2 138 coming soon: http://marc.theaimsgroup.com/?l=git&m=112927316408690&w=2
145--- 139---
146ps / top
147 Add support for both RSS and VSIZE rather than just one or the other.
148 Or make it a build option.
149---
150man 140man
151 It would be nice to have a man command. Not one that handles troff or 141 It would be nice to have a man command. Not one that handles troff or
152 anything, just one that can handle preformatted ascii man pages, possibly 142 anything, just one that can handle preformatted ascii man pages, possibly
@@ -310,9 +300,6 @@ Code cleanup:
310 300
311Replace deprecated functions. 301Replace deprecated functions.
312 302
313bzero() -> memset()
314---
315sigblock(), siggetmask(), sigsetmask(), sigmask() -> sigprocmask et al
316--- 303---
317vdprintf() -> similar sized functionality 304vdprintf() -> similar sized functionality
318--- 305---
diff --git a/e2fsprogs/old_e2fsprogs/blkid/cache.c b/e2fsprogs/old_e2fsprogs/blkid/cache.c
index 9bae6fb67..d1d29146b 100644
--- a/e2fsprogs/old_e2fsprogs/blkid/cache.c
+++ b/e2fsprogs/old_e2fsprogs/blkid/cache.c
@@ -35,8 +35,7 @@ int blkid_get_cache(blkid_cache *ret_cache, const char *filename)
35 DBG(DEBUG_CACHE, printf("creating blkid cache (using %s)\n", 35 DBG(DEBUG_CACHE, printf("creating blkid cache (using %s)\n",
36 filename ? filename : "default cache")); 36 filename ? filename : "default cache"));
37 37
38 if (!(cache = (blkid_cache) calloc(1, sizeof(struct blkid_struct_cache)))) 38 cache = xzalloc(sizeof(struct blkid_struct_cache));
39 return -BLKID_ERR_MEM;
40 39
41 INIT_LIST_HEAD(&cache->bic_devs); 40 INIT_LIST_HEAD(&cache->bic_devs);
42 INIT_LIST_HEAD(&cache->bic_tags); 41 INIT_LIST_HEAD(&cache->bic_tags);
diff --git a/e2fsprogs/old_e2fsprogs/blkid/dev.c b/e2fsprogs/old_e2fsprogs/blkid/dev.c
index f6503f179..bb0cc914a 100644
--- a/e2fsprogs/old_e2fsprogs/blkid/dev.c
+++ b/e2fsprogs/old_e2fsprogs/blkid/dev.c
@@ -20,8 +20,7 @@ blkid_dev blkid_new_dev(void)
20{ 20{
21 blkid_dev dev; 21 blkid_dev dev;
22 22
23 if (!(dev = (blkid_dev) calloc(1, sizeof(struct blkid_struct_dev)))) 23 dev = xzalloc(sizeof(struct blkid_struct_dev));
24 return NULL;
25 24
26 INIT_LIST_HEAD(&dev->bid_devs); 25 INIT_LIST_HEAD(&dev->bid_devs);
27 INIT_LIST_HEAD(&dev->bid_tags); 26 INIT_LIST_HEAD(&dev->bid_tags);
diff --git a/e2fsprogs/old_e2fsprogs/blkid/tag.c b/e2fsprogs/old_e2fsprogs/blkid/tag.c
index 006a393fa..c0a93df98 100644
--- a/e2fsprogs/old_e2fsprogs/blkid/tag.c
+++ b/e2fsprogs/old_e2fsprogs/blkid/tag.c
@@ -21,8 +21,7 @@ static blkid_tag blkid_new_tag(void)
21{ 21{
22 blkid_tag tag; 22 blkid_tag tag;
23 23
24 if (!(tag = (blkid_tag) calloc(1, sizeof(struct blkid_struct_tag)))) 24 tag = xzalloc(sizeof(struct blkid_struct_tag));
25 return NULL;
26 25
27 INIT_LIST_HEAD(&tag->bit_tags); 26 INIT_LIST_HEAD(&tag->bit_tags);
28 INIT_LIST_HEAD(&tag->bit_names); 27 INIT_LIST_HEAD(&tag->bit_names);
diff --git a/libbb/appletlib.c b/libbb/appletlib.c
index aade9046a..e2bb37868 100644
--- a/libbb/appletlib.c
+++ b/libbb/appletlib.c
@@ -264,6 +264,7 @@ static void parse_config_file(void)
264 s = buffer; 264 s = buffer;
265 265
266 if (!fgets(s, sizeof(buffer), f)) { /* Are we done? */ 266 if (!fgets(s, sizeof(buffer), f)) { /* Are we done? */
267// why?
267 if (ferror(f)) { /* Make sure it wasn't a read error. */ 268 if (ferror(f)) { /* Make sure it wasn't a read error. */
268 parse_error("reading"); 269 parse_error("reading");
269 } 270 }
diff --git a/libbb/dump.c b/libbb/dump.c
index 5e43d42a4..4d6472e37 100644
--- a/libbb/dump.c
+++ b/libbb/dump.c
@@ -95,7 +95,7 @@ static void rewrite(FS * fs)
95 */ 95 */
96 for (nconv = 0, fmtp = fu->fmt; *fmtp; nextpr = &pr->nextpr) { 96 for (nconv = 0, fmtp = fu->fmt; *fmtp; nextpr = &pr->nextpr) {
97 /* NOSTRICT */ 97 /* NOSTRICT */
98 /* DBU:[dvae@cray.com] calloc so that forward ptrs start out NULL*/ 98 /* DBU:[dvae@cray.com] zalloc so that forward ptrs start out NULL*/
99 pr = xzalloc(sizeof(PR)); 99 pr = xzalloc(sizeof(PR));
100 if (!fu->nextpr) 100 if (!fu->nextpr)
101 fu->nextpr = pr; 101 fu->nextpr = pr;
@@ -704,7 +704,7 @@ void bb_dump_add(const char *fmt)
704 704
705 /* allocate a new format unit and link it in */ 705 /* allocate a new format unit and link it in */
706 /* NOSTRICT */ 706 /* NOSTRICT */
707 /* DBU:[dave@cray.com] calloc so that forward pointers start out NULL */ 707 /* DBU:[dave@cray.com] zalloc so that forward pointers start out NULL */
708 tfu = xzalloc(sizeof(FU)); 708 tfu = xzalloc(sizeof(FU));
709 *nextfu = tfu; 709 *nextfu = tfu;
710 nextfu = &tfu->nextfu; 710 nextfu = &tfu->nextfu;
diff --git a/testsuite/all_sourcecode.tests b/testsuite/all_sourcecode.tests
index 86f61b7c3..45f401127 100755
--- a/testsuite/all_sourcecode.tests
+++ b/testsuite/all_sourcecode.tests
@@ -73,7 +73,7 @@ rm -f src.typos
73# don't allow obsolete functions 73# don't allow obsolete functions
74# 74#
75find $srcdir/.. '(' -name '*.c' -o -name '*.h' ')' -print0 | xargs -0 \ 75find $srcdir/.. '(' -name '*.c' -o -name '*.h' ')' -print0 | xargs -0 \
76 grep -E -e '\<(bcmp|bcopy|bzero|getwd|index|mktemp|rindex|utimes)\>[[:space:]]*\(' \ 76 grep -E -e '\<(bcmp|bcopy|bzero|getwd|index|mktemp|rindex|utimes|sigblock|siggetmask|sigsetmask)\>[[:space:]]*\(' \
77 | sed -e "s:^$srcdir/\.\./::g" > src.obsolete.funcs 77 | sed -e "s:^$srcdir/\.\./::g" > src.obsolete.funcs
78testing "Obsolete function usage" "cat src.obsolete.funcs" "" "" "" 78testing "Obsolete function usage" "cat src.obsolete.funcs" "" "" ""
79rm -f src.obsolete.funcs 79rm -f src.obsolete.funcs