aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
-rw-r--r--loginutils/login.c8
1 files changed, 5 insertions, 3 deletions
diff --git a/loginutils/login.c b/loginutils/login.c
index 25bb5203b..4df651cc6 100644
--- a/loginutils/login.c
+++ b/loginutils/login.c
@@ -245,7 +245,9 @@ static void login_pam_end(pam_handle_t *pamh)
245 pam_strerror(pamh, pamret), pamret); 245 pam_strerror(pamh, pamret), pamret);
246 } 246 }
247} 247}
248#endif /* ENABLE_PAM */ 248#else
249# define login_pam_end(pamh) ((void)0)
250#endif
249 251
250static void get_username_or_die(char *buf, int size_buf) 252static void get_username_or_die(char *buf, int size_buf)
251{ 253{
@@ -471,6 +473,7 @@ int login_main(int argc UNUSED_PARAM, char **argv)
471 * to know _why_ login failed */ 473 * to know _why_ login failed */
472 syslog(LOG_WARNING, "pam_%s call failed: %s (%d)", failed_msg, 474 syslog(LOG_WARNING, "pam_%s call failed: %s (%d)", failed_msg,
473 pam_strerror(pamh, pamret), pamret); 475 pam_strerror(pamh, pamret), pamret);
476 login_pam_end(pamh);
474 safe_strncpy(username, "UNKNOWN", sizeof(username)); 477 safe_strncpy(username, "UNKNOWN", sizeof(username));
475#else /* not PAM */ 478#else /* not PAM */
476 pw = getpwnam(username); 479 pw = getpwnam(username);
@@ -528,8 +531,7 @@ int login_main(int argc UNUSED_PARAM, char **argv)
528 if (child_pid < 0) 531 if (child_pid < 0)
529 bb_perror_msg("vfork"); 532 bb_perror_msg("vfork");
530 else { 533 else {
531 if (safe_waitpid(child_pid, NULL, 0) == -1) 534 wait_for_exitstatus(child_pid);
532 bb_perror_msg("waitpid");
533 update_utmp_DEAD_PROCESS(child_pid); 535 update_utmp_DEAD_PROCESS(child_pid);
534 } 536 }
535 IF_PAM(login_pam_end(pamh);) 537 IF_PAM(login_pam_end(pamh);)