diff options
-rw-r--r-- | include/libbb.h | 11 | ||||
-rw-r--r-- | libbb/skip_whitespace.c | 13 |
2 files changed, 20 insertions, 4 deletions
diff --git a/include/libbb.h b/include/libbb.h index 97dbe8687..fb7296f25 100644 --- a/include/libbb.h +++ b/include/libbb.h | |||
@@ -1576,7 +1576,6 @@ extern const char bb_default_login_shell[]; | |||
1576 | #undef islower | 1576 | #undef islower |
1577 | #undef isprint | 1577 | #undef isprint |
1578 | #undef ispunct | 1578 | #undef ispunct |
1579 | #undef isspace | ||
1580 | #undef isupper | 1579 | #undef isupper |
1581 | #undef isxdigit | 1580 | #undef isxdigit |
1582 | 1581 | ||
@@ -1584,6 +1583,16 @@ extern const char bb_default_login_shell[]; | |||
1584 | #undef isdigit | 1583 | #undef isdigit |
1585 | #define isdigit(a) ((unsigned)((a) - '0') <= 9) | 1584 | #define isdigit(a) ((unsigned)((a) - '0') <= 9) |
1586 | 1585 | ||
1586 | /* This one is more efficient too! ~200 bytes */ | ||
1587 | /* In POSIX/C locale (the only locale we care about: do we REALLY want | ||
1588 | * to allow Unicode whitespace in, say, .conf files? nuts!) | ||
1589 | * isspace is only these chars: "\t\n\v\f\r" and space. | ||
1590 | * "\t\n\v\f\r" happen to have ASCII codes 9,10,11,12,13. | ||
1591 | * Use that. | ||
1592 | */ | ||
1593 | #undef isspace | ||
1594 | #define isspace(a) ({ unsigned char bb__isspace = (a) - 9; bb__isspace == (' ' - 9) || bb__isspace <= (13 - 9); }) | ||
1595 | |||
1587 | #define ARRAY_SIZE(x) ((unsigned)(sizeof(x) / sizeof((x)[0]))) | 1596 | #define ARRAY_SIZE(x) ((unsigned)(sizeof(x) / sizeof((x)[0]))) |
1588 | 1597 | ||
1589 | 1598 | ||
diff --git a/libbb/skip_whitespace.c b/libbb/skip_whitespace.c index e85f3859f..7b123261b 100644 --- a/libbb/skip_whitespace.c +++ b/libbb/skip_whitespace.c | |||
@@ -11,15 +11,22 @@ | |||
11 | 11 | ||
12 | char* FAST_FUNC skip_whitespace(const char *s) | 12 | char* FAST_FUNC skip_whitespace(const char *s) |
13 | { | 13 | { |
14 | /* NB: isspace('\0') returns 0 */ | 14 | /* In POSIX/C locale (the only locale we care about: do we REALLY want |
15 | while (isspace(*s)) ++s; | 15 | * to allow Unicode whitespace in, say, .conf files? nuts!) |
16 | * isspace is only these chars: "\t\n\v\f\r" and space. | ||
17 | * "\t\n\v\f\r" happen to have ASCII codes 9,10,11,12,13. | ||
18 | * Use that. | ||
19 | */ | ||
20 | while (*s == ' ' || (unsigned char)(*s - 9) <= (13 - 9)) | ||
21 | s++; | ||
16 | 22 | ||
17 | return (char *) s; | 23 | return (char *) s; |
18 | } | 24 | } |
19 | 25 | ||
20 | char* FAST_FUNC skip_non_whitespace(const char *s) | 26 | char* FAST_FUNC skip_non_whitespace(const char *s) |
21 | { | 27 | { |
22 | while (*s && !isspace(*s)) ++s; | 28 | while (*s != '\0' && *s != ' ' && (unsigned char)(*s - 9) > (13 - 9)) |
29 | s++; | ||
23 | 30 | ||
24 | return (char *) s; | 31 | return (char *) s; |
25 | } | 32 | } |