diff options
-rw-r--r-- | docs/contributing.txt | 14 |
1 files changed, 7 insertions, 7 deletions
diff --git a/docs/contributing.txt b/docs/contributing.txt index bf6dedfe8..0d2f553ed 100644 --- a/docs/contributing.txt +++ b/docs/contributing.txt | |||
@@ -171,7 +171,7 @@ Consult Existing Sources | |||
171 | For a quick listing of "needs work" spots in the sources, cd into the Busybox | 171 | For a quick listing of "needs work" spots in the sources, cd into the Busybox |
172 | directory and run the following: | 172 | directory and run the following: |
173 | 173 | ||
174 | for i in TODO FIXME XXX; do grep $i *.[ch]; done | 174 | for i in TODO FIXME XXX; do find -name '*.[ch]'|xargs grep $i; done |
175 | 175 | ||
176 | This will show all of the trouble spots or 'questionable' code. Pick a spot, | 176 | This will show all of the trouble spots or 'questionable' code. Pick a spot, |
177 | any spot, these are all invitations for you to contribute. | 177 | any spot, these are all invitations for you to contribute. |
@@ -199,16 +199,16 @@ Janitorial Work | |||
199 | 199 | ||
200 | These are dirty jobs, but somebody's gotta do 'em. | 200 | These are dirty jobs, but somebody's gotta do 'em. |
201 | 201 | ||
202 | - Converting applets to use getopt() for option processing. Type 'grep -L | 202 | - Converting applets to use getopt() for option processing. Type 'find -name |
203 | getopt *.c' to get a listing of the applets that currently don't use | 203 | '*.c'|grep -L getopt' to get a listing of the applets that currently don't |
204 | getopt. If a .c file processes no options, it should have a line that | 204 | use getopt. If a .c file processes no options, it should have a line that |
205 | reads: /* no options, no getopt */ somewhere in the file. | 205 | reads: /* no options, no getopt */ somewhere in the file. |
206 | 206 | ||
207 | - Replace any "naked" calls to malloc, calloc, realloc, str[n]dup, fopen with | 207 | - Replace any "naked" calls to malloc, calloc, realloc, str[n]dup, fopen with |
208 | the x* equivalents found in utility.c. | 208 | the x* equivalents found in libbb/xfuncs.c. |
209 | 209 | ||
210 | - Security audits: | 210 | - Security audits: |
211 | http://www.securityfocus.com/frames/?content=/forums/secprog/secure-programming.html | 211 | http://www.securityfocus.com/popups/forums/secprog/intro.shtml |
212 | 212 | ||
213 | - Synthetic code removal: http://www.perl.com/pub/2000/06/commify.html - This | 213 | - Synthetic code removal: http://www.perl.com/pub/2000/06/commify.html - This |
214 | is very Perl-specific, but the advice given in here applies equally well to | 214 | is very Perl-specific, but the advice given in here applies equally well to |
@@ -231,7 +231,7 @@ These are dirty jobs, but somebody's gotta do 'em. | |||
231 | 231 | ||
232 | - "Ten Commandments" compliance: (this is a "maybe", certainly not as | 232 | - "Ten Commandments" compliance: (this is a "maybe", certainly not as |
233 | important as any of the previous items.) | 233 | important as any of the previous items.) |
234 | http://web.onetelnet.ch/~twolf/tw/c/ten_commandments.html | 234 | http://www.lysator.liu.se/c/ten-commandments.html |
235 | 235 | ||
236 | Other useful links: | 236 | Other useful links: |
237 | 237 | ||