diff options
Diffstat (limited to 'archival')
-rw-r--r-- | archival/bbunzip.c | 9 | ||||
-rw-r--r-- | archival/tar.c | 5 |
2 files changed, 4 insertions, 10 deletions
diff --git a/archival/bbunzip.c b/archival/bbunzip.c index 3c3cc2886..4dba498b8 100644 --- a/archival/bbunzip.c +++ b/archival/bbunzip.c | |||
@@ -20,16 +20,11 @@ enum { | |||
20 | static | 20 | static |
21 | int open_to_or_warn(int to_fd, const char *filename, int flags, int mode) | 21 | int open_to_or_warn(int to_fd, const char *filename, int flags, int mode) |
22 | { | 22 | { |
23 | int fd = open(filename, flags, mode); | 23 | int fd = open3_or_warn(filename, flags, mode); |
24 | if (fd < 0) { | 24 | if (fd < 0) { |
25 | bb_perror_msg("%s", filename); | ||
26 | return 1; | 25 | return 1; |
27 | } | 26 | } |
28 | if (fd != to_fd) { | 27 | xmove_fd(fd, to_fd); |
29 | if (dup2(fd, to_fd) < 0) | ||
30 | bb_perror_msg_and_die("cannot dup"); | ||
31 | close(fd); | ||
32 | } | ||
33 | return 0; | 28 | return 0; |
34 | } | 29 | } |
35 | 30 | ||
diff --git a/archival/tar.c b/archival/tar.c index f2f1ccd06..11a74dfe9 100644 --- a/archival/tar.c +++ b/archival/tar.c | |||
@@ -440,9 +440,8 @@ static int writeFileToTarball(const char *fileName, struct stat *statbuf, | |||
440 | /* Is this a regular file? */ | 440 | /* Is this a regular file? */ |
441 | if (tbInfo->hlInfo == NULL && S_ISREG(statbuf->st_mode)) { | 441 | if (tbInfo->hlInfo == NULL && S_ISREG(statbuf->st_mode)) { |
442 | /* open the file we want to archive, and make sure all is well */ | 442 | /* open the file we want to archive, and make sure all is well */ |
443 | inputFileFd = open(fileName, O_RDONLY); | 443 | inputFileFd = open_or_warn(fileName, O_RDONLY); |
444 | if (inputFileFd < 0) { | 444 | if (inputFileFd < 0) { |
445 | bb_perror_msg("%s: cannot open", fileName); | ||
446 | return FALSE; | 445 | return FALSE; |
447 | } | 446 | } |
448 | } | 447 | } |
@@ -455,7 +454,7 @@ static int writeFileToTarball(const char *fileName, struct stat *statbuf, | |||
455 | /* If it was a regular file, write out the body */ | 454 | /* If it was a regular file, write out the body */ |
456 | if (inputFileFd >= 0) { | 455 | if (inputFileFd >= 0) { |
457 | size_t readSize; | 456 | size_t readSize; |
458 | /* Wwrite the file to the archive. */ | 457 | /* Write the file to the archive. */ |
459 | /* We record size into header first, */ | 458 | /* We record size into header first, */ |
460 | /* and then write out file. If file shrinks in between, */ | 459 | /* and then write out file. If file shrinks in between, */ |
461 | /* tar will be corrupted. So we don't allow for that. */ | 460 | /* tar will be corrupted. So we don't allow for that. */ |