1 files changed, 19 insertions, 3 deletions

diff --git a/coreutils/cp.c b/coreutils/cp.c
index 5b34c27e7..455bffbba 100644
--- a/coreutils/cp.c
+++ b/coreutils/cp.c
@@ -26,6 +26,7 @@
 //config:       Also add support for --parents option.
 
 //applet:IF_CP(APPLET_NOEXEC(cp, cp, BB_DIR_BIN, BB_SUID_DROP, cp))
+/* NOEXEC despite cases when it can be a "runner" (cp -r LARGE_DIR NEW_DIR) */
 
 //kbuild:lib-$(CONFIG_CP) += cp.o
 
@@ -47,6 +48,7 @@
 //usage:     "\n        -f      Overwrite"
 //usage:     "\n        -i      Prompt before overwrite"
 //usage:     "\n        -l,-s   Create (sym)links"
+//usage:     "\n        -T      Treat DEST as a normal file"
 //usage:     "\n        -u      Copy only newer files"
 
 #include "libbb.h"
@@ -92,13 +94,18 @@ int cp_main(int argc, char **argv)
                 "no-dereference\0" No_argument "P"
                 "recursive\0"      No_argument "R"
                 "symbolic-link\0"  No_argument "s"
+                "no-target-directory\0" No_argument "T"
                 "verbose\0"        No_argument "v"
                 "update\0"         No_argument "u"
                 "remove-destination\0" No_argument "\xff"
                 "parents\0"        No_argument "\xfe"
         );
 #else
-        flags = getopt32(argv, FILEUTILS_CP_OPTSTR);
+        flags = getopt32(argv, "^"
+                FILEUTILS_CP_OPTSTR
+                "\0"
+                "-2:l--s:s--l:Pd:rRd:Rd:apdR"
+        );
 #endif
         /* Options of cp from GNU coreutils 6.10:
          * -a, --archive
@@ -121,6 +128,8 @@ int cp_main(int argc, char **argv)
          *      remove each existing destination file before attempting to open
          * --parents
          *      use full source file name under DIRECTORY
+         * -T, --no-target-directory
+         *      treat DEST as a normal file
          * NOT SUPPORTED IN BBOX:
          * --backup[=CONTROL]
          *      make a backup of each existing destination file
@@ -139,8 +148,6 @@ int cp_main(int argc, char **argv)
          *      override the usual backup suffix
          * -t, --target-directory=DIRECTORY
          *      copy all SOURCE arguments into DIRECTORY
-         * -T, --no-target-directory
-         *      treat DEST as a normal file
          * -x, --one-file-system
          *      stay on this file system
          * -Z, --context=CONTEXT
@@ -175,6 +182,12 @@ int cp_main(int argc, char **argv)
                 if (d_flags < 0)
                         return EXIT_FAILURE;
 
+                if (flags & FILEUTILS_NO_TARGET_DIR) { /* -T */
+                        if (!(s_flags & 2) && (d_flags & 2))
+                                /* cp -T NOTDIR DIR */
+                                bb_error_msg_and_die("'%s' is a directory", last);
+                }
+
 #if ENABLE_FEATURE_CP_LONG_OPTIONS
                 //bb_error_msg("flags:%x FILEUTILS_RMDEST:%x OPT_parents:%x",
                 //      flags, FILEUTILS_RMDEST, OPT_parents);
@@ -192,11 +205,14 @@ int cp_main(int argc, char **argv)
                 if (!((s_flags | d_flags) & 2)
                     /* ...or: recursing, the 1st is a directory, and the 2nd doesn't exist... */
                  || ((flags & FILEUTILS_RECUR) && (s_flags & 2) && !d_flags)
+                 || (flags & FILEUTILS_NO_TARGET_DIR)
                 ) {
                         /* Do a simple copy */
                         dest = last;
                         goto DO_COPY; /* NB: argc==2 -> *++argv==last */
                 }
+        } else if (flags & FILEUTILS_NO_TARGET_DIR) {
+                bb_error_msg_and_die("too many arguments");
         }
 
         while (1) {