diff options
Diffstat (limited to 'libbb')
-rw-r--r-- | libbb/appletlib.c | 2 | ||||
-rw-r--r-- | libbb/vfork_daemon_rexec.c | 37 |
2 files changed, 21 insertions, 18 deletions
diff --git a/libbb/appletlib.c b/libbb/appletlib.c index ce259446b..5b84920a4 100644 --- a/libbb/appletlib.c +++ b/libbb/appletlib.c | |||
@@ -924,8 +924,6 @@ void FAST_FUNC run_applet_no_and_exit(int applet_no, const char *name, char **ar | |||
924 | { | 924 | { |
925 | int argc = string_array_len(argv); | 925 | int argc = string_array_len(argv); |
926 | 926 | ||
927 | /* Reinit some shared global data */ | ||
928 | xfunc_error_retval = EXIT_FAILURE; | ||
929 | /* | 927 | /* |
930 | * We do not use argv[0]: do not want to repeat massaging of | 928 | * We do not use argv[0]: do not want to repeat massaging of |
931 | * "-/sbin/halt" -> "halt", for example. | 929 | * "-/sbin/halt" -> "halt", for example. |
diff --git a/libbb/vfork_daemon_rexec.c b/libbb/vfork_daemon_rexec.c index 9d3cb9d54..a349459f0 100644 --- a/libbb/vfork_daemon_rexec.c +++ b/libbb/vfork_daemon_rexec.c | |||
@@ -158,6 +158,26 @@ int FAST_FUNC run_nofork_applet(int applet_no, char **argv) | |||
158 | } | 158 | } |
159 | #endif /* FEATURE_PREFER_APPLETS || FEATURE_SH_NOFORK */ | 159 | #endif /* FEATURE_PREFER_APPLETS || FEATURE_SH_NOFORK */ |
160 | 160 | ||
161 | #if (NUM_APPLETS > 1) && (ENABLE_FEATURE_PREFER_APPLETS || ENABLE_FEATURE_SH_STANDALONE) | ||
162 | void FAST_FUNC run_noexec_applet_and_exit(int a, const char *name, char **argv) | ||
163 | { | ||
164 | /* reset some state and run without execing */ | ||
165 | /* msg_eol = "\n"; - no caller needs this reinited yet */ | ||
166 | logmode = LOGMODE_STDIO; | ||
167 | xfunc_error_retval = EXIT_FAILURE; | ||
168 | die_func = NULL; | ||
169 | GETOPT_RESET(); | ||
170 | |||
171 | //TODO: think pidof, pgrep, pkill! | ||
172 | //set_task_comm() makes our pidof find NOEXECs (e.g. "yes >/dev/null"), | ||
173 | //but one from procps-ng-3.3.10 needs more! | ||
174 | //Rewrite /proc/PID/cmdline? (need to save argv0 and length at init for this to work!) | ||
175 | set_task_comm(name); | ||
176 | /* xfunc_error_retval and applet_name are init by: */ | ||
177 | run_applet_no_and_exit(a, name, argv); | ||
178 | } | ||
179 | #endif | ||
180 | |||
161 | int FAST_FUNC spawn_and_wait(char **argv) | 181 | int FAST_FUNC spawn_and_wait(char **argv) |
162 | { | 182 | { |
163 | int rc; | 183 | int rc; |
@@ -175,22 +195,7 @@ int FAST_FUNC spawn_and_wait(char **argv) | |||
175 | return wait4pid(rc); | 195 | return wait4pid(rc); |
176 | 196 | ||
177 | /* child */ | 197 | /* child */ |
178 | /* reset some state and run without execing */ | 198 | run_noexec_applet_and_exit(a, argv[0], argv); |
179 | GETOPT_RESET(); | ||
180 | |||
181 | /* msg_eol = "\n"; - no caller needs this reinited yet */ | ||
182 | logmode = LOGMODE_STDIO; | ||
183 | /* die_func = NULL; - needed if the caller is a shell, | ||
184 | * init, or a NOFORK applet. But none of those call us | ||
185 | * as of yet (and that should probably always stay true). | ||
186 | */ | ||
187 | //TODO: think pidof, pgrep, pkill! | ||
188 | //set_task_comm() makes our pidof find NOEXECs (e.g. "yes >/dev/null"), | ||
189 | //but one from procps-ng-3.3.10 needs more! | ||
190 | //Rewrite /proc/PID/cmdline? (need to save argv0 and length at init for this to work!) | ||
191 | set_task_comm(argv[0]); | ||
192 | /* xfunc_error_retval and applet_name are init by: */ | ||
193 | run_applet_no_and_exit(a, argv[0], argv); | ||
194 | } | 199 | } |
195 | # endif | 200 | # endif |
196 | } | 201 | } |