aboutsummaryrefslogtreecommitdiff
path: root/libbb
diff options
context:
space:
mode:
Diffstat (limited to 'libbb')
-rw-r--r--libbb/lineedit.c17
1 files changed, 10 insertions, 7 deletions
diff --git a/libbb/lineedit.c b/libbb/lineedit.c
index d6b2e76ff..b942f540a 100644
--- a/libbb/lineedit.c
+++ b/libbb/lineedit.c
@@ -2180,7 +2180,8 @@ static int lineedit_read_key(char *read_key_buffer, int timeout)
2180 * "\xff\n",pause,"ls\n" invalid and thus won't lose "ls". 2180 * "\xff\n",pause,"ls\n" invalid and thus won't lose "ls".
2181 * 2181 *
2182 * If LI_INTERRUPTIBLE, return -1 if got EINTR in poll() 2182 * If LI_INTERRUPTIBLE, return -1 if got EINTR in poll()
2183 * inside read_key, or if bb_got_signal != 0 (IOW: if signal 2183 * inside read_key and bb_got_signal became != 0,
2184 * or if bb_got_signal != 0 (IOW: if signal
2184 * arrived before poll() is reached). 2185 * arrived before poll() is reached).
2185 * 2186 *
2186 * Note: read_key sets errno to 0 on success. 2187 * Note: read_key sets errno to 0 on success.
@@ -2197,14 +2198,16 @@ static int lineedit_read_key(char *read_key_buffer, int timeout)
2197 IF_FEATURE_EDITING_WINCH(S.ok_to_redraw = 0;) 2198 IF_FEATURE_EDITING_WINCH(S.ok_to_redraw = 0;)
2198 if (errno != EINTR) 2199 if (errno != EINTR)
2199 break; 2200 break;
2201 /* It was EINTR. Repeat read_key() unless... */
2200 if (state->flags & LI_INTERRUPTIBLE) { 2202 if (state->flags & LI_INTERRUPTIBLE) {
2201 /* LI_INTERRUPTIBLE bails out on EINTR, 2203 /* LI_INTERRUPTIBLE bails out on EINTR
2202 * but nothing really guarantees that bb_got_signal 2204 * if bb_got_signal became nonzero.
2203 * is nonzero. Follow the least surprise principle: 2205 * (It may stay zero: for example, our SIGWINCH
2206 * handler does not set it. This is used for signals
2207 * which should not interrupt line editing).
2204 */ 2208 */
2205 if (bb_got_signal == 0) 2209 if (bb_got_signal != 0)
2206 bb_got_signal = 255; 2210 goto ret; /* will return -1 */
2207 goto ret;
2208 } 2211 }
2209 } 2212 }
2210 2213