diff options
Diffstat (limited to 'loginutils/adduser.c')
-rw-r--r-- | loginutils/adduser.c | 16 |
1 files changed, 9 insertions, 7 deletions
diff --git a/loginutils/adduser.c b/loginutils/adduser.c index 1944d9d56..a05b72158 100644 --- a/loginutils/adduser.c +++ b/loginutils/adduser.c | |||
@@ -82,21 +82,23 @@ static void passwd_study(struct passwd *p) | |||
82 | 82 | ||
83 | static void addgroup_wrapper(struct passwd *p, const char *group_name) | 83 | static void addgroup_wrapper(struct passwd *p, const char *group_name) |
84 | { | 84 | { |
85 | char *argv[5]; | 85 | char *argv[6]; |
86 | 86 | ||
87 | argv[0] = (char*)"addgroup"; | 87 | argv[0] = (char*)"addgroup"; |
88 | if (group_name) { | 88 | if (group_name) { |
89 | /* Add user to existing group */ | 89 | /* Add user to existing group */ |
90 | argv[1] = p->pw_name; | 90 | argv[1] = (char*)"--"; |
91 | argv[2] = (char*)group_name; | 91 | argv[2] = p->pw_name; |
92 | argv[3] = NULL; | 92 | argv[3] = (char*)group_name; |
93 | argv[4] = NULL; | ||
93 | } else { | 94 | } else { |
94 | /* Add user to his own group with the first free gid found in passwd_study */ | 95 | /* Add user to his own group with the first free gid found in passwd_study */ |
95 | //TODO: to be compatible with external addgroup programs we should use --gid instead... | 96 | //TODO: to be compatible with external addgroup programs we should use --gid instead... |
96 | argv[1] = (char*)"-g"; | 97 | argv[1] = (char*)"-g"; |
97 | argv[2] = utoa(p->pw_gid); | 98 | argv[2] = utoa(p->pw_gid); |
98 | argv[3] = p->pw_name; | 99 | argv[3] = (char*)"--"; |
99 | argv[4] = NULL; | 100 | argv[4] = p->pw_name; |
101 | argv[5] = NULL; | ||
100 | } | 102 | } |
101 | 103 | ||
102 | spawn_and_wait(argv); | 104 | spawn_and_wait(argv); |
@@ -106,7 +108,7 @@ static void passwd_wrapper(const char *login_name) NORETURN; | |||
106 | 108 | ||
107 | static void passwd_wrapper(const char *login_name) | 109 | static void passwd_wrapper(const char *login_name) |
108 | { | 110 | { |
109 | BB_EXECLP("passwd", "passwd", login_name, NULL); | 111 | BB_EXECLP("passwd", "passwd", "--", login_name, NULL); |
110 | bb_error_msg_and_die("can't execute passwd, you must set password manually"); | 112 | bb_error_msg_and_die("can't execute passwd, you must set password manually"); |
111 | } | 113 | } |
112 | 114 | ||