5 files changed, 18 insertions, 14 deletions

diff --git a/miscutils/devfsd.c b/miscutils/devfsd.c
index e5bb8a2d8..839d00fd0 100644
--- a/miscutils/devfsd.c
+++ b/miscutils/devfsd.c
@@ -453,7 +453,7 @@ int devfsd_main(int argc, char **argv)
                                 DEVFSD_PROTOCOL_REVISION_DAEMON, bb_msg_proto_rev, proto_rev);
                 if (DEVFSD_PROTOCOL_REVISION_DAEMON != proto_rev)
                         bb_error_msg_and_die("%s mismatch!", bb_msg_proto_rev);
-                exit(EXIT_SUCCESS); /* -v */
+                exit_SUCCESS(); /* -v */
         }
         /*  Tell kernel we are special(i.e. we get to see hidden entries)  */
         xioctl(fd, DEVFSDIOC_SET_EVENT_MASK, 0);
@@ -474,7 +474,7 @@ int devfsd_main(int argc, char **argv)
         dir_operation(SERVICE, mount_point, 0, NULL);
 
         if (ENABLE_DEVFSD_FG_NP && no_polling)
-                exit(EXIT_SUCCESS);
+                exit_SUCCESS();
 
         if (ENABLE_DEVFSD_VERBOSE || ENABLE_DEBUG)
                 logmode = LOGMODE_BOTH;
diff --git a/miscutils/hdparm.c b/miscutils/hdparm.c
index 01b4e8e2e..d8d8f6166 100644
--- a/miscutils/hdparm.c
+++ b/miscutils/hdparm.c
@@ -1271,7 +1271,7 @@ static void identify(uint16_t *val)
                 }
         }
 
-        exit(EXIT_SUCCESS);
+        exit_SUCCESS();
 }
 #endif
 
diff --git a/miscutils/i2c_tools.c b/miscutils/i2c_tools.c
index b25d49792..e3741eeba 100644
--- a/miscutils/i2c_tools.c
+++ b/miscutils/i2c_tools.c
@@ -1212,7 +1212,7 @@ static void NORETURN list_i2c_busses_and_exit(void)
                 }
         }
 
-        exit(EXIT_SUCCESS);
+        exit_SUCCESS();
 }
 
 static void NORETURN no_support(const char *cmd)
diff --git a/miscutils/less.c b/miscutils/less.c
index 063c4d378..6da991a0e 100644
--- a/miscutils/less.c
+++ b/miscutils/less.c
@@ -333,7 +333,7 @@ static void print_statusline(const char *str)
 }
 
 /* Exit the program gracefully */
-static void less_exit(int code)
+static void restore_tty(void)
 {
         set_tty_cooked();
         if (!(G.kbd_fd_orig_flags & O_NONBLOCK))
@@ -343,9 +343,12 @@ static void less_exit(int code)
 #else
         printf(ESC"[?1049l");
 #endif
-        if (code < 0)
-                kill_myself_with_sig(- code); /* does not return */
-        exit(code);
+}
+
+static NOINLINE void less_exit(void)
+{
+        restore_tty();
+        exit_SUCCESS();
 }
 
 #if (ENABLE_FEATURE_LESS_DASHCMD && ENABLE_FEATURE_LESS_LINENUMS) \
@@ -949,7 +952,7 @@ static void buffer_print(void)
         ) {
                 i = option_mask32 & FLAG_F ? 0 : cur_fline;
                 if (max_fline - i <= max_displayed_line)
-                        less_exit(EXIT_SUCCESS);
+                        less_exit();
         }
         status_print();
 }
@@ -1186,7 +1189,7 @@ static int64_t getch_nowait(void)
                         goto again;
                 }
                 /* EOF/error (ssh session got killed etc) */
-                less_exit(EXIT_SUCCESS);
+                less_exit();
         }
         set_tty_cooked();
         return key64;
@@ -1377,7 +1380,7 @@ static void colon_process(void)
                 change_file(-1);
                 break;
         case 'q':
-                less_exit(EXIT_SUCCESS);
+                less_exit();
                 break;
         case 'x':
                 change_file(0);
@@ -1795,7 +1798,7 @@ static void keypress_process(int keypress)
                 buffer_line(cur_fline);
                 break;
         case 'q': case 'Q':
-                less_exit(EXIT_SUCCESS);
+                less_exit();
                 break;
 #if ENABLE_FEATURE_LESS_MARKS
         case 'm':
@@ -1874,7 +1877,8 @@ static void keypress_process(int keypress)
 #if !ENABLE_PLATFORM_MINGW32
 static void sig_catcher(int sig)
 {
-        less_exit(- sig);
+        restore_tty();
+        kill_myself_with_sig(sig); /* does not return */
 }
 #endif
 
diff --git a/miscutils/watchdog.c b/miscutils/watchdog.c
index d8e9c78f5..9f5a4b849 100644
--- a/miscutils/watchdog.c
+++ b/miscutils/watchdog.c
@@ -76,7 +76,7 @@ static void shutdown_on_signal(int sig UNUSED_PARAM)
 {
         remove_pidfile_std_path_and_ext("watchdog");
         shutdown_watchdog();
-        _exit(EXIT_SUCCESS);
+        _exit_SUCCESS();
 }
 
 static void watchdog_open(const char* device)