aboutsummaryrefslogtreecommitdiff
path: root/networking/udhcp/d6_dhcpc.c
diff options
context:
space:
mode:
Diffstat (limited to 'networking/udhcp/d6_dhcpc.c')
-rw-r--r--networking/udhcp/d6_dhcpc.c26
1 files changed, 12 insertions, 14 deletions
diff --git a/networking/udhcp/d6_dhcpc.c b/networking/udhcp/d6_dhcpc.c
index 64339c9b5..067d35115 100644
--- a/networking/udhcp/d6_dhcpc.c
+++ b/networking/udhcp/d6_dhcpc.c
@@ -935,9 +935,7 @@ int udhcpc6_main(int argc UNUSED_PARAM, char **argv)
935 int timeout; /* must be signed */ 935 int timeout; /* must be signed */
936 unsigned already_waited_sec; 936 unsigned already_waited_sec;
937 unsigned opt; 937 unsigned opt;
938 int max_fd;
939 int retval; 938 int retval;
940 fd_set rfds;
941 939
942 setup_common_bufsiz(); 940 setup_common_bufsiz();
943 941
@@ -1063,7 +1061,8 @@ int udhcpc6_main(int argc UNUSED_PARAM, char **argv)
1063 * "continue" statements in code below jump to the top of the loop. 1061 * "continue" statements in code below jump to the top of the loop.
1064 */ 1062 */
1065 for (;;) { 1063 for (;;) {
1066 struct timeval tv; 1064 int tv;
1065 struct pollfd pfds[2];
1067 struct d6_packet packet; 1066 struct d6_packet packet;
1068 uint8_t *packet_end; 1067 uint8_t *packet_end;
1069 /* silence "uninitialized!" warning */ 1068 /* silence "uninitialized!" warning */
@@ -1078,16 +1077,15 @@ int udhcpc6_main(int argc UNUSED_PARAM, char **argv)
1078 * to change_listen_mode(). Thus we open listen socket 1077 * to change_listen_mode(). Thus we open listen socket
1079 * BEFORE we send renew request (see "case BOUND:"). */ 1078 * BEFORE we send renew request (see "case BOUND:"). */
1080 1079
1081 max_fd = udhcp_sp_fd_set(&rfds, sockfd); 1080 udhcp_sp_fd_set(pfds, sockfd);
1082 1081
1083 tv.tv_sec = timeout - already_waited_sec; 1082 tv = timeout - already_waited_sec;
1084 tv.tv_usec = 0;
1085 retval = 0; 1083 retval = 0;
1086 /* If we already timed out, fall through with retval = 0, else... */ 1084 /* If we already timed out, fall through with retval = 0, else... */
1087 if ((int)tv.tv_sec > 0) { 1085 if (tv > 0) {
1088 log1("waiting on select %u seconds", (int)tv.tv_sec); 1086 log1("waiting on select %u seconds", tv);
1089 timestamp_before_wait = (unsigned)monotonic_sec(); 1087 timestamp_before_wait = (unsigned)monotonic_sec();
1090 retval = select(max_fd + 1, &rfds, NULL, NULL, &tv); 1088 retval = poll(pfds, 2, tv * 1000);
1091 if (retval < 0) { 1089 if (retval < 0) {
1092 /* EINTR? A signal was caught, don't panic */ 1090 /* EINTR? A signal was caught, don't panic */
1093 if (errno == EINTR) { 1091 if (errno == EINTR) {
@@ -1222,8 +1220,8 @@ int udhcpc6_main(int argc UNUSED_PARAM, char **argv)
1222 /* select() didn't timeout, something happened */ 1220 /* select() didn't timeout, something happened */
1223 1221
1224 /* Is it a signal? */ 1222 /* Is it a signal? */
1225 /* note: udhcp_sp_read checks FD_ISSET before reading */ 1223 /* note: udhcp_sp_read checks poll result before reading */
1226 switch (udhcp_sp_read(&rfds)) { 1224 switch (udhcp_sp_read(pfds)) {
1227 case SIGUSR1: 1225 case SIGUSR1:
1228 client_config.first_secs = 0; /* make secs field count from 0 */ 1226 client_config.first_secs = 0; /* make secs field count from 0 */
1229 already_waited_sec = 0; 1227 already_waited_sec = 0;
@@ -1258,7 +1256,7 @@ int udhcpc6_main(int argc UNUSED_PARAM, char **argv)
1258 } 1256 }
1259 1257
1260 /* Is it a packet? */ 1258 /* Is it a packet? */
1261 if (listen_mode == LISTEN_NONE || !FD_ISSET(sockfd, &rfds)) 1259 if (listen_mode == LISTEN_NONE || !pfds[1].revents)
1262 continue; /* no */ 1260 continue; /* no */
1263 1261
1264 { 1262 {
@@ -1460,8 +1458,8 @@ int udhcpc6_main(int argc UNUSED_PARAM, char **argv)
1460 if (lease_seconds < 0x10) 1458 if (lease_seconds < 0x10)
1461 lease_seconds = 0x10; 1459 lease_seconds = 0x10;
1462/// TODO: check for 0 lease time? 1460/// TODO: check for 0 lease time?
1463 if (lease_seconds >= 0x10000000) 1461 if (lease_seconds > 0x7fffffff / 1000)
1464 lease_seconds = 0x0fffffff; 1462 lease_seconds = 0x7fffffff / 1000;
1465 /* enter bound state */ 1463 /* enter bound state */
1466 timeout = lease_seconds / 2; 1464 timeout = lease_seconds / 2;
1467 bb_error_msg("lease obtained, lease time %u", 1465 bb_error_msg("lease obtained, lease time %u",