5 files changed, 24 insertions, 21 deletions

diff --git a/procps/nmeter.c b/procps/nmeter.c
index ed5479024..6a3b32743 100644
--- a/procps/nmeter.c
+++ b/procps/nmeter.c
@@ -271,7 +271,7 @@ static int rdval_loadavg(const char* p, ullong *vec, ...)
 }
 
 // Parses /proc/diskstats
-//   1  2 3   4  5        6(rd)  7      8     9     10(wr) 11     12 13     14
+//   1  2 3   4     5     6(rd)  7      8     9     10(wr) 11     12 13     14
 //   3  0 hda 51292 14441 841783 926052 25717 79650 843256 3029804 0 148459 3956933
 //   3  1 hda1 0 0 0 0 <- ignore if only 4 fields
 // Linux 3.0 (maybe earlier) started printing full stats for hda1 too.
diff --git a/procps/powertop.c b/procps/powertop.c
index b4c45edbc..71988a295 100644
--- a/procps/powertop.c
+++ b/procps/powertop.c
@@ -493,7 +493,7 @@ static NOINLINE int process_timer_stats(void)
  * Get information about CPU using CPUID opcode.
  */
 static void cpuid(unsigned int *eax, unsigned int *ebx, unsigned int *ecx,
-                                  unsigned int *edx)
+                                unsigned int *edx)
 {
         /* EAX value specifies what information to return */
         __asm__(
@@ -650,7 +650,7 @@ static void show_timerstats(void)
         } else {
                 bb_putchar('\n');
                 bb_error_msg("no stats available; run as root or"
-                                " enable the cpufreq_stats module");
+                                " enable the timer_stats module");
         }
 }
 
diff --git a/procps/ps.c b/procps/ps.c
index e14356482..0dfda2039 100644
--- a/procps/ps.c
+++ b/procps/ps.c
@@ -70,7 +70,7 @@
 enum { MAX_WIDTH = 2*1024 };
 
 #if ENABLE_FEATURE_PS_TIME || ENABLE_FEATURE_PS_LONG
-static long get_uptime(void)
+static unsigned long get_uptime(void)
 {
 #ifdef __linux__
         struct sysinfo info;
@@ -78,12 +78,15 @@ static long get_uptime(void)
                 return 0;
         return info.uptime;
 #elif 1
-        char buf[64];
-        long uptime;
+        unsigned long uptime;
+        char buf[sizeof(uptime)*3 + 2];
+        /* /proc/uptime is "UPTIME_SEC.NN IDLE_SEC.NN\n"
+         * (where IDLE is cumulative over all CPUs)
+         */
         if (open_read_close("/proc/uptime", buf, sizeof(buf)) <= 0)
-                bb_perror_msg_and_die("can't read %s", "/proc/uptime");
+                bb_perror_msg_and_die("can't read '%s'", "/proc/uptime");
         buf[sizeof(buf)-1] = '\0';
-        sscanf(buf, "%l", &uptime);
+        sscanf(buf, "%lu", &uptime);
         return uptime;
 #else
         struct timespec ts;
@@ -138,7 +141,7 @@ struct globals {
         unsigned terminal_width;
 #if ENABLE_FEATURE_PS_TIME
         unsigned kernel_HZ;
-        unsigned long long seconds_since_boot;
+        unsigned long seconds_since_boot;
 #endif
 } FIX_ALIASING;
 #define G (*(struct globals*)&bb_common_bufsiz1)
@@ -149,14 +152,13 @@ struct globals {
 #define buffer             (G.buffer            )
 #define terminal_width     (G.terminal_width    )
 #define kernel_HZ          (G.kernel_HZ         )
-#define seconds_since_boot (G.seconds_since_boot)
 #define INIT_G() do { } while (0)
 
 #if ENABLE_FEATURE_PS_TIME
 /* for ELF executables, notes are pushed before environment and args */
-static ptrdiff_t find_elf_note(ptrdiff_t findme)
+static uintptr_t find_elf_note(uintptr_t findme)
 {
-        ptrdiff_t *ep = (ptrdiff_t *) environ;
+        uintptr_t *ep = (uintptr_t *) environ;
 
         while (*ep++)
                 continue;
@@ -222,7 +224,6 @@ static inline unsigned get_HZ_by_waiting(void)
 
 static unsigned get_kernel_HZ(void)
 {
-
         if (kernel_HZ)
                 return kernel_HZ;
 
@@ -231,7 +232,7 @@ static unsigned get_kernel_HZ(void)
         if (kernel_HZ == (unsigned)-1)
                 kernel_HZ = get_HZ_by_waiting();
 
-        seconds_since_boot = get_uptime();
+        G.seconds_since_boot = get_uptime();
 
         return kernel_HZ;
 }
@@ -350,7 +351,7 @@ static void func_etime(char *buf, int size, const procps_status_t *ps)
 
         mm = ps->start_time / get_kernel_HZ();
         /* must be after get_kernel_HZ()! */
-        mm = seconds_since_boot - mm;
+        mm = G.seconds_since_boot - mm;
         ss = mm % 60;
         mm /= 60;
         snprintf(buf, size+1, "%3lu:%02u", mm, ss);
@@ -598,7 +599,7 @@ int ps_main(int argc UNUSED_PARAM, char **argv)
         // -o col1,col2,col3=header
         //     Select which columns to display
         /* We allow (and ignore) most of the above. FIXME.
-         * -T is picked for threads (POSIX hasn't it standardized).
+         * -T is picked for threads (POSIX hasn't standardized it).
          * procps v3.2.7 supports -T and shows tids as SPID column,
          * it also supports -L where it shows tids as LWP column.
          */
@@ -609,7 +610,9 @@ int ps_main(int argc UNUSED_PARAM, char **argv)
                         parse_o(llist_pop(&opt_o));
                 } while (opt_o);
         } else {
-                /* Below: parse_o() needs char*, NOT const char*, can't give it default_o */
+                /* Below: parse_o() needs char*, NOT const char*,
+                 * can't pass it constant string. Need to make a copy first.
+                 */
 #if ENABLE_SELINUX
                 if (!(opt & OPT_Z) || !is_selinux_enabled()) {
                         /* no -Z or no SELinux: do not show LABEL */
@@ -663,7 +666,7 @@ int ps_main(int argc UNUSED_PARAM, char **argv UNUSED_PARAM)
         };
 #if ENABLE_FEATURE_PS_LONG
         time_t now = now;
-        long uptime;
+        unsigned long uptime;
 #endif
         /* If we support any options, parse argv */
 #if ENABLE_SELINUX || ENABLE_FEATURE_SHOW_THREADS || ENABLE_FEATURE_PS_WIDE || ENABLE_FEATURE_PS_LONG
diff --git a/procps/sysctl.c b/procps/sysctl.c
index 878656862..c6a1de21d 100644
--- a/procps/sysctl.c
+++ b/procps/sysctl.c
@@ -205,7 +205,7 @@ static int sysctl_act_recursive(const char *path)
                                 continue; /* d_name is "." or ".." */
                         /* if path was ".", drop "./" prefix: */
                         retval |= sysctl_act_recursive((next[0] == '.' && next[1] == '/') ?
-                                            next + 2 : next);
+                                        next + 2 : next);
                         free(next);
                 }
                 closedir(dirp);
diff --git a/procps/top.c b/procps/top.c
index b08444a76..abee69806 100644
--- a/procps/top.c
+++ b/procps/top.c
@@ -294,7 +294,7 @@ static void get_jiffy_counts(void)
          * they are used to calculate per process CPU% */
         prev_jif = cur_jif;
         if (read_cpu_jiffy(fp, &cur_jif) < 4)
-                bb_error_msg_and_die("can't read /proc/stat");
+                bb_error_msg_and_die("can't read '%s'", "/proc/stat");
 
 #if !ENABLE_FEATURE_TOP_SMP_CPU
         fclose(fp);
@@ -995,7 +995,7 @@ static unsigned handle_input(unsigned scan_mask, unsigned interval)
                 }
 # if ENABLE_FEATURE_SHOW_THREADS
                 if (c == 'h'
-                 IF_FEATURE_TOPMEM(&& scan_mask != TOPMEM_MASK)
+                IF_FEATURE_TOPMEM(&& scan_mask != TOPMEM_MASK)
                 ) {
                         scan_mask ^= PSSCAN_TASKS;
                         continue;