Fix gcc warning: ISO C forbids return between function pointer and void *

Instead of using compiler specific pragma to disable particular warning,
rewrite code which cast from function pointer to data pointer according to
POSIX dlopen() documentation. This also fix compile warning under MSVC.

  According to the ISO C standard, casting between function
  pointers and 'void *', as done above, produces undefined results.
  POSIX.1-2003 and POSIX.1-2008 accepted this state of affairs and
  proposed the following workaround:

      *(void **) (&cosine) = dlsym(handle, "cos");

  This (clumsy) cast conforms with the ISO C standard and will
  avoid any compiler warnings.

1 files changed, 1 insertions, 5 deletions

diff --git a/dlfcn.c b/dlfcn.c
index 1815ae0..f8af91f 100644
--- a/dlfcn.c
+++ b/dlfcn.c
@@ -454,11 +454,7 @@ end:
         save_err_str( name );

     }

 

-    //  warning C4054: 'type cast' : from function pointer 'FARPROC' to data pointer 'void *'

-#ifdef _MSC_VER

-#pragma warning( suppress: 4054 )

-#endif

-    return (void*) symbol;

+    return *(void **) (&symbol);

 }

 

 char *dlerror( void )