diff options
| author | Benoit Germain <benoit.germain@ubisoft.com> | 2024-11-13 10:47:24 +0100 |
|---|---|---|
| committer | Benoit Germain <benoit.germain@ubisoft.com> | 2024-11-13 10:47:24 +0100 |
| commit | f2a3c033fc31332e78aa45d2d9deaf51359b584a (patch) | |
| tree | b8e017488af194e1156f2209d9f7fd70ad56f0cb | |
| parent | 9e8930f02e7a53a41b713c642bcb53b3b61f7cb5 (diff) | |
| download | lanes-f2a3c033fc31332e78aa45d2d9deaf51359b584a.tar.gz lanes-f2a3c033fc31332e78aa45d2d9deaf51359b584a.tar.bz2 lanes-f2a3c033fc31332e78aa45d2d9deaf51359b584a.zip | |
Cleaning up guano
Lane::tracking_next and LaneTracker::trackingFirst do not need to be volatile or anything else, all accesses are mutex-protected
| -rw-r--r-- | src/lane.hpp | 4 | ||||
| -rw-r--r-- | src/tracker.hpp | 2 |
2 files changed, 3 insertions, 3 deletions
diff --git a/src/lane.hpp b/src/lane.hpp index 4f87e2a..eb51aa3 100644 --- a/src/lane.hpp +++ b/src/lane.hpp | |||
| @@ -135,8 +135,8 @@ class Lane | |||
| 135 | // is still running | 135 | // is still running |
| 136 | // S: cleans up after itself if non-nullptr at lane exit | 136 | // S: cleans up after itself if non-nullptr at lane exit |
| 137 | 137 | ||
| 138 | // For tracking only | 138 | // access is protected by LaneTracker::trackingMutex |
| 139 | Lane* volatile tracking_next{ nullptr }; | 139 | Lane* tracking_next{ nullptr }; |
| 140 | 140 | ||
| 141 | ErrorTraceLevel const errorTraceLevel{ Basic }; | 141 | ErrorTraceLevel const errorTraceLevel{ Basic }; |
| 142 | 142 | ||
diff --git a/src/tracker.hpp b/src/tracker.hpp index dcf3c6e..c1a38e2 100644 --- a/src/tracker.hpp +++ b/src/tracker.hpp | |||
| @@ -11,7 +11,7 @@ class LaneTracker | |||
| 11 | { | 11 | { |
| 12 | private: | 12 | private: |
| 13 | mutable std::mutex trackingMutex; | 13 | mutable std::mutex trackingMutex; |
| 14 | Lane* volatile trackingFirst{ nullptr }; // will change to TRACKING_END if we want to activate tracking | 14 | Lane* trackingFirst{ nullptr }; // will change to TRACKING_END if we want to activate tracking |
| 15 | 15 | ||
| 16 | public: | 16 | public: |
| 17 | void tracking_add(Lane* lane_); | 17 | void tracking_add(Lane* lane_); |