Cleaning up guano

* Lane::waiting on does not need to be volatile or anything else, all accesses are controlled through status acquire/release semantics
* this contains fixes about bad ordering of said accesses in Linda:send and Linda:receive

1 files changed, 2 insertions, 3 deletions

diff --git a/src/lane.hpp b/src/lane.hpp
index eb51aa3..b5be9ab 100644
--- a/src/lane.hpp
+++ b/src/lane.hpp
@@ -50,7 +50,6 @@ enum class WakeLane
     Yes
 };
 
-// NOTE: values to be changed by either thread, during execution, without locking, are marked "volatile"
 class Lane
 {
     public:
@@ -118,9 +117,9 @@ class Lane
     // M: sets to Pending (before launching)
     // S: updates -> Running/Waiting/Suspended -> Done/Error/Cancelled
 
-    std::condition_variable* volatile waiting_on{ nullptr };
-    //
+    // accessed under control of status acquire/release semantics
     // When status is Waiting, points on the linda's signal the thread waits on, else nullptr
+    std::condition_variable* waiting_on{ nullptr };
 
     std::atomic<CancelRequest> cancelRequest{ CancelRequest::None };
     static_assert(std::atomic<CancelRequest>::is_always_lock_free);