Some constitude tweaks

1 files changed, 12 insertions, 10 deletions

diff --git a/src/universe.hpp b/src/universe.hpp
index dbf0ece..d35172d 100644
--- a/src/universe.hpp
+++ b/src/universe.hpp
@@ -26,7 +26,7 @@ class ProtectedAllocator
     std::mutex mutex;
 
     [[nodiscard]]
-    static void* protected_lua_Alloc(void* ud_, void* ptr_, size_t osize_, size_t nsize_)
+    static void* protected_lua_Alloc(void* const ud_, void* const ptr_, size_t const osize_, size_t const nsize_)
     {
         ProtectedAllocator* const allocator{ static_cast<ProtectedAllocator*>(ud_) };
         std::lock_guard<std::mutex> guard{ allocator->mutex };
@@ -36,8 +36,8 @@ class ProtectedAllocator
     public:
     // we are not like our base class: we can't be created inside a full userdata (or we would have to install a metatable and __gc handler to destroy ourselves properly)
     [[nodiscard]]
-    static void* operator new(size_t size_, lua_State* L_) noexcept = delete;
-    static void operator delete(void* p_, lua_State* L_) = delete;
+    static void* operator new(size_t const size_, lua_State* const L_) noexcept = delete;
+    static void operator delete(void* const p_, lua_State* const L_) = delete;
 
     AllocatorDefinition makeDefinition()
     {
@@ -58,6 +58,7 @@ class ProtectedAllocator
 };
 
 // #################################################################################################
+// #################################################################################################
 
 // xxh64 of string "kUniverseLightRegKey" generated at https://www.pelock.com/products/hash-calculator
 static constexpr RegistryUniqueKey kUniverseLightRegKey{ 0x48BBE9CEAB0BA04Full };
@@ -127,9 +128,9 @@ class Universe
 
     public:
     [[nodiscard]]
-    static void* operator new([[maybe_unused]] size_t size_, lua_State* L_) noexcept { return luaG_newuserdatauv<Universe>(L_, UserValueCount{ 0 }); };
+    static void* operator new([[maybe_unused]] size_t const size_, lua_State* const L_) noexcept { return luaG_newuserdatauv<Universe>(L_, UserValueCount{ 0 }); };
     // can't actually delete the operator because the compiler generates stack unwinding code that could call it in case of exception
-    static void operator delete([[maybe_unused]] void* p_, [[maybe_unused]] lua_State* L_) {} // nothing to do, as nothing is allocated independently
+    static void operator delete([[maybe_unused]] void* const p_, [[maybe_unused]] lua_State* const L_) {} // nothing to do, as nothing is allocated independently
 
     Universe();
     ~Universe() = default;
@@ -139,15 +140,16 @@ class Universe
     Universe& operator=(Universe const&) = delete;
     Universe& operator=(Universe&&) = delete;
 
-    void callOnStateCreate(lua_State* const L_, lua_State* const from_, LookupMode const mode_);
+    void callOnStateCreate(lua_State* L_, lua_State* from_, LookupMode mode_);
     [[nodiscard]]
     static Universe* Create(lua_State* L_);
     [[nodiscard]]
     static inline Universe* Get(lua_State* L_);
     void initializeAllocatorFunction(lua_State* L_);
     static int InitializeFinalizer(lua_State* L_);
-    void initializeOnStateCreate(lua_State* const L_);
-    lanes::AllocatorDefinition resolveAllocator(lua_State* const L_, std::string_view const& hint_) const;
+    void initializeOnStateCreate(lua_State* L_);
+    [[nodiscard]]
+    lanes::AllocatorDefinition resolveAllocator(lua_State* L_, std::string_view const& hint_) const;
     static inline void Store(lua_State* L_, Universe* U_);
     [[nodiscard]]
     bool terminateFreeRunningLanes(lua_Duration shutdownTimeout_, CancelOp op_);
@@ -156,7 +158,7 @@ class Universe
 // #################################################################################################
 
 [[nodiscard]]
-inline Universe* Universe::Get(lua_State* L_)
+inline Universe* Universe::Get(lua_State* const L_)
 {
     STACK_CHECK_START_REL(L_, 0);
     Universe* const _universe{ kUniverseLightRegKey.readLightUserDataValue<Universe>(L_) };
@@ -166,7 +168,7 @@ inline Universe* Universe::Get(lua_State* L_)
 
 // #################################################################################################
 
-inline void Universe::Store(lua_State* L_, Universe* U_)
+inline void Universe::Store(lua_State* const L_, Universe* const U_)
 {
     // TODO: check if we actually ever call Store with a null universe
     LUA_ASSERT(L_, !U_ || Universe::Get(L_) == nullptr);