diff options
| author | Mark Pulford <mark@kyne.com.au> | 2012-01-19 23:36:16 +1030 |
|---|---|---|
| committer | Mark Pulford <mark@kyne.com.au> | 2012-03-04 18:54:35 +1030 |
| commit | 31bf122c1d1d9e3812b9ef2555d537f509ae3f05 (patch) | |
| tree | b382fa3fecb784598ff8b0c64c1360c3bc24db2a | |
| parent | a0961903e3ff846a2bde6faa6d390435cd9937ef (diff) | |
| download | lua-cjson-31bf122c1d1d9e3812b9ef2555d537f509ae3f05.tar.gz lua-cjson-31bf122c1d1d9e3812b9ef2555d537f509ae3f05.tar.bz2 lua-cjson-31bf122c1d1d9e3812b9ef2555d537f509ae3f05.zip | |
Simplify string.format() calls
Simply string.format() calls with OO method notation.
| -rw-r--r-- | lua/cjson/util.lua | 19 | ||||
| -rwxr-xr-x | tests/bench.lua | 4 | ||||
| -rwxr-xr-x | tests/test.lua | 6 |
3 files changed, 14 insertions, 15 deletions
diff --git a/lua/cjson/util.lua b/lua/cjson/util.lua index 5b1eba0..79245b5 100644 --- a/lua/cjson/util.lua +++ b/lua/cjson/util.lua | |||
| @@ -63,10 +63,9 @@ local function serialise_table(value, indent, depth) | |||
| 63 | if comma then | 63 | if comma then |
| 64 | table.insert(fragment, "," .. spacing2) | 64 | table.insert(fragment, "," .. spacing2) |
| 65 | end | 65 | end |
| 66 | table.insert(fragment, string.format( | 66 | table.insert(fragment, |
| 67 | "[%s] = %s", serialise_value(k, indent2, depth), | 67 | ("[%s] = %s"):format(serialise_value(k, indent2, depth), |
| 68 | serialise_value(v, indent2, depth)) | 68 | serialise_value(v, indent2, depth))) |
| 69 | ) | ||
| 70 | comma = true | 69 | comma = true |
| 71 | end | 70 | end |
| 72 | end | 71 | end |
| @@ -82,7 +81,7 @@ function serialise_value(value, indent, depth) | |||
| 82 | if value == json.null then | 81 | if value == json.null then |
| 83 | return "json.null" | 82 | return "json.null" |
| 84 | elseif type(value) == "string" then | 83 | elseif type(value) == "string" then |
| 85 | return string.format("%q", value) | 84 | return ("%q"):format(value) |
| 86 | elseif type(value) == "nil" or type(value) == "number" or | 85 | elseif type(value) == "nil" or type(value) == "number" or |
| 87 | type(value) == "boolean" then | 86 | type(value) == "boolean" then |
| 88 | return tostring(value) | 87 | return tostring(value) |
| @@ -101,7 +100,7 @@ local function file_load(filename) | |||
| 101 | local err | 100 | local err |
| 102 | file, err = io.open(filename) | 101 | file, err = io.open(filename) |
| 103 | if file == nil then | 102 | if file == nil then |
| 104 | error(string.format("Unable to read '%s': %s", filename, err)) | 103 | error(("Unable to read '%s': %s"):format(filename, err)) |
| 105 | end | 104 | end |
| 106 | end | 105 | end |
| 107 | local data = file:read("*a") | 106 | local data = file:read("*a") |
| @@ -125,7 +124,7 @@ local function file_save(filename, data) | |||
| 125 | local err | 124 | local err |
| 126 | file, err = io.open(filename, "w") | 125 | file, err = io.open(filename, "w") |
| 127 | if file == nil then | 126 | if file == nil then |
| 128 | error(string.format("Unable to write '%s': %s", filename, err)) | 127 | error(("Unable to write '%s': %s"):format(filename, err)) |
| 129 | end | 128 | end |
| 130 | end | 129 | end |
| 131 | file:write(data) | 130 | file:write(data) |
| @@ -187,7 +186,7 @@ local function run_test(testname, func, input, should_work, output) | |||
| 187 | if status ~= nil then | 186 | if status ~= nil then |
| 188 | name = name .. statusmap[status] | 187 | name = name .. statusmap[status] |
| 189 | end | 188 | end |
| 190 | print(string.format("[%s] %s", name, serialise_value(value, false))) | 189 | print(("[%s] %s"):format(name, serialise_value(value, false))) |
| 191 | end | 190 | end |
| 192 | 191 | ||
| 193 | local result = { pcall(func, unpack(input)) } | 192 | local result = { pcall(func, unpack(input)) } |
| @@ -201,8 +200,8 @@ local function run_test(testname, func, input, should_work, output) | |||
| 201 | test_count_total = test_count_total + 1 | 200 | test_count_total = test_count_total + 1 |
| 202 | 201 | ||
| 203 | local teststatus = { [true] = "PASS", [false] = "FAIL" } | 202 | local teststatus = { [true] = "PASS", [false] = "FAIL" } |
| 204 | print(string.format("==> Test [%d] %s: %s", | 203 | print(("==> Test [%d] %s: %s"):format(test_count_total, testname, |
| 205 | test_count_total, testname, teststatus[correct])) | 204 | teststatus[correct])) |
| 206 | 205 | ||
| 207 | status_line("Input", nil, input) | 206 | status_line("Input", nil, input) |
| 208 | if not correct then | 207 | if not correct then |
diff --git a/tests/bench.lua b/tests/bench.lua index cae4902..648020b 100755 --- a/tests/bench.lua +++ b/tests/bench.lua | |||
| @@ -115,7 +115,7 @@ function bench_file(filename) | |||
| 115 | end | 115 | end |
| 116 | 116 | ||
| 117 | -- Optionally load any custom configuration required for this module | 117 | -- Optionally load any custom configuration required for this module |
| 118 | local success, data = pcall(util.file_load, string.format("bench-%s.lua", json_module)) | 118 | local success, data = pcall(util.file_load, ("bench-%s.lua"):format(json_module)) |
| 119 | if success then | 119 | if success then |
| 120 | util.run_script(data, _G) | 120 | util.run_script(data, _G) |
| 121 | configure(json) | 121 | configure(json) |
| @@ -124,7 +124,7 @@ end | |||
| 124 | for i = 1, #arg do | 124 | for i = 1, #arg do |
| 125 | local results = bench_file(arg[i]) | 125 | local results = bench_file(arg[i]) |
| 126 | for k, v in pairs(results) do | 126 | for k, v in pairs(results) do |
| 127 | print(string.format("%s\t%s\t%d", arg[i], k, v)) | 127 | print(("%s\t%s\t%d"):format(arg[i], k, v)) |
| 128 | end | 128 | end |
| 129 | end | 129 | end |
| 130 | 130 | ||
diff --git a/tests/test.lua b/tests/test.lua index e0f99f6..8c50b02 100755 --- a/tests/test.lua +++ b/tests/test.lua | |||
| @@ -22,7 +22,7 @@ local function gen_utf16_escaped() | |||
| 22 | local count = 0 | 22 | local count = 0 |
| 23 | 23 | ||
| 24 | local function append_escape(code) | 24 | local function append_escape(code) |
| 25 | local esc = string.format('\\u%04X', code) | 25 | local esc = ('\\u%04X'):format(code) |
| 26 | table.insert(utf16_escaped, esc) | 26 | table.insert(utf16_escaped, esc) |
| 27 | end | 27 | end |
| 28 | 28 | ||
| @@ -388,7 +388,7 @@ local cjson_tests = { | |||
| 388 | true, { false, 2, 10 } }, | 388 | true, { false, 2, 10 } }, |
| 389 | } | 389 | } |
| 390 | 390 | ||
| 391 | print(string.format("==> Testing Lua CJSON version %s\n", json._VERSION)) | 391 | print(("==> Testing Lua CJSON version %s\n"):format(json._VERSION)) |
| 392 | 392 | ||
| 393 | util.run_test_group(cjson_tests) | 393 | util.run_test_group(cjson_tests) |
| 394 | 394 | ||
| @@ -402,7 +402,7 @@ local pass, total = util.run_test_summary() | |||
| 402 | if pass == total then | 402 | if pass == total then |
| 403 | print("==> Summary: all tests succeeded") | 403 | print("==> Summary: all tests succeeded") |
| 404 | else | 404 | else |
| 405 | print(string.format("==> Summary: %d/%d tests failed", total - pass, total)) | 405 | print(("==> Summary: %d/%d tests failed"):format(total - pass, total)) |
| 406 | os.exit(1) | 406 | os.exit(1) |
| 407 | end | 407 | end |
| 408 | 408 | ||
