diff options
author | Roberto Ierusalimschy <roberto@inf.puc-rio.br> | 2017-12-15 11:07:10 -0200 |
---|---|---|
committer | Roberto Ierusalimschy <roberto@inf.puc-rio.br> | 2017-12-15 11:07:10 -0200 |
commit | b3f924bc695ed6ebe2539d365197696e41863a91 (patch) | |
tree | bf756351d06bdfc469846e533699c9ce58bc3566 | |
parent | e001d5aea693ca1bcf1a4dfd2f900737fc0a8604 (diff) | |
download | lua-b3f924bc695ed6ebe2539d365197696e41863a91.tar.gz lua-b3f924bc695ed6ebe2539d365197696e41863a91.tar.bz2 lua-b3f924bc695ed6ebe2539d365197696e41863a91.zip |
'Proto->numparams' does not include vararg parameter
(one less subtraction when calling functions...)
-rw-r--r-- | ldebug.c | 4 | ||||
-rw-r--r-- | ldo.c | 6 | ||||
-rw-r--r-- | lparser.c | 9 | ||||
-rw-r--r-- | ltm.c | 4 |
4 files changed, 11 insertions, 12 deletions
@@ -1,5 +1,5 @@ | |||
1 | /* | 1 | /* |
2 | ** $Id: ldebug.c,v 2.147 2017/12/07 15:44:10 roberto Exp roberto $ | 2 | ** $Id: ldebug.c,v 2.148 2017/12/13 18:32:09 roberto Exp roberto $ |
3 | ** Debug Interface | 3 | ** Debug Interface |
4 | ** See Copyright Notice in lua.h | 4 | ** See Copyright Notice in lua.h |
5 | */ | 5 | */ |
@@ -328,7 +328,7 @@ static int auxgetinfo (lua_State *L, const char *what, lua_Debug *ar, | |||
328 | } | 328 | } |
329 | else { | 329 | else { |
330 | ar->isvararg = f->l.p->is_vararg; | 330 | ar->isvararg = f->l.p->is_vararg; |
331 | ar->nparams = f->l.p->numparams; | 331 | ar->nparams = f->l.p->numparams + f->l.p->is_vararg; |
332 | } | 332 | } |
333 | break; | 333 | break; |
334 | } | 334 | } |
@@ -1,5 +1,5 @@ | |||
1 | /* | 1 | /* |
2 | ** $Id: ldo.c,v 2.179 2017/12/11 12:43:40 roberto Exp roberto $ | 2 | ** $Id: ldo.c,v 2.180 2017/12/12 11:57:30 roberto Exp roberto $ |
3 | ** Stack and Call structure of Lua | 3 | ** Stack and Call structure of Lua |
4 | ** See Copyright Notice in lua.h | 4 | ** See Copyright Notice in lua.h |
5 | */ | 5 | */ |
@@ -415,7 +415,7 @@ void luaD_pretailcall (lua_State *L, CallInfo *ci, StkId func, int n) { | |||
415 | for (i = 0; i < n; i++) /* move down function and arguments */ | 415 | for (i = 0; i < n; i++) /* move down function and arguments */ |
416 | setobjs2s(L, ci->func + i, func + i); | 416 | setobjs2s(L, ci->func + i, func + i); |
417 | checkstackp(L, fsize, func); | 417 | checkstackp(L, fsize, func); |
418 | for (; i < p->numparams - p->is_vararg; i++) | 418 | for (; i < p->numparams; i++) |
419 | setnilvalue(s2v(ci->func + i)); /* complete missing parameters */ | 419 | setnilvalue(s2v(ci->func + i)); /* complete missing parameters */ |
420 | if (p->is_vararg) { | 420 | if (p->is_vararg) { |
421 | L->top -= (func - ci->func); /* move down top */ | 421 | L->top -= (func - ci->func); /* move down top */ |
@@ -469,7 +469,7 @@ void luaD_call (lua_State *L, StkId func, int nresults) { | |||
469 | int n = cast_int(L->top - func) - 1; /* number of real arguments */ | 469 | int n = cast_int(L->top - func) - 1; /* number of real arguments */ |
470 | int fsize = p->maxstacksize; /* frame size */ | 470 | int fsize = p->maxstacksize; /* frame size */ |
471 | checkstackp(L, fsize, func); | 471 | checkstackp(L, fsize, func); |
472 | for (; n < p->numparams - p->is_vararg; n++) | 472 | for (; n < p->numparams; n++) |
473 | setnilvalue(s2v(L->top++)); /* complete missing arguments */ | 473 | setnilvalue(s2v(L->top++)); /* complete missing arguments */ |
474 | if (p->is_vararg) | 474 | if (p->is_vararg) |
475 | luaT_adjustvarargs(L, p, n); | 475 | luaT_adjustvarargs(L, p, n); |
@@ -1,5 +1,5 @@ | |||
1 | /* | 1 | /* |
2 | ** $Id: lparser.c,v 2.170 2017/12/06 18:36:31 roberto Exp roberto $ | 2 | ** $Id: lparser.c,v 2.171 2017/12/14 14:24:02 roberto Exp roberto $ |
3 | ** Lua Parser | 3 | ** Lua Parser |
4 | ** See Copyright Notice in lua.h | 4 | ** See Copyright Notice in lua.h |
5 | */ | 5 | */ |
@@ -765,7 +765,6 @@ static void parlist (LexState *ls) { | |||
765 | FuncState *fs = ls->fs; | 765 | FuncState *fs = ls->fs; |
766 | Proto *f = fs->f; | 766 | Proto *f = fs->f; |
767 | int nparams = 0; | 767 | int nparams = 0; |
768 | f->is_vararg = 0; | ||
769 | if (ls->t.token != ')') { /* is 'parlist' not empty? */ | 768 | if (ls->t.token != ')') { /* is 'parlist' not empty? */ |
770 | do { | 769 | do { |
771 | switch (ls->t.token) { | 770 | switch (ls->t.token) { |
@@ -789,7 +788,7 @@ static void parlist (LexState *ls) { | |||
789 | } while (!f->is_vararg && testnext(ls, ',')); | 788 | } while (!f->is_vararg && testnext(ls, ',')); |
790 | } | 789 | } |
791 | adjustlocalvars(ls, nparams); | 790 | adjustlocalvars(ls, nparams); |
792 | f->numparams = cast_byte(fs->nactvar); | 791 | f->numparams = cast_byte(fs->nactvar) - f->is_vararg; |
793 | luaK_reserveregs(fs, fs->nactvar); /* reserve register for parameters */ | 792 | luaK_reserveregs(fs, fs->nactvar); /* reserve register for parameters */ |
794 | } | 793 | } |
795 | 794 | ||
@@ -975,7 +974,7 @@ static void simpleexp (LexState *ls, expdesc *v) { | |||
975 | } | 974 | } |
976 | case TK_DOTS: { /* vararg */ | 975 | case TK_DOTS: { /* vararg */ |
977 | FuncState *fs = ls->fs; | 976 | FuncState *fs = ls->fs; |
978 | int lastparam = fs->f->numparams - 1; | 977 | int lastparam = fs->f->numparams; |
979 | check_condition(ls, fs->f->is_vararg, | 978 | check_condition(ls, fs->f->is_vararg, |
980 | "cannot use '...' outside a vararg function"); | 979 | "cannot use '...' outside a vararg function"); |
981 | init_exp(v, VVARARG, luaK_codeABC(fs, OP_VARARG, 0, 1, lastparam)); | 980 | init_exp(v, VVARARG, luaK_codeABC(fs, OP_VARARG, 0, 1, lastparam)); |
@@ -1676,7 +1675,7 @@ static void mainfunc (LexState *ls, FuncState *fs) { | |||
1676 | expdesc v; | 1675 | expdesc v; |
1677 | open_func(ls, fs, &bl); | 1676 | open_func(ls, fs, &bl); |
1678 | fs->f->is_vararg = 1; /* main function is always declared vararg */ | 1677 | fs->f->is_vararg = 1; /* main function is always declared vararg */ |
1679 | fs->f->numparams = 1; | 1678 | fs->f->numparams = 0; |
1680 | new_localvarliteral(ls, "_ARG"); | 1679 | new_localvarliteral(ls, "_ARG"); |
1681 | adjustlocalvars(ls, 1); | 1680 | adjustlocalvars(ls, 1); |
1682 | luaK_reserveregs(fs, 1); /* reserve register for vararg */ | 1681 | luaK_reserveregs(fs, 1); /* reserve register for vararg */ |
@@ -1,5 +1,5 @@ | |||
1 | /* | 1 | /* |
2 | ** $Id: ltm.c,v 2.51 2017/11/30 15:37:16 roberto Exp roberto $ | 2 | ** $Id: ltm.c,v 2.52 2017/12/13 18:32:09 roberto Exp roberto $ |
3 | ** Tag methods | 3 | ** Tag methods |
4 | ** See Copyright Notice in lua.h | 4 | ** See Copyright Notice in lua.h |
5 | */ | 5 | */ |
@@ -219,7 +219,7 @@ void luaT_adjustvarargs (lua_State *L, Proto *p, int actual) { | |||
219 | int i; | 219 | int i; |
220 | Table *vtab; | 220 | Table *vtab; |
221 | TValue nname; | 221 | TValue nname; |
222 | int nfixparams = p->numparams - 1; /* number of fixed parameters */ | 222 | int nfixparams = p->numparams; /* number of fixed parameters */ |
223 | actual -= nfixparams; /* number of extra arguments */ | 223 | actual -= nfixparams; /* number of extra arguments */ |
224 | vtab = luaH_new(L); /* create vararg table */ | 224 | vtab = luaH_new(L); /* create vararg table */ |
225 | sethvalue2s(L, L->top, vtab); /* anchor it for resizing */ | 225 | sethvalue2s(L, L->top, vtab); /* anchor it for resizing */ |