diff options
author | Mike Pall <mike> | 2019-12-08 19:47:00 +0100 |
---|---|---|
committer | Mike Pall <mike> | 2019-12-08 19:47:00 +0100 |
commit | de48d000941f58a8d4d816e9d227de8a4f3c9de6 (patch) | |
tree | b038ad8fff48d7e161d48093bd667ee10dfa652b | |
parent | 324aef08d9b178aa0640fb8ae5ac0a361ec72716 (diff) | |
download | luajit-de48d000941f58a8d4d816e9d227de8a4f3c9de6.tar.gz luajit-de48d000941f58a8d4d816e9d227de8a4f3c9de6.tar.bz2 luajit-de48d000941f58a8d4d816e9d227de8a4f3c9de6.zip |
Fix hash table chaining (again).
Thanks to Peter Cawley.
-rw-r--r-- | src/lj_tab.c | 9 |
1 files changed, 4 insertions, 5 deletions
diff --git a/src/lj_tab.c b/src/lj_tab.c index f2f3c0b0..2ff5eb0d 100644 --- a/src/lj_tab.c +++ b/src/lj_tab.c | |||
@@ -452,8 +452,7 @@ TValue *lj_tab_newkey(lua_State *L, GCtab *t, cTValue *key) | |||
452 | /* Rechain pseudo-resurrected string keys with colliding hashes. */ | 452 | /* Rechain pseudo-resurrected string keys with colliding hashes. */ |
453 | while (nextnode(freenode)) { | 453 | while (nextnode(freenode)) { |
454 | Node *nn = nextnode(freenode); | 454 | Node *nn = nextnode(freenode); |
455 | if (tvisstr(&nn->key) && !tvisnil(&nn->val) && | 455 | if (!tvisnil(&nn->val) && hashkey(t, &nn->key) == n) { |
456 | hashstr(t, strV(&nn->key)) == n) { | ||
457 | freenode->next = nn->next; | 456 | freenode->next = nn->next; |
458 | nn->next = n->next; | 457 | nn->next = n->next; |
459 | setmref(n->next, nn); | 458 | setmref(n->next, nn); |
@@ -466,9 +465,9 @@ TValue *lj_tab_newkey(lua_State *L, GCtab *t, cTValue *key) | |||
466 | ** any string key that's currently in a non-main positions. | 465 | ** any string key that's currently in a non-main positions. |
467 | */ | 466 | */ |
468 | while ((nn = nextnode(freenode))) { | 467 | while ((nn = nextnode(freenode))) { |
469 | if (tvisstr(&nn->key) && !tvisnil(&nn->val)) { | 468 | if (!tvisnil(&nn->val)) { |
470 | Node *mn = hashstr(t, strV(&nn->key)); | 469 | Node *mn = hashkey(t, &nn->key); |
471 | if (mn != freenode) { | 470 | if (mn != freenode && mn != nn) { |
472 | freenode->next = nn->next; | 471 | freenode->next = nn->next; |
473 | nn->next = mn->next; | 472 | nn->next = mn->next; |
474 | setmref(mn->next, nn); | 473 | setmref(mn->next, nn); |