Add support for namespaces.

For details of the new feature, see
https://github.com/luarocks/luarocks/wiki/Namespaces

This ended up being a huge commit because of some major refactoring
motivated by the new feature:

* new modules for some object types:
  * `luarocks.queries` - all functions that look for rocks in local or
    remote repositories now use objects constructed by this module:
    query objects contain the name, namespace and query constraints.
    Dependencies in a rockspec are also stored as query objects.
  * `luarocks.results` - all individual results produces from queries
    are returned in this format: result objects contain the name,
    namespace, version, arch and repo.
* the `results` object was renamed to `result_tree`, to better
  reflect that it is not an array of `result` objects.
* `luarocks.vers` was removed, its functionality was moved to better locations.

Specifically on namespaces:

* Commands that take a rock `name` can now take `namespace/name`
  (and alternately `--flags=namespace` so that URLs can be
  also installed with a nominal namespace).
* Rocks installed from a namespace now create a `rock_namespace`
  file alongside `rock_manifest`, which is used when matching
  namespaced dependencies against locally-installed rocks.
* Using namespaced dependencies in a rockspec, requires
  `rockspec_format = "3.0"`.
* Tests under the `#namespaces` hashtag, all using a local repository.

15 files changed, 242 insertions, 37 deletions

diff --git a/spec/build_spec.lua b/spec/build_spec.lua
index 2de05879..ed36dbd2 100644
--- a/spec/build_spec.lua
+++ b/spec/build_spec.lua
@@ -62,6 +62,7 @@ describe("LuaRocks build tests #blackbox #b_build", function()
       end)
       
       it("LuaRocks build lpeg branch=master", function()
+         -- FIXME should use dev package
          assert.is_true(run.luarocks_bool("build --branch=master lpeg"))
          assert.is.truthy(lfs.attributes(testing_paths.testing_sys_rocks .. "/lpeg/1.0.0-1/lpeg-1.0.0-1.rockspec"))
       end)
@@ -137,6 +138,40 @@ describe("LuaRocks build tests #blackbox #b_build", function()
       end)
    end)
 
+   describe("#namespaces", function()
+      it("builds a namespaced package from the command-line", function()
+         assert(run.luarocks_bool("build a_user/a_rock --server=" .. testing_paths.fixtures_dir .. "/a_repo" ))
+         assert.is_false(run.luarocks_bool("show a_rock 1.0"))
+         assert(run.luarocks_bool("show a_rock 2.0"))
+         assert(lfs.attributes(testing_paths.testing_sys_rocks .. "/a_rock/2.0-1/rock_namespace"))
+      end)
+
+      it("builds a package with a namespaced dependency", function()
+         assert(run.luarocks_bool("build has_namespaced_dep --server=" .. testing_paths.fixtures_dir .. "/a_repo" ))
+         assert(run.luarocks_bool("show has_namespaced_dep"))
+         assert.is_false(run.luarocks_bool("show a_rock 1.0"))
+         assert(run.luarocks_bool("show a_rock 2.0"))
+      end)
+
+      it("builds a package reusing a namespaced dependency", function()
+         assert(run.luarocks_bool("build a_user/a_rock --server=" .. testing_paths.fixtures_dir .. "/a_repo" ))
+         assert(run.luarocks_bool("show a_rock 2.0"))
+         assert(lfs.attributes(testing_paths.testing_sys_rocks .. "/a_rock/2.0-1/rock_namespace"))
+         local output = run.luarocks("build has_namespaced_dep --server=" .. testing_paths.fixtures_dir .. "/a_repo" )
+         assert.has.no.match("Missing dependencies", output)
+      end)
+
+      it("builds a package considering namespace of locally installed package", function()
+         assert(run.luarocks_bool("build a_user/a_rock --server=" .. testing_paths.fixtures_dir .. "/a_repo" ))
+         assert(run.luarocks_bool("show a_rock 2.0"))
+         assert(lfs.attributes(testing_paths.testing_sys_rocks .. "/a_rock/2.0-1/rock_namespace"))
+         local output = run.luarocks("build has_another_namespaced_dep --server=" .. testing_paths.fixtures_dir .. "/a_repo" )
+         assert.has.match("Missing dependencies", output)
+         print(output)
+         assert(run.luarocks_bool("show a_rock 3.0"))
+      end)
+   end)
+
    describe("LuaRocks build - more complex tests", function()
       if test_env.TYPE_TEST_ENV == "full" then
          it("LuaRocks build luacheck show downloads test_config", function()
diff --git a/spec/doc_spec.lua b/spec/doc_spec.lua
index 5f503af2..6d91fc00 100644
--- a/spec/doc_spec.lua
+++ b/spec/doc_spec.lua
@@ -38,6 +38,14 @@ describe("LuaRocks doc tests #blackbox #b_doc", function()
          assert.is.truthy(output:find("Local documentation directory not found"))
       end)
    end)
+
+   describe("#namespaces", function()
+      it("retrieves docs for a namespaced package from the command-line", function()
+         assert(run.luarocks_bool("build a_user/a_rock --server=" .. testing_paths.fixtures_dir .. "/a_repo" ))
+         assert(run.luarocks_bool("build a_rock --keep --server=" .. testing_paths.fixtures_dir .. "/a_repo" ))
+         assert.match("a_rock 2.0", run.luarocks("doc a_user/a_rock"))
+      end)
+   end)
    
    describe("LuaRocks doc tests with flags", function()
       it("LuaRocks doc of installed luarepl", function()
diff --git a/spec/download_spec.lua b/spec/download_spec.lua
index 64443922..152470a5 100644
--- a/spec/download_spec.lua
+++ b/spec/download_spec.lua
@@ -1,6 +1,7 @@
 local test_env = require("spec.util.test_env")
 local lfs = require("lfs")
 local run = test_env.run
+local testing_paths = test_env.testing_paths
 
 test_env.unload_luarocks()
 
@@ -33,4 +34,24 @@ describe("LuaRocks download tests #blackbox #b_download", function()
       assert.is.truthy(lfs.attributes("validate-args-1.5.4-1.rockspec"))
       test_env.remove_files(lfs.currentdir(), "validate--args--")
    end)
+
+   describe("#namespaces", function()
+      it("retrieves namespaced rockspec", function()
+         finally(function()
+            os.remove("a_rock-2.0-1.rockspec")
+         end)
+         assert(run.luarocks_bool("download a_user/a_rock --rockspec --server=" .. testing_paths.fixtures_dir .. "/a_repo" ))
+         assert(lfs.attributes("a_rock-2.0-1.rockspec"))
+      end)
+
+      it("retrieves namespaced rock", function()
+         finally(function()
+            os.remove("a_rock-2.0-1.src.rock")
+         end)
+         assert(run.luarocks_bool("download a_user/a_rock --server=" .. testing_paths.fixtures_dir .. "/a_repo" ))
+         assert(lfs.attributes("a_rock-2.0-1.src.rock"))
+      end)
+   end)
+
+
 end)
diff --git a/spec/fetch_spec.lua b/spec/fetch_spec.lua
index 5f518e4d..79b160c1 100644
--- a/spec/fetch_spec.lua
+++ b/spec/fetch_spec.lua
@@ -3,7 +3,6 @@ local git_repo = require("spec.util.git_repo")
 
 test_env.unload_luarocks()
 local fetch = require("luarocks.fetch")
-local vers = require("luarocks.vers")
 
 describe("Luarocks fetch test #whitebox #w_fetch", function()
    it("Fetch url to base dir", function()
@@ -30,12 +29,14 @@ describe("Luarocks fetch test #whitebox #w_fetch", function()
 
       it("from #git", function()
          local rockspec = {
-            format_is_at_least = vers.format_is_at_least,
+            format_is_at_least = function()
+               return true
+            end,
             name = "testrock",
             version = "dev-1",
             source = {
                protocol = "git",
-               url = "git://localhost:20000/testrock",
+               url = "git://localhost/testrock",
             },
             variables = {
                GIT = "git",
diff --git a/spec/fixtures/a_repo/manifest b/spec/fixtures/a_repo/manifest
index ea198207..141dafb5 100644
--- a/spec/fixtures/a_repo/manifest
+++ b/spec/fixtures/a_repo/manifest
@@ -10,5 +10,25 @@ repository = {
             arch = "rockspec"
          }
       }
+   },
+   has_another_namespaced_dep = {
+      ["1.0-1"] = {
+         {
+            arch = "rockspec"
+         },
+         {
+            arch = "src"
+         }
+      }
+   },
+   has_namespaced_dep = {
+      ["1.0-1"] = {
+         {
+            arch = "rockspec"
+         },
+         {
+            arch = "src"
+         }
+      }
    }
 }
diff --git a/spec/fixtures/a_repo/manifest-5.1 b/spec/fixtures/a_repo/manifest-5.1
index ea198207..141dafb5 100644
--- a/spec/fixtures/a_repo/manifest-5.1
+++ b/spec/fixtures/a_repo/manifest-5.1
@@ -10,5 +10,25 @@ repository = {
             arch = "rockspec"
          }
       }
+   },
+   has_another_namespaced_dep = {
+      ["1.0-1"] = {
+         {
+            arch = "rockspec"
+         },
+         {
+            arch = "src"
+         }
+      }
+   },
+   has_namespaced_dep = {
+      ["1.0-1"] = {
+         {
+            arch = "rockspec"
+         },
+         {
+            arch = "src"
+         }
+      }
    }
 }
diff --git a/spec/fixtures/a_repo/manifest-5.2 b/spec/fixtures/a_repo/manifest-5.2
index ea198207..141dafb5 100644
--- a/spec/fixtures/a_repo/manifest-5.2
+++ b/spec/fixtures/a_repo/manifest-5.2
@@ -10,5 +10,25 @@ repository = {
             arch = "rockspec"
          }
       }
+   },
+   has_another_namespaced_dep = {
+      ["1.0-1"] = {
+         {
+            arch = "rockspec"
+         },
+         {
+            arch = "src"
+         }
+      }
+   },
+   has_namespaced_dep = {
+      ["1.0-1"] = {
+         {
+            arch = "rockspec"
+         },
+         {
+            arch = "src"
+         }
+      }
    }
 }
diff --git a/spec/fixtures/a_repo/manifest-5.3 b/spec/fixtures/a_repo/manifest-5.3
index ea198207..141dafb5 100644
--- a/spec/fixtures/a_repo/manifest-5.3
+++ b/spec/fixtures/a_repo/manifest-5.3
@@ -10,5 +10,25 @@ repository = {
             arch = "rockspec"
          }
       }
+   },
+   has_another_namespaced_dep = {
+      ["1.0-1"] = {
+         {
+            arch = "rockspec"
+         },
+         {
+            arch = "src"
+         }
+      }
+   },
+   has_namespaced_dep = {
+      ["1.0-1"] = {
+         {
+            arch = "rockspec"
+         },
+         {
+            arch = "src"
+         }
+      }
    }
 }
diff --git a/spec/install_spec.lua b/spec/install_spec.lua
index 53c8f0d0..4043af35 100644
--- a/spec/install_spec.lua
+++ b/spec/install_spec.lua
@@ -77,11 +77,38 @@ describe("luarocks install #blackbox #b_install", function()
       end)
    end)
    
-   describe("#only namespaced packages", function()
+   describe("#namespaces", function()
       it("installs a namespaced package from the command-line", function()
          assert(run.luarocks_bool("install a_user/a_rock --server=" .. testing_paths.fixtures_dir .. "/a_repo" ))
          assert.is_false(run.luarocks_bool("show a_rock 1.0"))
          assert(run.luarocks_bool("show a_rock 2.0"))
+         assert(lfs.attributes(testing_paths.testing_sys_rocks .. "/a_rock/2.0-1/rock_namespace"))
+      end)
+
+      it("installs a package with a namespaced dependency", function()
+         assert(run.luarocks_bool("install has_namespaced_dep --server=" .. testing_paths.fixtures_dir .. "/a_repo" ))
+         assert(run.luarocks_bool("show has_namespaced_dep"))
+         assert.is_false(run.luarocks_bool("show a_rock 1.0"))
+         assert(run.luarocks_bool("show a_rock 2.0"))
+         assert(lfs.attributes(testing_paths.testing_sys_rocks .. "/a_rock/2.0-1/rock_namespace"))
+      end)
+
+      it("installs a package reusing a namespaced dependency", function()
+         assert(run.luarocks_bool("install a_user/a_rock --server=" .. testing_paths.fixtures_dir .. "/a_repo" ))
+         assert(run.luarocks_bool("show a_rock 2.0"))
+         assert(lfs.attributes(testing_paths.testing_sys_rocks .. "/a_rock/2.0-1/rock_namespace"))
+         local output = run.luarocks("install has_namespaced_dep --server=" .. testing_paths.fixtures_dir .. "/a_repo" )
+         assert.has.no.match("Missing dependencies", output)
+      end)
+
+      it("installs a package considering namespace of locally installed package", function()
+         assert(run.luarocks_bool("install a_user/a_rock --server=" .. testing_paths.fixtures_dir .. "/a_repo" ))
+         assert(run.luarocks_bool("show a_rock 2.0"))
+         assert(lfs.attributes(testing_paths.testing_sys_rocks .. "/a_rock/2.0-1/rock_namespace"))
+         local output = run.luarocks("install has_another_namespaced_dep --server=" .. testing_paths.fixtures_dir .. "/a_repo" )
+         assert.has.match("Missing dependencies", output)
+         print(output)
+         assert(run.luarocks_bool("show a_rock 3.0"))
       end)
    end)
 
@@ -155,7 +182,7 @@ describe("luarocks install #blackbox #b_install", function()
       it("only-deps of luasocket packed rock", function()
          assert.is_true(run.luarocks_bool("build --pack-binary-rock luasocket 3.0rc1-2"))
          local output = run.luarocks("install --only-deps " .. "luasocket-3.0rc1-2." .. test_env.platform .. ".rock")
-         assert.are.same(output, "Successfully installed dependencies for luasocket 3.0rc1-2")
+         assert.are.same("Successfully installed dependencies for luasocket 3.0rc1-2", output:gsub("\n", ""))
          assert.is_true(os.remove("luasocket-3.0rc1-2." .. test_env.platform .. ".rock"))
       end)
 
diff --git a/spec/list_spec.lua b/spec/list_spec.lua
index 07d60bf0..d6aeef38 100644
--- a/spec/list_spec.lua
+++ b/spec/list_spec.lua
@@ -17,7 +17,7 @@ describe("LuaRocks list tests #blackbox #b_list", function()
 
    it("LuaRocks list with no flags/arguments", function()
       local output = run.luarocks("list")
-      assert.is.truthy(output:find("luacov"))
+      assert.match("luacov", output)
    end)
 
    it("LuaRocks list porcelain", function()
@@ -33,6 +33,6 @@ describe("LuaRocks list tests #blackbox #b_list", function()
    
    it("LuaRocks list invalid tree", function()
       local output = run.luarocks("--tree=/some/invalid/tree list")
-      assert(output:find("Installed rocks for Lua "..test_env.lua_version..":----------------", 1, true))
+      assert(output:find("Installed rocks for Lua "..test_env.lua_version, 1, true))
    end)
 end)
diff --git a/spec/pack_spec.lua b/spec/pack_spec.lua
index 86b4e2b2..54d139e0 100644
--- a/spec/pack_spec.lua
+++ b/spec/pack_spec.lua
@@ -5,57 +5,89 @@ local testing_paths = test_env.testing_paths
 
 test_env.unload_luarocks()
 
-local extra_rocks = {
+local extra_rocks = test_env.mock_server_extra_rocks({
    "/luasec-0.6-1.rockspec",
    "/luassert-1.7.0-1.src.rock",
    "/luasocket-3.0rc1-2.src.rock",
    "/luasocket-3.0rc1-2.rockspec",
    "/say-1.2-1.src.rock",
    "/say-1.0-1.src.rock"
-}
+})
 
-describe("LuaRocks pack tests #blackbox #b_pack", function()
+describe("LuaRocks pack #blackbox #b_pack", function()
 
    before_each(function()
       test_env.setup_specs(extra_rocks)
    end)
 
-   it("LuaRocks pack with no flags/arguments", function()
+   it("with no flags/arguments", function()
       assert.is_false(run.luarocks_bool("pack"))
    end)
 
-   it("LuaRocks pack basic", function()
-      assert.is_true(run.luarocks_bool("pack luacov"))
-      assert.is_true(test_env.remove_files(lfs.currentdir(), "luacov%-"))
+   it("basic", function()
+      assert(run.luarocks_bool("pack luacov"))
+      assert(test_env.remove_files(lfs.currentdir(), "luacov%-"))
    end)
 
-   it("LuaRocks pack invalid rockspec", function()
-      assert.is_false(run.luarocks_bool("pack " .. testing_paths.fixtures_dir .. "/invaild_validate-args-1.5.4-1.rockspec"))
+   it("invalid rockspec", function()
+      assert.is_false(run.luarocks_bool("pack " .. testing_paths.fixtures_dir .. "/invalid_validate-args-1.5.4-1.rockspec"))
    end)
 
-   it("LuaRocks pack not installed rock", function()
+   it("not installed rock", function()
       assert.is_false(run.luarocks_bool("pack cjson"))
    end)
    
-   it("LuaRocks pack not installed rock from non existing manifest", function()
+   it("not installed rock from non existing manifest", function()
       assert.is_false(run.luarocks_bool("pack /non/exist/temp.manif"))
    end)
 
-   it("LuaRocks pack detects latest version version of rock", function()
-      assert.is_true(run.luarocks_bool("install say 1.2"))
-      assert.is_true(run.luarocks_bool("install luassert"))
-      assert.is_true(run.luarocks_bool("install say 1.0"))
-      assert.is_true(run.luarocks_bool("pack say"))
+   it("detects latest version version of rock", function()
+      assert(run.luarocks_bool("install say 1.2"))
+      assert(run.luarocks_bool("install luassert"))
+      assert(run.luarocks_bool("install say 1.0"))
+      assert(run.luarocks_bool("pack say"))
       assert.is_truthy(lfs.attributes("say-1.2-1.all.rock"))
-      assert.is_true(test_env.remove_files(lfs.currentdir(), "say%-"))
+      assert(test_env.remove_files(lfs.currentdir(), "say%-"))
    end)
 
-   it("LuaRocks pack src", function()
-      assert.is_true(run.luarocks_bool("install luasec " .. test_env.OPENSSL_DIRS))
-      assert.is_true(run.luarocks_bool("download --rockspec luasocket 3.0rc1-2"))
-      assert.is_true(run.luarocks_bool("pack luasocket-3.0rc1-2.rockspec"))
-      assert.is_true(test_env.remove_files(lfs.currentdir(), "luasocket%-"))
+   it("src", function()
+      assert(run.luarocks_bool("install luasec " .. test_env.OPENSSL_DIRS))
+      assert(run.luarocks_bool("download --rockspec luasocket 3.0rc1-2"))
+      assert(run.luarocks_bool("pack luasocket-3.0rc1-2.rockspec"))
+      assert(test_env.remove_files(lfs.currentdir(), "luasocket%-"))
    end)
+   
+   describe("#mock namespaced dependencies", function()
+
+      setup(function()
+         test_env.mock_server_init()
+      end)
+      
+      teardown(function()
+         test_env.mock_server_done()
+      end)
+
+      it("can pack rockspec with namespaced dependencies", function()
+         finally(function()
+            os.remove("has_namespaced_dep-1.0-1.src.rock")
+         end)
+         assert(run.luarocks_bool("pack " .. testing_paths.fixtures_dir .. "/a_repo/has_namespaced_dep-1.0-1.rockspec"))
+         assert.is_truthy(lfs.attributes("has_namespaced_dep-1.0-1.src.rock"))
+      end)
+   end)
+
+   describe("#namespaces", function()
+      it("packs a namespaced rock", function()
+         finally(function()
+            os.remove("a_rock-2.0-1.all.rock")
+         end)
+         assert(run.luarocks_bool("build a_user/a_rock --server=" .. testing_paths.fixtures_dir .. "/a_repo" ))
+         assert(run.luarocks_bool("build a_rock --keep --server=" .. testing_paths.fixtures_dir .. "/a_repo" ))
+         assert(run.luarocks_bool("pack a_user/a_rock" ))
+         assert(lfs.attributes("a_rock-2.0-1.all.rock"))
+      end)
+   end)
+
 end)
 
 
diff --git a/spec/show_spec.lua b/spec/show_spec.lua
index d572be9b..234a8a33 100644
--- a/spec/show_spec.lua
+++ b/spec/show_spec.lua
@@ -30,7 +30,7 @@ describe("LuaRocks show tests #blackbox #b_show", function()
       
       it("LuaRocks show modules of luacov", function()
          local output = run.luarocks("show --modules luacov")
-         assert.is.truthy(output:match("luacovluacov.defaultsluacov.reporterluacov.reporter.defaultluacov.runnerluacov.statsluacov.tick"))
+         assert.match("luacov.*luacov.defaults.*luacov.reporter.*luacov.reporter.default.*luacov.runner.*luacov.stats.*luacov.tick", output)
       end)
       
       it("LuaRocks show dependencies of luacov", function()
diff --git a/spec/util/mock-server.lua b/spec/util/mock-server.lua
index 77d32927..30586c98 100644
--- a/spec/util/mock-server.lua
+++ b/spec/util/mock-server.lua
@@ -70,7 +70,8 @@ server:add_resource("/file/{name:[^/]+}", {
       path = "/",
       produces = "text/plain",
       handler = function(query, name)
-         local fd = io.open("../spec/fixtures/"..name, "r")
+         local basedir = arg[1] or "../spec/fixtures"
+         local fd = io.open(basedir .. "/" .. name, "r")
          if not fd then
             return restserver.response():status(404)
          end
diff --git a/spec/util/test_env.lua b/spec/util/test_env.lua
index 23ca5c77..94008913 100644
--- a/spec/util/test_env.lua
+++ b/spec/util/test_env.lua
@@ -175,7 +175,7 @@ local function execute_output(command, print_command, env_variables)
    local file = assert(io.popen(command))
    local output = file:read('*all')
    file:close()
-   return output:gsub("\n","") -- output adding new line, need to be removed
+   return (output:gsub("\r\n", "\n"):gsub("\n$", "")) -- remove final newline
 end
 
 --- Set test_env.LUA_V or test_env.LUAJIT_V based
diff --git a/spec/write_rockspec_spec.lua b/spec/write_rockspec_spec.lua
index e4a7fa73..0a0988d0 100644
--- a/spec/write_rockspec_spec.lua
+++ b/spec/write_rockspec_spec.lua
@@ -42,27 +42,27 @@ describe("LuaRocks write_rockspec tests #blackbox #b_write_rockspec", function()
 
       it("runs", function()
          finally(function() os.remove("testrock-dev-1.rockspec") end)
-         assert.is_true(run.luarocks_bool("write_rockspec git://localhost:20000/testrock"))
+         assert.is_true(run.luarocks_bool("write_rockspec git://localhost/testrock"))
          assert.is.truthy(lfs.attributes("testrock-dev-1.rockspec"))
       end)
       
       it("runs with --tag", function()
          finally(function() os.remove("testrock-2.3.0-1.rockspec") end)
-         assert.is_true(run.luarocks_bool("write_rockspec git://localhost:20000/testrock --tag=v2.3.0"))
+         assert.is_true(run.luarocks_bool("write_rockspec git://localhost/testrock --tag=v2.3.0"))
          assert.is.truthy(lfs.attributes("testrock-2.3.0-1.rockspec"))
          -- TODO check contents
       end)
       
       it("runs with format flag", function()
          finally(function() os.remove("testrock-dev-1.rockspec") end)
-         assert.is_true(run.luarocks_bool("write_rockspec git://localhost:20000/testrock --rockspec-format=1.1 --lua-version=5.1,5.2"))
+         assert.is_true(run.luarocks_bool("write_rockspec git://localhost/testrock --rockspec-format=1.1 --lua-version=5.1,5.2"))
          assert.is.truthy(lfs.attributes("testrock-dev-1.rockspec"))
          -- TODO check contents
       end)
       
       it("runs with full flags", function()
          finally(function() os.remove("testrock-dev-1.rockspec") end)
-         assert.is_true(run.luarocks_bool("write_rockspec git://localhost:20000/testrock --lua-version=5.1,5.2 --license=\"MIT/X11\" "
+         assert.is_true(run.luarocks_bool("write_rockspec git://localhost/testrock --lua-version=5.1,5.2 --license=\"MIT/X11\" "
                                              .. " --homepage=\"http://www.luarocks.org\" --summary=\"A package manager for Lua modules\" "))
          assert.is.truthy(lfs.attributes("testrock-dev-1.rockspec"))
          -- TODO check contents
@@ -70,7 +70,7 @@ describe("LuaRocks write_rockspec tests #blackbox #b_write_rockspec", function()
 
       it("with various flags", function()
          finally(function() os.remove("testrock-dev-1.rockspec") end)
-         assert.is_true(run.luarocks_bool("write_rockspec git://localhost:20000/testrock --lib=fcgi --license=\"3-clause BSD\" " .. "--lua-version=5.1,5.2"))
+         assert.is_true(run.luarocks_bool("write_rockspec git://localhost/testrock --lib=fcgi --license=\"3-clause BSD\" " .. "--lua-version=5.1,5.2"))
          assert.is.truthy(lfs.attributes("testrock-dev-1.rockspec"))
          -- TODO check contents
       end)