Regenerate manifest every time we delete a version.

This is a naive implementation of the solution suggested by @mpeterv for #268.
I'm merging this since it does produce more correct behavior,
at the cost of a performance regression. We need a function akin to
update_manifest for removing packages from a manifest.

6 files changed, 24 insertions, 14 deletions

diff --git a/src/luarocks/build.lua b/src/luarocks/build.lua
index f87b2f1b..f2784a3a 100644
--- a/src/luarocks/build.lua
+++ b/src/luarocks/build.lua
@@ -202,7 +202,7 @@ function build.build_rockspec(rockspec_file, need_to_fetch, minimal_mode, deps_m
    end   
 
    if repos.is_installed(name, version) then
-      repos.delete_version(name, version)
+      repos.delete_version(name, version, deps_mode)
    end
 
    if not minimal_mode then
@@ -325,7 +325,7 @@ function build.build_rockspec(rockspec_file, need_to_fetch, minimal_mode, deps_m
    
    util.remove_scheduled_function(rollback)
    rollback = util.schedule_function(function()
-      repos.delete_version(name, version)
+      repos.delete_version(name, version, deps_mode)
    end)
 
    ok, err = repos.run_hook(rockspec, "post_install")
diff --git a/src/luarocks/install.lua b/src/luarocks/install.lua
index acbf584a..daebfc70 100644
--- a/src/luarocks/install.lua
+++ b/src/luarocks/install.lua
@@ -50,7 +50,7 @@ function install.install_binary_rock(rock_file, deps_mode)
       return nil, "Incompatible architecture "..arch, "arch"
    end
    if repos.is_installed(name, version) then
-      repos.delete_version(name, version)
+      repos.delete_version(name, version, deps_mode)
    end
    
    local rollback = util.schedule_function(function()
@@ -89,7 +89,7 @@ function install.install_binary_rock(rock_file, deps_mode)
 
    util.remove_scheduled_function(rollback)
    rollback = util.schedule_function(function()
-      repos.delete_version(name, version)
+      repos.delete_version(name, version, deps_mode)
    end)
 
    ok, err = repos.run_hook(rockspec, "post_install")
@@ -168,7 +168,7 @@ function install.command(flags, name, version)
          ok, err = install.install_binary_rock(name, deps.get_deps_mode(flags))
       end
       if not ok then return nil, err end
-      local name, version = ok, err
+      name, version = ok, err
       if (not flags["only-deps"]) and (not flags["keep"]) and not cfg.keep_other_versions then
          local ok, err = remove.remove_other_versions(name, version, flags["force"], flags["force-fast"])
          if not ok then util.printerr(err) end
diff --git a/src/luarocks/manif.lua b/src/luarocks/manif.lua
index 48b4f23d..a8bbf279 100644
--- a/src/luarocks/manif.lua
+++ b/src/luarocks/manif.lua
@@ -365,7 +365,7 @@ end
 -- @param deps_mode string: Dependency mode: "one" for the current default tree,
 -- "all" for all trees, "order" for all trees with priority >= the current default,
 -- "none" for the default dependency mode from the configuration.
--- @param versioned boolean: if versioned versions of the manifest should be created.
+-- @param remote boolean: 'true' if making a manifest for a rocks server.
 -- @return boolean or (nil, string): True if manifest was generated,
 -- or nil and an error message.
 function manif.make_manifest(repo, deps_mode, remote)
diff --git a/src/luarocks/purge.lua b/src/luarocks/purge.lua
index 1ce46c0f..17724e84 100644
--- a/src/luarocks/purge.lua
+++ b/src/luarocks/purge.lua
@@ -66,7 +66,7 @@ function purge.command(flags)
             break
          else
             util.printout("Removing "..package.." "..version.."...")
-            local ok, err = repos.delete_version(package, version, true)
+            local ok, err = repos.delete_version(package, version, "none", true)
             if not ok then
                util.printerr(err)
             end
diff --git a/src/luarocks/remove.lua b/src/luarocks/remove.lua
index d72fabaf..82c9818b 100644
--- a/src/luarocks/remove.lua
+++ b/src/luarocks/remove.lua
@@ -62,12 +62,15 @@ end
 --- Delete given versions of a program.
 -- @param name string: the name of a program
 -- @param versions array of string: the versions to be deleted.
+-- @param deps_mode: string: Which trees to check dependencies for:
+-- "one" for the current default tree, "all" for all trees,
+-- "order" for all trees with priority >= the current default, "none" for no trees.
 -- @return boolean or (nil, string): true on success or nil and an error message.
-local function delete_versions(name, versions) 
+local function delete_versions(name, versions, deps_mode) 
 
    for version, _ in pairs(versions) do
       util.printout("Removing "..name.." "..version.."...")
-      local ok, err = repos.delete_version(name, version)
+      local ok, err = repos.delete_version(name, version, deps_mode)
       if not ok then return nil, err end
    end
    
@@ -112,9 +115,7 @@ function remove.remove_search_results(results, name, deps_mode, force, fast)
       end
    end
    
-   local ok, err = delete_versions(name, versions)
-   if not ok then return nil, err end
-   ok, err = manif.make_manifest(cfg.rocks_dir, deps_mode)
+   local ok, err = delete_versions(name, versions, deps_mode)
    if not ok then return nil, err end
 
    util.printout("Removal successful.")
diff --git a/src/luarocks/repos.lua b/src/luarocks/repos.lua
index 86126a13..4e8a9a13 100644
--- a/src/luarocks/repos.lua
+++ b/src/luarocks/repos.lua
@@ -267,13 +267,17 @@ end
 -- Version numbers are compared as exact string comparison.
 -- @param name string: name of package
 -- @param version string: package version in string format
+-- @param deps_mode: string: Which trees to check dependencies for:
+-- "one" for the current default tree, "all" for all trees,
+-- "order" for all trees with priority >= the current default, "none" for no trees.
 -- @param quick boolean: do not try to fix the versioned name
 -- of another version that provides the same module that
 -- was deleted. This is used during 'purge', as every module
 -- will be eventually deleted.
-function repos.delete_version(name, version, quick)
+function repos.delete_version(name, version, deps_mode, quick)
    assert(type(name) == "string")
    assert(type(version) == "string")
+   assert(type(deps_mode) == "string")
 
    local function delete_deployed_file_tree(file_tree, deploy_dir, suffix)
       return recurse_rock_manifest_tree(file_tree, 
@@ -323,7 +327,12 @@ function repos.delete_version(name, version, quick)
    if not get_installed_versions(name) then
       fs.delete(dir.path(cfg.rocks_dir, name))
    end
-   return true
+   
+   if quick then
+      return true
+   end
+
+   return manif.make_manifest(cfg.rocks_dir, deps_mode)
 end
 
 return repos