summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authortb <>2026-07-28 10:29:05 +0000
committertb <>2026-07-28 10:29:05 +0000
commit232e4582dd23763c78b3bb546bef2f11ee7103c8 (patch)
tree19202eb9e78a4705118e884ac6ba50c69ac09030
parent23142a81f73eb55374d6f58cc40858136fa38c80 (diff)
downloadopenbsd-232e4582dd23763c78b3bb546bef2f11ee7103c8.tar.gz
openbsd-232e4582dd23763c78b3bb546bef2f11ee7103c8.tar.bz2
openbsd-232e4582dd23763c78b3bb546bef2f11ee7103c8.zip
tlsfuzzer: avoid mutable default arguments
-rw-r--r--src/regress/lib/libssl/tlsfuzzer/tlsfuzzer.py24
1 files changed, 18 insertions, 6 deletions
diff --git a/src/regress/lib/libssl/tlsfuzzer/tlsfuzzer.py b/src/regress/lib/libssl/tlsfuzzer/tlsfuzzer.py
index 2b78e07b4e..8e12494379 100644
--- a/src/regress/lib/libssl/tlsfuzzer/tlsfuzzer.py
+++ b/src/regress/lib/libssl/tlsfuzzer/tlsfuzzer.py
@@ -1,4 +1,4 @@
1# $OpenBSD: tlsfuzzer.py,v 1.61 2026/07/28 10:21:34 tb Exp $ 1# $OpenBSD: tlsfuzzer.py,v 1.62 2026/07/28 10:29:05 tb Exp $
2# 2#
3# Copyright (c) 2020 Theo Buehler <tb@openbsd.org> 3# Copyright (c) 2020 Theo Buehler <tb@openbsd.org>
4# 4#
@@ -32,7 +32,15 @@ class Test:
32 32
33 XXX Add client cert support. 33 XXX Add client cert support.
34 """ 34 """
35 def __init__(self, name="", args=[], tls12_args=[], tls13_args=[]): 35
36 def __init__(self, name="", args=None, tls12_args=None, tls13_args=None):
37 if args is None:
38 args = []
39 if tls12_args is None:
40 tls12_args = []
41 if tls13_args is None:
42 tls13_args = []
43
36 self.name = name 44 self.name = name
37 self.tls12_args = args 45 self.tls12_args = args
38 self.tls13_args = args 46 self.tls13_args = args
@@ -55,7 +63,10 @@ class Test:
55class TestGroup: 63class TestGroup:
56 """A group of Test objects to be run by TestRunner.""" 64 """A group of Test objects to be run by TestRunner."""
57 65
58 def __init__(self, title="Tests", tests=[]): 66 def __init__(self, title="Tests", tests=None):
67 if tests is None:
68 tests = []
69
59 self.title = title 70 self.title = title
60 self.tests = tests 71 self.tests = tests
61 72
@@ -654,7 +665,7 @@ class TestRunner:
654 665
655 def __init__( 666 def __init__(
656 self, timing=False, verbose=False, host="localhost", port=4433, 667 self, timing=False, verbose=False, host="localhost", port=4433,
657 use_tls1_3=True, dry_run=False, tests=[], scriptdir=tlsfuzzer_scriptdir, 668 use_tls1_3=True, dry_run=False, scriptdir=tlsfuzzer_scriptdir,
658 ): 669 ):
659 self.tests = [] 670 self.tests = []
660 671
@@ -671,8 +682,9 @@ class TestRunner:
671 self.timing = timing 682 self.timing = timing
672 self.verbose = verbose 683 self.verbose = verbose
673 684
674 def add(self, title="tests", tests=[]): 685 def add(self, title="tests", tests=None):
675 # tests.sort(key=lambda test: test.name) 686 if tests is None:
687 tests = []
676 self.tests.append(TestGroup(title, tests)) 688 self.tests.append(TestGroup(title, tests))
677 689
678 def add_group(self, group): 690 def add_group(self, group):