diff options
author | jsing <> | 2020-10-03 18:01:55 +0000 |
---|---|---|
committer | jsing <> | 2020-10-03 18:01:55 +0000 |
commit | 3aed61703f68a54e3f14a52befd98a4b9b9a59b8 (patch) | |
tree | 2551d0043eb97a752fc5f4f898fb518c397c443c | |
parent | 7ec834bc3417b066072208fd7b33985994ff8ec2 (diff) | |
download | openbsd-3aed61703f68a54e3f14a52befd98a4b9b9a59b8.tar.gz openbsd-3aed61703f68a54e3f14a52befd98a4b9b9a59b8.tar.bz2 openbsd-3aed61703f68a54e3f14a52befd98a4b9b9a59b8.zip |
Merge d1_{clnt,srvr}.c into ssl_{clnt,srvr}.c
The d1_{clnt,srvr}.c contain a single function each - merge these into the
ssl_{clnt,srvr}.c, renaming them with an ssl3_ prefix for consistency.
ok beck@ tb@
-rw-r--r-- | src/lib/libssl/Makefile | 4 | ||||
-rw-r--r-- | src/lib/libssl/d1_clnt.c | 184 | ||||
-rw-r--r-- | src/lib/libssl/d1_srvr.c | 165 | ||||
-rw-r--r-- | src/lib/libssl/ssl_clnt.c | 60 | ||||
-rw-r--r-- | src/lib/libssl/ssl_locl.h | 6 | ||||
-rw-r--r-- | src/lib/libssl/ssl_srvr.c | 43 |
6 files changed, 103 insertions, 359 deletions
diff --git a/src/lib/libssl/Makefile b/src/lib/libssl/Makefile index 2e06f13e9c..e4ad5f36f7 100644 --- a/src/lib/libssl/Makefile +++ b/src/lib/libssl/Makefile | |||
@@ -1,4 +1,4 @@ | |||
1 | # $OpenBSD: Makefile,v 1.67 2020/08/30 15:40:19 jsing Exp $ | 1 | # $OpenBSD: Makefile,v 1.68 2020/10/03 18:01:55 jsing Exp $ |
2 | 2 | ||
3 | .include <bsd.own.mk> | 3 | .include <bsd.own.mk> |
4 | .ifndef NOMAN | 4 | .ifndef NOMAN |
@@ -36,11 +36,9 @@ SRCS= \ | |||
36 | bs_cbb.c \ | 36 | bs_cbb.c \ |
37 | bs_cbs.c \ | 37 | bs_cbs.c \ |
38 | d1_both.c \ | 38 | d1_both.c \ |
39 | d1_clnt.c \ | ||
40 | d1_lib.c \ | 39 | d1_lib.c \ |
41 | d1_pkt.c \ | 40 | d1_pkt.c \ |
42 | d1_srtp.c \ | 41 | d1_srtp.c \ |
43 | d1_srvr.c \ | ||
44 | pqueue.c \ | 42 | pqueue.c \ |
45 | s3_cbc.c \ | 43 | s3_cbc.c \ |
46 | s3_lib.c \ | 44 | s3_lib.c \ |
diff --git a/src/lib/libssl/d1_clnt.c b/src/lib/libssl/d1_clnt.c deleted file mode 100644 index b660589d06..0000000000 --- a/src/lib/libssl/d1_clnt.c +++ /dev/null | |||
@@ -1,184 +0,0 @@ | |||
1 | /* $OpenBSD: d1_clnt.c,v 1.83 2020/01/23 10:48:37 jsing Exp $ */ | ||
2 | /* | ||
3 | * DTLS implementation written by Nagendra Modadugu | ||
4 | * (nagendra@cs.stanford.edu) for the OpenSSL project 2005. | ||
5 | */ | ||
6 | /* ==================================================================== | ||
7 | * Copyright (c) 1999-2007 The OpenSSL Project. All rights reserved. | ||
8 | * | ||
9 | * Redistribution and use in source and binary forms, with or without | ||
10 | * modification, are permitted provided that the following conditions | ||
11 | * are met: | ||
12 | * | ||
13 | * 1. Redistributions of source code must retain the above copyright | ||
14 | * notice, this list of conditions and the following disclaimer. | ||
15 | * | ||
16 | * 2. Redistributions in binary form must reproduce the above copyright | ||
17 | * notice, this list of conditions and the following disclaimer in | ||
18 | * the documentation and/or other materials provided with the | ||
19 | * distribution. | ||
20 | * | ||
21 | * 3. All advertising materials mentioning features or use of this | ||
22 | * software must display the following acknowledgment: | ||
23 | * "This product includes software developed by the OpenSSL Project | ||
24 | * for use in the OpenSSL Toolkit. (http://www.OpenSSL.org/)" | ||
25 | * | ||
26 | * 4. The names "OpenSSL Toolkit" and "OpenSSL Project" must not be used to | ||
27 | * endorse or promote products derived from this software without | ||
28 | * prior written permission. For written permission, please contact | ||
29 | * openssl-core@OpenSSL.org. | ||
30 | * | ||
31 | * 5. Products derived from this software may not be called "OpenSSL" | ||
32 | * nor may "OpenSSL" appear in their names without prior written | ||
33 | * permission of the OpenSSL Project. | ||
34 | * | ||
35 | * 6. Redistributions of any form whatsoever must retain the following | ||
36 | * acknowledgment: | ||
37 | * "This product includes software developed by the OpenSSL Project | ||
38 | * for use in the OpenSSL Toolkit (http://www.OpenSSL.org/)" | ||
39 | * | ||
40 | * THIS SOFTWARE IS PROVIDED BY THE OpenSSL PROJECT ``AS IS'' AND ANY | ||
41 | * EXPRESSED OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE | ||
42 | * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR | ||
43 | * PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE OpenSSL PROJECT OR | ||
44 | * ITS CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, | ||
45 | * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT | ||
46 | * NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; | ||
47 | * LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) | ||
48 | * HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, | ||
49 | * STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) | ||
50 | * ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED | ||
51 | * OF THE POSSIBILITY OF SUCH DAMAGE. | ||
52 | * ==================================================================== | ||
53 | * | ||
54 | * This product includes cryptographic software written by Eric Young | ||
55 | * (eay@cryptsoft.com). This product includes software written by Tim | ||
56 | * Hudson (tjh@cryptsoft.com). | ||
57 | * | ||
58 | */ | ||
59 | /* Copyright (C) 1995-1998 Eric Young (eay@cryptsoft.com) | ||
60 | * All rights reserved. | ||
61 | * | ||
62 | * This package is an SSL implementation written | ||
63 | * by Eric Young (eay@cryptsoft.com). | ||
64 | * The implementation was written so as to conform with Netscapes SSL. | ||
65 | * | ||
66 | * This library is free for commercial and non-commercial use as long as | ||
67 | * the following conditions are aheared to. The following conditions | ||
68 | * apply to all code found in this distribution, be it the RC4, RSA, | ||
69 | * lhash, DES, etc., code; not just the SSL code. The SSL documentation | ||
70 | * included with this distribution is covered by the same copyright terms | ||
71 | * except that the holder is Tim Hudson (tjh@cryptsoft.com). | ||
72 | * | ||
73 | * Copyright remains Eric Young's, and as such any Copyright notices in | ||
74 | * the code are not to be removed. | ||
75 | * If this package is used in a product, Eric Young should be given attribution | ||
76 | * as the author of the parts of the library used. | ||
77 | * This can be in the form of a textual message at program startup or | ||
78 | * in documentation (online or textual) provided with the package. | ||
79 | * | ||
80 | * Redistribution and use in source and binary forms, with or without | ||
81 | * modification, are permitted provided that the following conditions | ||
82 | * are met: | ||
83 | * 1. Redistributions of source code must retain the copyright | ||
84 | * notice, this list of conditions and the following disclaimer. | ||
85 | * 2. Redistributions in binary form must reproduce the above copyright | ||
86 | * notice, this list of conditions and the following disclaimer in the | ||
87 | * documentation and/or other materials provided with the distribution. | ||
88 | * 3. All advertising materials mentioning features or use of this software | ||
89 | * must display the following acknowledgement: | ||
90 | * "This product includes cryptographic software written by | ||
91 | * Eric Young (eay@cryptsoft.com)" | ||
92 | * The word 'cryptographic' can be left out if the rouines from the library | ||
93 | * being used are not cryptographic related :-). | ||
94 | * 4. If you include any Windows specific code (or a derivative thereof) from | ||
95 | * the apps directory (application code) you must include an acknowledgement: | ||
96 | * "This product includes software written by Tim Hudson (tjh@cryptsoft.com)" | ||
97 | * | ||
98 | * THIS SOFTWARE IS PROVIDED BY ERIC YOUNG ``AS IS'' AND | ||
99 | * ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE | ||
100 | * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE | ||
101 | * ARE DISCLAIMED. IN NO EVENT SHALL THE AUTHOR OR CONTRIBUTORS BE LIABLE | ||
102 | * FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL | ||
103 | * DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS | ||
104 | * OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) | ||
105 | * HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT | ||
106 | * LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY | ||
107 | * OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF | ||
108 | * SUCH DAMAGE. | ||
109 | * | ||
110 | * The licence and distribution terms for any publically available version or | ||
111 | * derivative of this code cannot be changed. i.e. this code cannot simply be | ||
112 | * copied and put under another distribution licence | ||
113 | * [including the GNU Public Licence.] | ||
114 | */ | ||
115 | |||
116 | #include <limits.h> | ||
117 | #include <stdio.h> | ||
118 | |||
119 | #include "ssl_locl.h" | ||
120 | |||
121 | #include <openssl/bn.h> | ||
122 | #include <openssl/buffer.h> | ||
123 | #include <openssl/dh.h> | ||
124 | #include <openssl/evp.h> | ||
125 | #include <openssl/md5.h> | ||
126 | #include <openssl/objects.h> | ||
127 | |||
128 | #include "bytestring.h" | ||
129 | |||
130 | int | ||
131 | dtls1_get_hello_verify(SSL *s) | ||
132 | { | ||
133 | long n; | ||
134 | int al, ok = 0; | ||
135 | size_t cookie_len; | ||
136 | uint16_t ssl_version; | ||
137 | CBS hello_verify_request, cookie; | ||
138 | |||
139 | n = ssl3_get_message(s, DTLS1_ST_CR_HELLO_VERIFY_REQUEST_A, | ||
140 | DTLS1_ST_CR_HELLO_VERIFY_REQUEST_B, -1, s->internal->max_cert_list, &ok); | ||
141 | if (!ok) | ||
142 | return ((int)n); | ||
143 | |||
144 | if (S3I(s)->tmp.message_type != DTLS1_MT_HELLO_VERIFY_REQUEST) { | ||
145 | D1I(s)->send_cookie = 0; | ||
146 | S3I(s)->tmp.reuse_message = 1; | ||
147 | return (1); | ||
148 | } | ||
149 | |||
150 | if (n < 0) | ||
151 | goto truncated; | ||
152 | |||
153 | CBS_init(&hello_verify_request, s->internal->init_msg, n); | ||
154 | |||
155 | if (!CBS_get_u16(&hello_verify_request, &ssl_version)) | ||
156 | goto truncated; | ||
157 | |||
158 | if (ssl_version != s->version) { | ||
159 | SSLerror(s, SSL_R_WRONG_SSL_VERSION); | ||
160 | s->version = (s->version & 0xff00) | (ssl_version & 0xff); | ||
161 | al = SSL_AD_PROTOCOL_VERSION; | ||
162 | goto f_err; | ||
163 | } | ||
164 | |||
165 | if (!CBS_get_u8_length_prefixed(&hello_verify_request, &cookie)) | ||
166 | goto truncated; | ||
167 | |||
168 | if (!CBS_write_bytes(&cookie, D1I(s)->cookie, | ||
169 | sizeof(D1I(s)->cookie), &cookie_len)) { | ||
170 | D1I(s)->cookie_len = 0; | ||
171 | al = SSL_AD_ILLEGAL_PARAMETER; | ||
172 | goto f_err; | ||
173 | } | ||
174 | D1I(s)->cookie_len = cookie_len; | ||
175 | D1I(s)->send_cookie = 1; | ||
176 | |||
177 | return 1; | ||
178 | |||
179 | truncated: | ||
180 | al = SSL_AD_DECODE_ERROR; | ||
181 | f_err: | ||
182 | ssl3_send_alert(s, SSL3_AL_FATAL, al); | ||
183 | return -1; | ||
184 | } | ||
diff --git a/src/lib/libssl/d1_srvr.c b/src/lib/libssl/d1_srvr.c deleted file mode 100644 index 1a1ee5429e..0000000000 --- a/src/lib/libssl/d1_srvr.c +++ /dev/null | |||
@@ -1,165 +0,0 @@ | |||
1 | /* $OpenBSD: d1_srvr.c,v 1.95 2018/11/05 05:45:15 jsing Exp $ */ | ||
2 | /* | ||
3 | * DTLS implementation written by Nagendra Modadugu | ||
4 | * (nagendra@cs.stanford.edu) for the OpenSSL project 2005. | ||
5 | */ | ||
6 | /* ==================================================================== | ||
7 | * Copyright (c) 1999-2007 The OpenSSL Project. All rights reserved. | ||
8 | * | ||
9 | * Redistribution and use in source and binary forms, with or without | ||
10 | * modification, are permitted provided that the following conditions | ||
11 | * are met: | ||
12 | * | ||
13 | * 1. Redistributions of source code must retain the above copyright | ||
14 | * notice, this list of conditions and the following disclaimer. | ||
15 | * | ||
16 | * 2. Redistributions in binary form must reproduce the above copyright | ||
17 | * notice, this list of conditions and the following disclaimer in | ||
18 | * the documentation and/or other materials provided with the | ||
19 | * distribution. | ||
20 | * | ||
21 | * 3. All advertising materials mentioning features or use of this | ||
22 | * software must display the following acknowledgment: | ||
23 | * "This product includes software developed by the OpenSSL Project | ||
24 | * for use in the OpenSSL Toolkit. (http://www.OpenSSL.org/)" | ||
25 | * | ||
26 | * 4. The names "OpenSSL Toolkit" and "OpenSSL Project" must not be used to | ||
27 | * endorse or promote products derived from this software without | ||
28 | * prior written permission. For written permission, please contact | ||
29 | * openssl-core@OpenSSL.org. | ||
30 | * | ||
31 | * 5. Products derived from this software may not be called "OpenSSL" | ||
32 | * nor may "OpenSSL" appear in their names without prior written | ||
33 | * permission of the OpenSSL Project. | ||
34 | * | ||
35 | * 6. Redistributions of any form whatsoever must retain the following | ||
36 | * acknowledgment: | ||
37 | * "This product includes software developed by the OpenSSL Project | ||
38 | * for use in the OpenSSL Toolkit (http://www.OpenSSL.org/)" | ||
39 | * | ||
40 | * THIS SOFTWARE IS PROVIDED BY THE OpenSSL PROJECT ``AS IS'' AND ANY | ||
41 | * EXPRESSED OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE | ||
42 | * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR | ||
43 | * PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE OpenSSL PROJECT OR | ||
44 | * ITS CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, | ||
45 | * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT | ||
46 | * NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; | ||
47 | * LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) | ||
48 | * HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, | ||
49 | * STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) | ||
50 | * ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED | ||
51 | * OF THE POSSIBILITY OF SUCH DAMAGE. | ||
52 | * ==================================================================== | ||
53 | * | ||
54 | * This product includes cryptographic software written by Eric Young | ||
55 | * (eay@cryptsoft.com). This product includes software written by Tim | ||
56 | * Hudson (tjh@cryptsoft.com). | ||
57 | * | ||
58 | */ | ||
59 | /* Copyright (C) 1995-1998 Eric Young (eay@cryptsoft.com) | ||
60 | * All rights reserved. | ||
61 | * | ||
62 | * This package is an SSL implementation written | ||
63 | * by Eric Young (eay@cryptsoft.com). | ||
64 | * The implementation was written so as to conform with Netscapes SSL. | ||
65 | * | ||
66 | * This library is free for commercial and non-commercial use as long as | ||
67 | * the following conditions are aheared to. The following conditions | ||
68 | * apply to all code found in this distribution, be it the RC4, RSA, | ||
69 | * lhash, DES, etc., code; not just the SSL code. The SSL documentation | ||
70 | * included with this distribution is covered by the same copyright terms | ||
71 | * except that the holder is Tim Hudson (tjh@cryptsoft.com). | ||
72 | * | ||
73 | * Copyright remains Eric Young's, and as such any Copyright notices in | ||
74 | * the code are not to be removed. | ||
75 | * If this package is used in a product, Eric Young should be given attribution | ||
76 | * as the author of the parts of the library used. | ||
77 | * This can be in the form of a textual message at program startup or | ||
78 | * in documentation (online or textual) provided with the package. | ||
79 | * | ||
80 | * Redistribution and use in source and binary forms, with or without | ||
81 | * modification, are permitted provided that the following conditions | ||
82 | * are met: | ||
83 | * 1. Redistributions of source code must retain the copyright | ||
84 | * notice, this list of conditions and the following disclaimer. | ||
85 | * 2. Redistributions in binary form must reproduce the above copyright | ||
86 | * notice, this list of conditions and the following disclaimer in the | ||
87 | * documentation and/or other materials provided with the distribution. | ||
88 | * 3. All advertising materials mentioning features or use of this software | ||
89 | * must display the following acknowledgement: | ||
90 | * "This product includes cryptographic software written by | ||
91 | * Eric Young (eay@cryptsoft.com)" | ||
92 | * The word 'cryptographic' can be left out if the rouines from the library | ||
93 | * being used are not cryptographic related :-). | ||
94 | * 4. If you include any Windows specific code (or a derivative thereof) from | ||
95 | * the apps directory (application code) you must include an acknowledgement: | ||
96 | * "This product includes software written by Tim Hudson (tjh@cryptsoft.com)" | ||
97 | * | ||
98 | * THIS SOFTWARE IS PROVIDED BY ERIC YOUNG ``AS IS'' AND | ||
99 | * ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE | ||
100 | * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE | ||
101 | * ARE DISCLAIMED. IN NO EVENT SHALL THE AUTHOR OR CONTRIBUTORS BE LIABLE | ||
102 | * FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL | ||
103 | * DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS | ||
104 | * OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) | ||
105 | * HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT | ||
106 | * LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY | ||
107 | * OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF | ||
108 | * SUCH DAMAGE. | ||
109 | * | ||
110 | * The licence and distribution terms for any publically available version or | ||
111 | * derivative of this code cannot be changed. i.e. this code cannot simply be | ||
112 | * copied and put under another distribution licence | ||
113 | * [including the GNU Public Licence.] | ||
114 | */ | ||
115 | |||
116 | #include <stdio.h> | ||
117 | |||
118 | #include "ssl_locl.h" | ||
119 | |||
120 | #include <openssl/bn.h> | ||
121 | #include <openssl/buffer.h> | ||
122 | #include <openssl/dh.h> | ||
123 | #include <openssl/evp.h> | ||
124 | #include <openssl/md5.h> | ||
125 | #include <openssl/objects.h> | ||
126 | #include <openssl/x509.h> | ||
127 | |||
128 | int | ||
129 | dtls1_send_hello_verify_request(SSL *s) | ||
130 | { | ||
131 | CBB cbb, verify, cookie; | ||
132 | |||
133 | memset(&cbb, 0, sizeof(cbb)); | ||
134 | |||
135 | if (S3I(s)->hs.state == DTLS1_ST_SW_HELLO_VERIFY_REQUEST_A) { | ||
136 | if (s->ctx->internal->app_gen_cookie_cb == NULL || | ||
137 | s->ctx->internal->app_gen_cookie_cb(s, D1I(s)->cookie, | ||
138 | &(D1I(s)->cookie_len)) == 0) { | ||
139 | SSLerror(s, ERR_R_INTERNAL_ERROR); | ||
140 | return 0; | ||
141 | } | ||
142 | |||
143 | if (!ssl3_handshake_msg_start(s, &cbb, &verify, | ||
144 | DTLS1_MT_HELLO_VERIFY_REQUEST)) | ||
145 | goto err; | ||
146 | if (!CBB_add_u16(&verify, s->version)) | ||
147 | goto err; | ||
148 | if (!CBB_add_u8_length_prefixed(&verify, &cookie)) | ||
149 | goto err; | ||
150 | if (!CBB_add_bytes(&cookie, D1I(s)->cookie, D1I(s)->cookie_len)) | ||
151 | goto err; | ||
152 | if (!ssl3_handshake_msg_finish(s, &cbb)) | ||
153 | goto err; | ||
154 | |||
155 | S3I(s)->hs.state = DTLS1_ST_SW_HELLO_VERIFY_REQUEST_B; | ||
156 | } | ||
157 | |||
158 | /* S3I(s)->hs.state = DTLS1_ST_SW_HELLO_VERIFY_REQUEST_B */ | ||
159 | return (ssl3_handshake_write(s)); | ||
160 | |||
161 | err: | ||
162 | CBB_cleanup(&cbb); | ||
163 | |||
164 | return (-1); | ||
165 | } | ||
diff --git a/src/lib/libssl/ssl_clnt.c b/src/lib/libssl/ssl_clnt.c index f11dcaa107..3d11aaaf36 100644 --- a/src/lib/libssl/ssl_clnt.c +++ b/src/lib/libssl/ssl_clnt.c | |||
@@ -1,4 +1,4 @@ | |||
1 | /* $OpenBSD: ssl_clnt.c,v 1.73 2020/09/24 18:12:00 jsing Exp $ */ | 1 | /* $OpenBSD: ssl_clnt.c,v 1.74 2020/10/03 18:01:55 jsing Exp $ */ |
2 | /* Copyright (C) 1995-1998 Eric Young (eay@cryptsoft.com) | 2 | /* Copyright (C) 1995-1998 Eric Young (eay@cryptsoft.com) |
3 | * All rights reserved. | 3 | * All rights reserved. |
4 | * | 4 | * |
@@ -318,7 +318,7 @@ ssl3_connect(SSL *s) | |||
318 | 318 | ||
319 | case DTLS1_ST_CR_HELLO_VERIFY_REQUEST_A: | 319 | case DTLS1_ST_CR_HELLO_VERIFY_REQUEST_A: |
320 | case DTLS1_ST_CR_HELLO_VERIFY_REQUEST_B: | 320 | case DTLS1_ST_CR_HELLO_VERIFY_REQUEST_B: |
321 | ret = dtls1_get_hello_verify(s); | 321 | ret = ssl3_get_dtls_hello_verify(s); |
322 | if (ret <= 0) | 322 | if (ret <= 0) |
323 | goto end; | 323 | goto end; |
324 | dtls1_stop_timer(s); | 324 | dtls1_stop_timer(s); |
@@ -794,6 +794,62 @@ err: | |||
794 | } | 794 | } |
795 | 795 | ||
796 | int | 796 | int |
797 | ssl3_get_dtls_hello_verify(SSL *s) | ||
798 | { | ||
799 | long n; | ||
800 | int al, ok = 0; | ||
801 | size_t cookie_len; | ||
802 | uint16_t ssl_version; | ||
803 | CBS hello_verify_request, cookie; | ||
804 | |||
805 | n = ssl3_get_message(s, DTLS1_ST_CR_HELLO_VERIFY_REQUEST_A, | ||
806 | DTLS1_ST_CR_HELLO_VERIFY_REQUEST_B, -1, s->internal->max_cert_list, &ok); | ||
807 | if (!ok) | ||
808 | return ((int)n); | ||
809 | |||
810 | if (S3I(s)->tmp.message_type != DTLS1_MT_HELLO_VERIFY_REQUEST) { | ||
811 | D1I(s)->send_cookie = 0; | ||
812 | S3I(s)->tmp.reuse_message = 1; | ||
813 | return (1); | ||
814 | } | ||
815 | |||
816 | if (n < 0) | ||
817 | goto truncated; | ||
818 | |||
819 | CBS_init(&hello_verify_request, s->internal->init_msg, n); | ||
820 | |||
821 | if (!CBS_get_u16(&hello_verify_request, &ssl_version)) | ||
822 | goto truncated; | ||
823 | |||
824 | if (ssl_version != s->version) { | ||
825 | SSLerror(s, SSL_R_WRONG_SSL_VERSION); | ||
826 | s->version = (s->version & 0xff00) | (ssl_version & 0xff); | ||
827 | al = SSL_AD_PROTOCOL_VERSION; | ||
828 | goto f_err; | ||
829 | } | ||
830 | |||
831 | if (!CBS_get_u8_length_prefixed(&hello_verify_request, &cookie)) | ||
832 | goto truncated; | ||
833 | |||
834 | if (!CBS_write_bytes(&cookie, D1I(s)->cookie, | ||
835 | sizeof(D1I(s)->cookie), &cookie_len)) { | ||
836 | D1I(s)->cookie_len = 0; | ||
837 | al = SSL_AD_ILLEGAL_PARAMETER; | ||
838 | goto f_err; | ||
839 | } | ||
840 | D1I(s)->cookie_len = cookie_len; | ||
841 | D1I(s)->send_cookie = 1; | ||
842 | |||
843 | return 1; | ||
844 | |||
845 | truncated: | ||
846 | al = SSL_AD_DECODE_ERROR; | ||
847 | f_err: | ||
848 | ssl3_send_alert(s, SSL3_AL_FATAL, al); | ||
849 | return -1; | ||
850 | } | ||
851 | |||
852 | int | ||
797 | ssl3_get_server_hello(SSL *s) | 853 | ssl3_get_server_hello(SSL *s) |
798 | { | 854 | { |
799 | CBS cbs, server_random, session_id; | 855 | CBS cbs, server_random, session_id; |
diff --git a/src/lib/libssl/ssl_locl.h b/src/lib/libssl/ssl_locl.h index 22f9760225..41b3c02724 100644 --- a/src/lib/libssl/ssl_locl.h +++ b/src/lib/libssl/ssl_locl.h | |||
@@ -1,4 +1,4 @@ | |||
1 | /* $OpenBSD: ssl_locl.h,v 1.297 2020/10/03 17:54:27 jsing Exp $ */ | 1 | /* $OpenBSD: ssl_locl.h,v 1.298 2020/10/03 18:01:55 jsing Exp $ */ |
2 | /* Copyright (C) 1995-1998 Eric Young (eay@cryptsoft.com) | 2 | /* Copyright (C) 1995-1998 Eric Young (eay@cryptsoft.com) |
3 | * All rights reserved. | 3 | * All rights reserved. |
4 | * | 4 | * |
@@ -1297,8 +1297,8 @@ void dtls1_double_timeout(SSL *s); | |||
1297 | unsigned int dtls1_min_mtu(void); | 1297 | unsigned int dtls1_min_mtu(void); |
1298 | 1298 | ||
1299 | /* some client-only functions */ | 1299 | /* some client-only functions */ |
1300 | int dtls1_get_hello_verify(SSL *s); | ||
1301 | int ssl3_send_client_hello(SSL *s); | 1300 | int ssl3_send_client_hello(SSL *s); |
1301 | int ssl3_get_dtls_hello_verify(SSL *s); | ||
1302 | int ssl3_get_server_hello(SSL *s); | 1302 | int ssl3_get_server_hello(SSL *s); |
1303 | int ssl3_get_certificate_request(SSL *s); | 1303 | int ssl3_get_certificate_request(SSL *s); |
1304 | int ssl3_get_new_session_ticket(SSL *s); | 1304 | int ssl3_get_new_session_ticket(SSL *s); |
@@ -1314,8 +1314,8 @@ int ssl3_check_cert_and_algorithm(SSL *s); | |||
1314 | int ssl3_check_finished(SSL *s); | 1314 | int ssl3_check_finished(SSL *s); |
1315 | 1315 | ||
1316 | /* some server-only functions */ | 1316 | /* some server-only functions */ |
1317 | int dtls1_send_hello_verify_request(SSL *s); | ||
1318 | int ssl3_get_client_hello(SSL *s); | 1317 | int ssl3_get_client_hello(SSL *s); |
1318 | int ssl3_send_dtls_hello_verify_request(SSL *s); | ||
1319 | int ssl3_send_server_hello(SSL *s); | 1319 | int ssl3_send_server_hello(SSL *s); |
1320 | int ssl3_send_hello_request(SSL *s); | 1320 | int ssl3_send_hello_request(SSL *s); |
1321 | int ssl3_send_server_key_exchange(SSL *s); | 1321 | int ssl3_send_server_key_exchange(SSL *s); |
diff --git a/src/lib/libssl/ssl_srvr.c b/src/lib/libssl/ssl_srvr.c index 0f448a2d38..1e92640835 100644 --- a/src/lib/libssl/ssl_srvr.c +++ b/src/lib/libssl/ssl_srvr.c | |||
@@ -1,4 +1,4 @@ | |||
1 | /* $OpenBSD: ssl_srvr.c,v 1.85 2020/09/24 18:12:00 jsing Exp $ */ | 1 | /* $OpenBSD: ssl_srvr.c,v 1.86 2020/10/03 18:01:55 jsing Exp $ */ |
2 | /* Copyright (C) 1995-1998 Eric Young (eay@cryptsoft.com) | 2 | /* Copyright (C) 1995-1998 Eric Young (eay@cryptsoft.com) |
3 | * All rights reserved. | 3 | * All rights reserved. |
4 | * | 4 | * |
@@ -361,7 +361,7 @@ ssl3_accept(SSL *s) | |||
361 | 361 | ||
362 | case DTLS1_ST_SW_HELLO_VERIFY_REQUEST_A: | 362 | case DTLS1_ST_SW_HELLO_VERIFY_REQUEST_A: |
363 | case DTLS1_ST_SW_HELLO_VERIFY_REQUEST_B: | 363 | case DTLS1_ST_SW_HELLO_VERIFY_REQUEST_B: |
364 | ret = dtls1_send_hello_verify_request(s); | 364 | ret = ssl3_send_dtls_hello_verify_request(s); |
365 | if (ret <= 0) | 365 | if (ret <= 0) |
366 | goto end; | 366 | goto end; |
367 | S3I(s)->hs.state = SSL3_ST_SW_FLUSH; | 367 | S3I(s)->hs.state = SSL3_ST_SW_FLUSH; |
@@ -1165,6 +1165,45 @@ err: | |||
1165 | } | 1165 | } |
1166 | 1166 | ||
1167 | int | 1167 | int |
1168 | ssl3_send_dtls_hello_verify_request(SSL *s) | ||
1169 | { | ||
1170 | CBB cbb, verify, cookie; | ||
1171 | |||
1172 | memset(&cbb, 0, sizeof(cbb)); | ||
1173 | |||
1174 | if (S3I(s)->hs.state == DTLS1_ST_SW_HELLO_VERIFY_REQUEST_A) { | ||
1175 | if (s->ctx->internal->app_gen_cookie_cb == NULL || | ||
1176 | s->ctx->internal->app_gen_cookie_cb(s, D1I(s)->cookie, | ||
1177 | &(D1I(s)->cookie_len)) == 0) { | ||
1178 | SSLerror(s, ERR_R_INTERNAL_ERROR); | ||
1179 | return 0; | ||
1180 | } | ||
1181 | |||
1182 | if (!ssl3_handshake_msg_start(s, &cbb, &verify, | ||
1183 | DTLS1_MT_HELLO_VERIFY_REQUEST)) | ||
1184 | goto err; | ||
1185 | if (!CBB_add_u16(&verify, s->version)) | ||
1186 | goto err; | ||
1187 | if (!CBB_add_u8_length_prefixed(&verify, &cookie)) | ||
1188 | goto err; | ||
1189 | if (!CBB_add_bytes(&cookie, D1I(s)->cookie, D1I(s)->cookie_len)) | ||
1190 | goto err; | ||
1191 | if (!ssl3_handshake_msg_finish(s, &cbb)) | ||
1192 | goto err; | ||
1193 | |||
1194 | S3I(s)->hs.state = DTLS1_ST_SW_HELLO_VERIFY_REQUEST_B; | ||
1195 | } | ||
1196 | |||
1197 | /* S3I(s)->hs.state = DTLS1_ST_SW_HELLO_VERIFY_REQUEST_B */ | ||
1198 | return (ssl3_handshake_write(s)); | ||
1199 | |||
1200 | err: | ||
1201 | CBB_cleanup(&cbb); | ||
1202 | |||
1203 | return (-1); | ||
1204 | } | ||
1205 | |||
1206 | int | ||
1168 | ssl3_send_server_hello(SSL *s) | 1207 | ssl3_send_server_hello(SSL *s) |
1169 | { | 1208 | { |
1170 | CBB cbb, server_hello, session_id; | 1209 | CBB cbb, server_hello, session_id; |