Provide TLS 1.3 cipher AEAD/hash and legacy I/O handling functions.

Provide functionality for determining AEADs and hashes for TLS 1.3 ciphers.
Also provide wire read/write callbacks that interface with BIO and
functions that interface between SSL_read/SSL_write and the TLS 1.3 record
layer API.

ok tb@

3 files changed, 210 insertions, 2 deletions

diff --git a/src/lib/libssl/Makefile b/src/lib/libssl/Makefile
index 12cfd3d4f0..1bb3a0e78d 100644
--- a/src/lib/libssl/Makefile
+++ b/src/lib/libssl/Makefile
@@ -1,4 +1,4 @@
-# $OpenBSD: Makefile,v 1.50 2019/01/20 12:27:34 jsing Exp $
+# $OpenBSD: Makefile,v 1.51 2019/01/21 09:10:58 jsing Exp $
 
 .include <bsd.own.mk>
 .ifndef NOMAN
@@ -65,6 +65,7 @@ SRCS= \
         tls13_handshake.c \
         tls13_handshake_msg.c \
         tls13_key_schedule.c \
+        tls13_lib.c \
         tls13_record.c \
         tls13_record_layer.c
 
diff --git a/src/lib/libssl/tls13_internal.h b/src/lib/libssl/tls13_internal.h
index bb3ff1fe9c..03fdab7e53 100644
--- a/src/lib/libssl/tls13_internal.h
+++ b/src/lib/libssl/tls13_internal.h
@@ -1,4 +1,4 @@
-/* $OpenBSD: tls13_internal.h,v 1.11 2019/01/21 06:58:44 jsing Exp $ */
+/* $OpenBSD: tls13_internal.h,v 1.12 2019/01/21 09:10:58 jsing Exp $ */
 /*
  * Copyright (c) 2018 Bob Beck <beck@openbsd.org>
  * Copyright (c) 2018 Theo Buehler <tb@openbsd.org>
@@ -146,9 +146,19 @@ struct tls13_ctx {
         SSL *ssl;
         uint8_t mode;
         struct tls13_handshake_stage handshake_stage;
+        struct tls13_record_layer *rl;
 };
 
 /*
+ * Legacy interfaces.
+ */
+ssize_t tls13_legacy_wire_read_cb(void *buf, size_t n, void *arg);
+ssize_t tls13_legacy_wire_write_cb(const void *buf, size_t n, void *arg);
+int tls13_legacy_read_bytes(SSL *ssl, int type, unsigned char *buf, int len,
+    int peek);
+int tls13_legacy_write_bytes(SSL *ssl, int type, const void *buf, int len);
+
+/*
  * Message Types - RFC 8446, Section B.3.
  *
  * Values listed as "_RESERVED" were used in previous versions of TLS and are
diff --git a/src/lib/libssl/tls13_lib.c b/src/lib/libssl/tls13_lib.c
new file mode 100644
index 0000000000..a9d83d709a
--- /dev/null
+++ b/src/lib/libssl/tls13_lib.c
@@ -0,0 +1,197 @@
+/*      $OpenBSD: tls13_lib.c,v 1.1 2019/01/21 09:10:58 jsing Exp $ */
+/*
+ * Copyright (c) 2018, 2019 Joel Sing <jsing@openbsd.org>
+ *
+ * Permission to use, copy, modify, and distribute this software for any
+ * purpose with or without fee is hereby granted, provided that the above
+ * copyright notice and this permission notice appear in all copies.
+ *
+ * THE SOFTWARE IS PROVIDED "AS IS" AND THE AUTHOR DISCLAIMS ALL WARRANTIES
+ * WITH REGARD TO THIS SOFTWARE INCLUDING ALL IMPLIED WARRANTIES OF
+ * MERCHANTABILITY AND FITNESS. IN NO EVENT SHALL THE AUTHOR BE LIABLE FOR
+ * ANY SPECIAL, DIRECT, INDIRECT, OR CONSEQUENTIAL DAMAGES OR ANY DAMAGES
+ * WHATSOEVER RESULTING FROM LOSS OF USE, DATA OR PROFITS, WHETHER IN AN
+ * ACTION OF CONTRACT, NEGLIGENCE OR OTHER TORTIOUS ACTION, ARISING OUT OF
+ * OR IN CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE.
+ */
+
+#include <limits.h>
+#include <stddef.h>
+
+#include <openssl/evp.h>
+
+#include "ssl_locl.h"
+#include "tls13_internal.h"
+
+const EVP_AEAD *
+tls13_cipher_aead(const SSL_CIPHER *cipher)
+{
+        if (cipher == NULL)
+                return NULL;
+        if (cipher->algorithm_ssl != SSL_TLSV1_3)
+                return NULL;
+
+        switch (cipher->algorithm_enc) {
+        case SSL_AES128GCM:
+                return EVP_aead_aes_128_gcm();
+        case SSL_AES256GCM:
+                return EVP_aead_aes_256_gcm();
+        case SSL_CHACHA20POLY1305:
+                return EVP_aead_chacha20_poly1305();
+        }
+
+        return NULL;
+}
+
+const EVP_MD *
+tls13_cipher_hash(const SSL_CIPHER *cipher)
+{
+        if (cipher == NULL)
+                return NULL;
+        if (cipher->algorithm_ssl != SSL_TLSV1_3)
+                return NULL;
+
+        switch (cipher->algorithm2) {
+        case SSL_HANDSHAKE_MAC_SHA256:
+                return EVP_sha256();
+        case SSL_HANDSHAKE_MAC_SHA384:
+                return EVP_sha384();
+        }
+
+        return NULL;
+}
+
+static ssize_t
+tls13_legacy_wire_read(SSL *ssl, uint8_t *buf, size_t len)
+{
+        int n;
+
+        if (ssl->rbio == NULL) {
+                SSLerror(ssl, SSL_R_BIO_NOT_SET);
+                return TLS13_IO_FAILURE;
+        }
+
+        if ((n = BIO_read(ssl->rbio, buf, len)) <= 0) {
+                if (BIO_should_read(ssl->rbio))
+                        return TLS13_IO_WANT_POLLIN;
+                if (BIO_should_write(ssl->rbio))
+                        return TLS13_IO_WANT_POLLOUT;
+
+                return TLS13_IO_FAILURE;
+        }
+
+        return n;
+}
+
+ssize_t
+tls13_legacy_wire_read_cb(void *buf, size_t n, void *arg)
+{
+        struct tls13_ctx *ctx = arg;
+
+        return tls13_legacy_wire_read(ctx->ssl, buf, n);
+}
+
+static ssize_t
+tls13_legacy_wire_write(SSL *ssl, const uint8_t *buf, size_t len)
+{
+        int n;
+
+        if (ssl->wbio == NULL) {
+                SSLerror(ssl, SSL_R_BIO_NOT_SET);
+                return TLS13_IO_FAILURE;
+        }
+
+        if ((n = BIO_write(ssl->wbio, buf, len)) <= 0) {
+                if (BIO_should_read(ssl->wbio))
+                        return TLS13_IO_WANT_POLLIN;
+                if (BIO_should_write(ssl->wbio))
+                        return TLS13_IO_WANT_POLLOUT;
+
+                return TLS13_IO_FAILURE;
+        }
+
+        return n;
+}
+
+ssize_t
+tls13_legacy_wire_write_cb(const void *buf, size_t n, void *arg)
+{
+        struct tls13_ctx *ctx = arg;
+
+        return tls13_legacy_wire_write(ctx->ssl, buf, n);
+}
+
+static int
+tls13_legacy_return_code(SSL *ssl, ssize_t ret)
+{
+        ssl->internal->rwstate = SSL_NOTHING;
+
+        if (ret > INT_MAX) {
+                SSLerror(ssl, ERR_R_INTERNAL_ERROR);
+                return -1;
+        }
+
+        /* A successful read or write. */
+        if (ret > 0)
+                return ret;
+
+        switch (ret) {
+        case TLS13_IO_EOF:
+                return 0;
+
+        case TLS13_IO_FAILURE:
+                /* XXX - we need to record/map internal errors. */
+                if (ERR_peek_error() == 0)
+                        SSLerror(ssl, ERR_R_INTERNAL_ERROR);
+                return -1;
+
+        case TLS13_IO_WANT_POLLIN:
+                ssl->internal->rwstate = SSL_READING;
+                return -1;
+
+        case TLS13_IO_WANT_POLLOUT:
+                ssl->internal->rwstate = SSL_WRITING;
+                return -1;
+        }
+
+        SSLerror(ssl, ERR_R_INTERNAL_ERROR);
+        return -1;
+}
+
+int
+tls13_legacy_read_bytes(SSL *ssl, int type, unsigned char *buf, int len, int peek)
+{
+        struct tls13_ctx *ctx = ssl->internal->tls13;
+        ssize_t ret;
+
+        if (peek) {
+                /* XXX - support peek... */
+                SSLerror(ssl, ERR_R_INTERNAL_ERROR);
+                return -1;
+        }
+
+        if (type != SSL3_RT_APPLICATION_DATA) {
+                SSLerror(ssl, ERR_R_SHOULD_NOT_HAVE_BEEN_CALLED);
+                return -1;
+        }
+
+        ret = tls13_read_application_data(ctx->rl, buf, len);
+
+        return tls13_legacy_return_code(ssl, ret);
+}
+
+int
+tls13_legacy_write_bytes(SSL *ssl, int type, const void *buf, int len)
+{
+        struct tls13_ctx *ctx = ssl->internal->tls13;
+        ssize_t ret;
+
+        if (type != SSL3_RT_APPLICATION_DATA) {
+                SSLerror(ssl, ERR_R_SHOULD_NOT_HAVE_BEEN_CALLED);
+                return -1;
+        }
+
+        ret = tls13_write_application_data(ctx->rl, buf, len);
+
+        return tls13_legacy_return_code(ssl, ret);
+}