summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authordoug <>2015-06-21 16:10:45 +0000
committerdoug <>2015-06-21 16:10:45 +0000
commit5595bdce0a02a4c120f0e0c19dc735c1dd71c09d (patch)
tree3e493837cc2fc0fca1981627152b3eb8be39a565
parent5712bedec3ebd1a6f14885e7c138af02fab74449 (diff)
downloadopenbsd-5595bdce0a02a4c120f0e0c19dc735c1dd71c09d.tar.gz
openbsd-5595bdce0a02a4c120f0e0c19dc735c1dd71c09d.tar.bz2
openbsd-5595bdce0a02a4c120f0e0c19dc735c1dd71c09d.zip
Check for failure with CBB_init() in bs_ber.c.
From BoringSSL commit 3fa65f0f05f67615d9daf48940e07f84d094ac6e.
-rw-r--r--src/lib/libssl/bs_ber.c5
-rw-r--r--src/lib/libssl/src/ssl/bs_ber.c5
2 files changed, 6 insertions, 4 deletions
diff --git a/src/lib/libssl/bs_ber.c b/src/lib/libssl/bs_ber.c
index 3a391fe853..6e945a0246 100644
--- a/src/lib/libssl/bs_ber.c
+++ b/src/lib/libssl/bs_ber.c
@@ -1,4 +1,4 @@
1/* $OpenBSD: bs_ber.c,v 1.7 2015/06/17 07:20:39 doug Exp $ */ 1/* $OpenBSD: bs_ber.c,v 1.8 2015/06/21 16:10:45 doug Exp $ */
2/* 2/*
3 * Copyright (c) 2014, Google Inc. 3 * Copyright (c) 2014, Google Inc.
4 * 4 *
@@ -257,7 +257,8 @@ CBS_asn1_indefinite_to_definite(CBS *in, uint8_t **out, size_t *out_len)
257 return 1; 257 return 1;
258 } 258 }
259 259
260 CBB_init(&cbb, CBS_len(in)); 260 if (!CBB_init(&cbb, CBS_len(in)))
261 return 0;
261 if (!cbs_convert_indefinite(in, &cbb, 0, 0, 0)) { 262 if (!cbs_convert_indefinite(in, &cbb, 0, 0, 0)) {
262 CBB_cleanup(&cbb); 263 CBB_cleanup(&cbb);
263 return 0; 264 return 0;
diff --git a/src/lib/libssl/src/ssl/bs_ber.c b/src/lib/libssl/src/ssl/bs_ber.c
index 3a391fe853..6e945a0246 100644
--- a/src/lib/libssl/src/ssl/bs_ber.c
+++ b/src/lib/libssl/src/ssl/bs_ber.c
@@ -1,4 +1,4 @@
1/* $OpenBSD: bs_ber.c,v 1.7 2015/06/17 07:20:39 doug Exp $ */ 1/* $OpenBSD: bs_ber.c,v 1.8 2015/06/21 16:10:45 doug Exp $ */
2/* 2/*
3 * Copyright (c) 2014, Google Inc. 3 * Copyright (c) 2014, Google Inc.
4 * 4 *
@@ -257,7 +257,8 @@ CBS_asn1_indefinite_to_definite(CBS *in, uint8_t **out, size_t *out_len)
257 return 1; 257 return 1;
258 } 258 }
259 259
260 CBB_init(&cbb, CBS_len(in)); 260 if (!CBB_init(&cbb, CBS_len(in)))
261 return 0;
261 if (!cbs_convert_indefinite(in, &cbb, 0, 0, 0)) { 262 if (!cbs_convert_indefinite(in, &cbb, 0, 0, 0)) {
262 CBB_cleanup(&cbb); 263 CBB_cleanup(&cbb);
263 return 0; 264 return 0;