diff options
| author | tb <> | 2025-03-09 15:39:39 +0000 |
|---|---|---|
| committer | tb <> | 2025-03-09 15:39:39 +0000 |
| commit | 56f34fa2487d9426eeedabbd78842094c36f8c8c (patch) | |
| tree | 0350269e00e3241afa172f4b53ce72a231987707 | |
| parent | 6bee4b83725b153b6d7208954ada4af2402d16da (diff) | |
| download | openbsd-56f34fa2487d9426eeedabbd78842094c36f8c8c.tar.gz openbsd-56f34fa2487d9426eeedabbd78842094c36f8c8c.tar.bz2 openbsd-56f34fa2487d9426eeedabbd78842094c36f8c8c.zip | |
Remove Jprojective_coordinates API
There goes another implementation detail that should never have been leaked
out of the library.
ok jsing
| -rw-r--r-- | src/lib/libcrypto/Symbols.list | 2 | ||||
| -rw-r--r-- | src/lib/libcrypto/ec/ec.h | 6 | ||||
| -rw-r--r-- | src/lib/libcrypto/ec/ec_lib.c | 20 | ||||
| -rw-r--r-- | src/lib/libcrypto/hidden/openssl/ec.h | 4 |
4 files changed, 3 insertions, 29 deletions
diff --git a/src/lib/libcrypto/Symbols.list b/src/lib/libcrypto/Symbols.list index 332f55af8e..a48d870fc1 100644 --- a/src/lib/libcrypto/Symbols.list +++ b/src/lib/libcrypto/Symbols.list | |||
| @@ -943,7 +943,6 @@ EC_POINT_copy | |||
| 943 | EC_POINT_dbl | 943 | EC_POINT_dbl |
| 944 | EC_POINT_dup | 944 | EC_POINT_dup |
| 945 | EC_POINT_free | 945 | EC_POINT_free |
| 946 | EC_POINT_get_Jprojective_coordinates_GFp | ||
| 947 | EC_POINT_get_affine_coordinates | 946 | EC_POINT_get_affine_coordinates |
| 948 | EC_POINT_get_affine_coordinates_GFp | 947 | EC_POINT_get_affine_coordinates_GFp |
| 949 | EC_POINT_hex2point | 948 | EC_POINT_hex2point |
| @@ -957,7 +956,6 @@ EC_POINT_oct2point | |||
| 957 | EC_POINT_point2bn | 956 | EC_POINT_point2bn |
| 958 | EC_POINT_point2hex | 957 | EC_POINT_point2hex |
| 959 | EC_POINT_point2oct | 958 | EC_POINT_point2oct |
| 960 | EC_POINT_set_Jprojective_coordinates_GFp | ||
| 961 | EC_POINT_set_affine_coordinates | 959 | EC_POINT_set_affine_coordinates |
| 962 | EC_POINT_set_affine_coordinates_GFp | 960 | EC_POINT_set_affine_coordinates_GFp |
| 963 | EC_POINT_set_compressed_coordinates | 961 | EC_POINT_set_compressed_coordinates |
diff --git a/src/lib/libcrypto/ec/ec.h b/src/lib/libcrypto/ec/ec.h index 6d8d9dfb07..3417df1ce9 100644 --- a/src/lib/libcrypto/ec/ec.h +++ b/src/lib/libcrypto/ec/ec.h | |||
| @@ -1,4 +1,4 @@ | |||
| 1 | /* $OpenBSD: ec.h,v 1.52 2025/03/09 15:37:31 tb Exp $ */ | 1 | /* $OpenBSD: ec.h,v 1.53 2025/03/09 15:39:39 tb Exp $ */ |
| 2 | /* | 2 | /* |
| 3 | * Originally written by Bodo Moeller for the OpenSSL project. | 3 | * Originally written by Bodo Moeller for the OpenSSL project. |
| 4 | */ | 4 | */ |
| @@ -172,10 +172,6 @@ int EC_POINT_get_affine_coordinates(const EC_GROUP *group, const EC_POINT *p, | |||
| 172 | int EC_POINT_set_compressed_coordinates(const EC_GROUP *group, EC_POINT *p, | 172 | int EC_POINT_set_compressed_coordinates(const EC_GROUP *group, EC_POINT *p, |
| 173 | const BIGNUM *x, int y_bit, BN_CTX *ctx); | 173 | const BIGNUM *x, int y_bit, BN_CTX *ctx); |
| 174 | 174 | ||
| 175 | int EC_POINT_set_Jprojective_coordinates_GFp(const EC_GROUP *group, EC_POINT *p, | ||
| 176 | const BIGNUM *x, const BIGNUM *y, const BIGNUM *z, BN_CTX *ctx); | ||
| 177 | int EC_POINT_get_Jprojective_coordinates_GFp(const EC_GROUP *group, | ||
| 178 | const EC_POINT *p, BIGNUM *x, BIGNUM *y, BIGNUM *z, BN_CTX *ctx); | ||
| 179 | int EC_POINT_set_affine_coordinates_GFp(const EC_GROUP *group, EC_POINT *p, | 175 | int EC_POINT_set_affine_coordinates_GFp(const EC_GROUP *group, EC_POINT *p, |
| 180 | const BIGNUM *x, const BIGNUM *y, BN_CTX *ctx); | 176 | const BIGNUM *x, const BIGNUM *y, BN_CTX *ctx); |
| 181 | int EC_POINT_get_affine_coordinates_GFp(const EC_GROUP *group, | 177 | int EC_POINT_get_affine_coordinates_GFp(const EC_GROUP *group, |
diff --git a/src/lib/libcrypto/ec/ec_lib.c b/src/lib/libcrypto/ec/ec_lib.c index 43774d4267..b9829b6a47 100644 --- a/src/lib/libcrypto/ec/ec_lib.c +++ b/src/lib/libcrypto/ec/ec_lib.c | |||
| @@ -1,4 +1,4 @@ | |||
| 1 | /* $OpenBSD: ec_lib.c,v 1.119 2025/03/09 15:37:31 tb Exp $ */ | 1 | /* $OpenBSD: ec_lib.c,v 1.120 2025/03/09 15:39:39 tb Exp $ */ |
| 2 | /* | 2 | /* |
| 3 | * Originally written by Bodo Moeller for the OpenSSL project. | 3 | * Originally written by Bodo Moeller for the OpenSSL project. |
| 4 | */ | 4 | */ |
| @@ -1368,24 +1368,6 @@ LCRYPTO_ALIAS(EC_POINT_mul); | |||
| 1368 | */ | 1368 | */ |
| 1369 | 1369 | ||
| 1370 | int | 1370 | int |
| 1371 | EC_POINT_set_Jprojective_coordinates_GFp(const EC_GROUP *group, EC_POINT *point, | ||
| 1372 | const BIGNUM *x, const BIGNUM *y, const BIGNUM *z, BN_CTX *ctx) | ||
| 1373 | { | ||
| 1374 | ECerror(ERR_R_DISABLED); | ||
| 1375 | return 0; | ||
| 1376 | } | ||
| 1377 | LCRYPTO_ALIAS(EC_POINT_set_Jprojective_coordinates_GFp); | ||
| 1378 | |||
| 1379 | int | ||
| 1380 | EC_POINT_get_Jprojective_coordinates_GFp(const EC_GROUP *group, | ||
| 1381 | const EC_POINT *point, BIGNUM *x, BIGNUM *y, BIGNUM *z, BN_CTX *ctx) | ||
| 1382 | { | ||
| 1383 | ECerror(ERR_R_DISABLED); | ||
| 1384 | return 0; | ||
| 1385 | } | ||
| 1386 | LCRYPTO_ALIAS(EC_POINT_get_Jprojective_coordinates_GFp); | ||
| 1387 | |||
| 1388 | int | ||
| 1389 | EC_POINTs_make_affine(const EC_GROUP *group, size_t num, EC_POINT *points[], | 1371 | EC_POINTs_make_affine(const EC_GROUP *group, size_t num, EC_POINT *points[], |
| 1390 | BN_CTX *ctx_in) | 1372 | BN_CTX *ctx_in) |
| 1391 | { | 1373 | { |
diff --git a/src/lib/libcrypto/hidden/openssl/ec.h b/src/lib/libcrypto/hidden/openssl/ec.h index ada455c089..44adfc458e 100644 --- a/src/lib/libcrypto/hidden/openssl/ec.h +++ b/src/lib/libcrypto/hidden/openssl/ec.h | |||
| @@ -1,4 +1,4 @@ | |||
| 1 | /* $OpenBSD: ec.h,v 1.10 2025/03/09 15:37:31 tb Exp $ */ | 1 | /* $OpenBSD: ec.h,v 1.11 2025/03/09 15:39:39 tb Exp $ */ |
| 2 | /* | 2 | /* |
| 3 | * Copyright (c) 2023 Bob Beck <beck@openbsd.org> | 3 | * Copyright (c) 2023 Bob Beck <beck@openbsd.org> |
| 4 | * | 4 | * |
| @@ -156,8 +156,6 @@ LCRYPTO_UNUSED(EC_GROUP_clear_free); | |||
| 156 | LCRYPTO_UNUSED(EC_GROUP_set_curve_GFp); | 156 | LCRYPTO_UNUSED(EC_GROUP_set_curve_GFp); |
| 157 | LCRYPTO_UNUSED(EC_GROUP_get_curve_GFp); | 157 | LCRYPTO_UNUSED(EC_GROUP_get_curve_GFp); |
| 158 | LCRYPTO_UNUSED(EC_POINT_clear_free); | 158 | LCRYPTO_UNUSED(EC_POINT_clear_free); |
| 159 | LCRYPTO_UNUSED(EC_POINT_set_Jprojective_coordinates_GFp); | ||
| 160 | LCRYPTO_UNUSED(EC_POINT_get_Jprojective_coordinates_GFp); | ||
| 161 | LCRYPTO_UNUSED(EC_POINT_set_affine_coordinates_GFp); | 159 | LCRYPTO_UNUSED(EC_POINT_set_affine_coordinates_GFp); |
| 162 | LCRYPTO_UNUSED(EC_POINT_get_affine_coordinates_GFp); | 160 | LCRYPTO_UNUSED(EC_POINT_get_affine_coordinates_GFp); |
| 163 | LCRYPTO_UNUSED(EC_POINT_set_compressed_coordinates_GFp); | 161 | LCRYPTO_UNUSED(EC_POINT_set_compressed_coordinates_GFp); |
