summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorjsing <>2025-08-05 15:01:13 +0000
committerjsing <>2025-08-05 15:01:13 +0000
commit7c01be4b2669dbaad7e74b56200a97050be3bf54 (patch)
tree06c35f6bdca3658d24b026ec56a224bf41bd074a
parent9ea58040fbf19137ad6d067d1c5e40d190632f59 (diff)
downloadopenbsd-7c01be4b2669dbaad7e74b56200a97050be3bf54.tar.gz
openbsd-7c01be4b2669dbaad7e74b56200a97050be3bf54.tar.bz2
openbsd-7c01be4b2669dbaad7e74b56200a97050be3bf54.zip
Mark the inputs to bn_mul_comba{4,8}() as const.
This makes it consistent with bn_sqr_comba{4,8}() and simplifies an upcoming change. ok tb@
-rw-r--r--src/lib/libcrypto/bn/arch/amd64/bn_arch.c6
-rw-r--r--src/lib/libcrypto/bn/bn_local.h6
-rw-r--r--src/lib/libcrypto/bn/bn_mul.c6
3 files changed, 9 insertions, 9 deletions
diff --git a/src/lib/libcrypto/bn/arch/amd64/bn_arch.c b/src/lib/libcrypto/bn/arch/amd64/bn_arch.c
index a377a05681..8eb3670def 100644
--- a/src/lib/libcrypto/bn/arch/amd64/bn_arch.c
+++ b/src/lib/libcrypto/bn/arch/amd64/bn_arch.c
@@ -1,4 +1,4 @@
1/* $OpenBSD: bn_arch.c,v 1.7 2023/06/24 16:01:44 jsing Exp $ */ 1/* $OpenBSD: bn_arch.c,v 1.8 2025/08/05 15:01:13 jsing Exp $ */
2/* 2/*
3 * Copyright (c) 2023 Joel Sing <jsing@openbsd.org> 3 * Copyright (c) 2023 Joel Sing <jsing@openbsd.org>
4 * 4 *
@@ -78,7 +78,7 @@ bn_mul_words(BN_ULONG *rd, const BN_ULONG *ad, int num, BN_ULONG w)
78 78
79#ifdef HAVE_BN_MUL_COMBA4 79#ifdef HAVE_BN_MUL_COMBA4
80void 80void
81bn_mul_comba4(BN_ULONG *rd, BN_ULONG *ad, BN_ULONG *bd) 81bn_mul_comba4(BN_ULONG *rd, const BN_ULONG *ad, const BN_ULONG *bd)
82{ 82{
83 /* XXX - consider using non-alt on CPUs that have the ADX extension. */ 83 /* XXX - consider using non-alt on CPUs that have the ADX extension. */
84 bignum_mul_4_8_alt((uint64_t *)rd, (uint64_t *)ad, (uint64_t *)bd); 84 bignum_mul_4_8_alt((uint64_t *)rd, (uint64_t *)ad, (uint64_t *)bd);
@@ -87,7 +87,7 @@ bn_mul_comba4(BN_ULONG *rd, BN_ULONG *ad, BN_ULONG *bd)
87 87
88#ifdef HAVE_BN_MUL_COMBA8 88#ifdef HAVE_BN_MUL_COMBA8
89void 89void
90bn_mul_comba8(BN_ULONG *rd, BN_ULONG *ad, BN_ULONG *bd) 90bn_mul_comba8(BN_ULONG *rd, const BN_ULONG *ad, const BN_ULONG *bd)
91{ 91{
92 /* XXX - consider using non-alt on CPUs that have the ADX extension. */ 92 /* XXX - consider using non-alt on CPUs that have the ADX extension. */
93 bignum_mul_8_16_alt((uint64_t *)rd, (uint64_t *)ad, (uint64_t *)bd); 93 bignum_mul_8_16_alt((uint64_t *)rd, (uint64_t *)ad, (uint64_t *)bd);
diff --git a/src/lib/libcrypto/bn/bn_local.h b/src/lib/libcrypto/bn/bn_local.h
index 0eb9a7a745..af280ebfce 100644
--- a/src/lib/libcrypto/bn/bn_local.h
+++ b/src/lib/libcrypto/bn/bn_local.h
@@ -1,4 +1,4 @@
1/* $OpenBSD: bn_local.h,v 1.51 2025/05/25 04:30:55 jsing Exp $ */ 1/* $OpenBSD: bn_local.h,v 1.52 2025/08/05 15:01:13 jsing Exp $ */
2/* Copyright (C) 1995-1998 Eric Young (eay@cryptsoft.com) 2/* Copyright (C) 1995-1998 Eric Young (eay@cryptsoft.com)
3 * All rights reserved. 3 * All rights reserved.
4 * 4 *
@@ -240,8 +240,8 @@ BN_ULONG bn_sub(BN_ULONG *r, int r_len, const BN_ULONG *a, int a_len,
240 const BN_ULONG *b, int b_len); 240 const BN_ULONG *b, int b_len);
241 241
242void bn_mul_normal(BN_ULONG *r, BN_ULONG *a, int na, BN_ULONG *b, int nb); 242void bn_mul_normal(BN_ULONG *r, BN_ULONG *a, int na, BN_ULONG *b, int nb);
243void bn_mul_comba4(BN_ULONG *r, BN_ULONG *a, BN_ULONG *b); 243void bn_mul_comba4(BN_ULONG *r, const BN_ULONG *a, const BN_ULONG *b);
244void bn_mul_comba8(BN_ULONG *r, BN_ULONG *a, BN_ULONG *b); 244void bn_mul_comba8(BN_ULONG *r, const BN_ULONG *a, const BN_ULONG *b);
245 245
246void bn_sqr_comba4(BN_ULONG *r, const BN_ULONG *a); 246void bn_sqr_comba4(BN_ULONG *r, const BN_ULONG *a);
247void bn_sqr_comba8(BN_ULONG *r, const BN_ULONG *a); 247void bn_sqr_comba8(BN_ULONG *r, const BN_ULONG *a);
diff --git a/src/lib/libcrypto/bn/bn_mul.c b/src/lib/libcrypto/bn/bn_mul.c
index 7ec7d43437..ebf34bb413 100644
--- a/src/lib/libcrypto/bn/bn_mul.c
+++ b/src/lib/libcrypto/bn/bn_mul.c
@@ -1,4 +1,4 @@
1/* $OpenBSD: bn_mul.c,v 1.40 2025/08/03 10:32:04 tb Exp $ */ 1/* $OpenBSD: bn_mul.c,v 1.41 2025/08/05 15:01:13 jsing Exp $ */
2/* Copyright (C) 1995-1998 Eric Young (eay@cryptsoft.com) 2/* Copyright (C) 1995-1998 Eric Young (eay@cryptsoft.com)
3 * All rights reserved. 3 * All rights reserved.
4 * 4 *
@@ -74,7 +74,7 @@
74 */ 74 */
75#ifndef HAVE_BN_MUL_COMBA4 75#ifndef HAVE_BN_MUL_COMBA4
76void 76void
77bn_mul_comba4(BN_ULONG *r, BN_ULONG *a, BN_ULONG *b) 77bn_mul_comba4(BN_ULONG *r, const BN_ULONG *a, const BN_ULONG *b)
78{ 78{
79 BN_ULONG c0, c1, c2; 79 BN_ULONG c0, c1, c2;
80 80
@@ -110,7 +110,7 @@ bn_mul_comba4(BN_ULONG *r, BN_ULONG *a, BN_ULONG *b)
110 */ 110 */
111#ifndef HAVE_BN_MUL_COMBA8 111#ifndef HAVE_BN_MUL_COMBA8
112void 112void
113bn_mul_comba8(BN_ULONG *r, BN_ULONG *a, BN_ULONG *b) 113bn_mul_comba8(BN_ULONG *r, const BN_ULONG *a, const BN_ULONG *b)
114{ 114{
115 BN_ULONG c0, c1, c2; 115 BN_ULONG c0, c1, c2;
116 116