summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authormiod <>2014-09-29 04:16:49 +0000
committermiod <>2014-09-29 04:16:49 +0000
commitb4000a83a9f63dffe9a50cb6a1ded52c310da626 (patch)
treec2e37e9459346c60c80c98da1ee92b57aeb30bee
parent0f37a4a994f41ade8122e811c5065b09fb997596 (diff)
downloadopenbsd-b4000a83a9f63dffe9a50cb6a1ded52c310da626.tar.gz
openbsd-b4000a83a9f63dffe9a50cb6a1ded52c310da626.tar.bz2
openbsd-b4000a83a9f63dffe9a50cb6a1ded52c310da626.zip
X509_VERIFY_PARAM_set1_name(): if invoked with NULL as the second
parameter, correctly set param->name to NULL after having freed it. ok bcook@
-rw-r--r--src/lib/libcrypto/x509/x509_vpm.c3
-rw-r--r--src/lib/libssl/src/crypto/x509/x509_vpm.c3
2 files changed, 4 insertions, 2 deletions
diff --git a/src/lib/libcrypto/x509/x509_vpm.c b/src/lib/libcrypto/x509/x509_vpm.c
index 4ad2350222..8ec972050d 100644
--- a/src/lib/libcrypto/x509/x509_vpm.c
+++ b/src/lib/libcrypto/x509/x509_vpm.c
@@ -1,4 +1,4 @@
1/* $OpenBSD: x509_vpm.c,v 1.10 2014/07/22 02:21:20 beck Exp $ */ 1/* $OpenBSD: x509_vpm.c,v 1.11 2014/09/29 04:16:49 miod Exp $ */
2/* Written by Dr Stephen N Henson (steve@openssl.org) for the OpenSSL 2/* Written by Dr Stephen N Henson (steve@openssl.org) for the OpenSSL
3 * project 2004. 3 * project 2004.
4 */ 4 */
@@ -213,6 +213,7 @@ int
213X509_VERIFY_PARAM_set1_name(X509_VERIFY_PARAM *param, const char *name) 213X509_VERIFY_PARAM_set1_name(X509_VERIFY_PARAM *param, const char *name)
214{ 214{
215 free(param->name); 215 free(param->name);
216 param->name = NULL;
216 if (name == NULL) 217 if (name == NULL)
217 return 1; 218 return 1;
218 param->name = strdup(name); 219 param->name = strdup(name);
diff --git a/src/lib/libssl/src/crypto/x509/x509_vpm.c b/src/lib/libssl/src/crypto/x509/x509_vpm.c
index 4ad2350222..8ec972050d 100644
--- a/src/lib/libssl/src/crypto/x509/x509_vpm.c
+++ b/src/lib/libssl/src/crypto/x509/x509_vpm.c
@@ -1,4 +1,4 @@
1/* $OpenBSD: x509_vpm.c,v 1.10 2014/07/22 02:21:20 beck Exp $ */ 1/* $OpenBSD: x509_vpm.c,v 1.11 2014/09/29 04:16:49 miod Exp $ */
2/* Written by Dr Stephen N Henson (steve@openssl.org) for the OpenSSL 2/* Written by Dr Stephen N Henson (steve@openssl.org) for the OpenSSL
3 * project 2004. 3 * project 2004.
4 */ 4 */
@@ -213,6 +213,7 @@ int
213X509_VERIFY_PARAM_set1_name(X509_VERIFY_PARAM *param, const char *name) 213X509_VERIFY_PARAM_set1_name(X509_VERIFY_PARAM *param, const char *name)
214{ 214{
215 free(param->name); 215 free(param->name);
216 param->name = NULL;
216 if (name == NULL) 217 if (name == NULL)
217 return 1; 218 return 1;
218 param->name = strdup(name); 219 param->name = strdup(name);