move initialization of buf up to quell warnings and make it obvious the err case is ok.

ok bcook@

2 files changed, 10 insertions, 8 deletions

diff --git a/src/lib/libcrypto/asn1/tasn_dec.c b/src/lib/libcrypto/asn1/tasn_dec.c
index dd350070f7..23a6740115 100644
--- a/src/lib/libcrypto/asn1/tasn_dec.c
+++ b/src/lib/libcrypto/asn1/tasn_dec.c
@@ -1,4 +1,4 @@
-/* $OpenBSD: tasn_dec.c,v 1.28 2015/12/04 04:19:25 beck Exp $ */
+/* $OpenBSD: tasn_dec.c,v 1.29 2015/12/12 21:05:11 beck Exp $ */
 /* Written by Dr Stephen N Henson (steve@openssl.org) for the OpenSSL
  * project 2000.
  */
@@ -676,6 +676,10 @@ asn1_d2i_ex_primitive(ASN1_VALUE **pval, const unsigned char **in, long inlen,
         const unsigned char *cont = NULL;
         long len;
 
+        buf.length = 0;
+        buf.max = 0;
+        buf.data = NULL;
+
         if (!pval) {
                 ASN1err(ASN1_F_ASN1_D2I_EX_PRIMITIVE, ASN1_R_ILLEGAL_NULL);
                 return 0; /* Should never happen */
@@ -753,9 +757,6 @@ asn1_d2i_ex_primitive(ASN1_VALUE **pval, const unsigned char **in, long inlen,
                         buf.data = NULL;
                 }
         } else if (cst) {
-                buf.length = 0;
-                buf.max = 0;
-                buf.data = NULL;
                 /* Should really check the internal tags are correct but
                  * some things may get this wrong. The relevant specs
                  * say that constructed string types should be OCTET STRINGs
diff --git a/src/lib/libssl/src/crypto/asn1/tasn_dec.c b/src/lib/libssl/src/crypto/asn1/tasn_dec.c
index dd350070f7..23a6740115 100644
--- a/src/lib/libssl/src/crypto/asn1/tasn_dec.c
+++ b/src/lib/libssl/src/crypto/asn1/tasn_dec.c
@@ -1,4 +1,4 @@
-/* $OpenBSD: tasn_dec.c,v 1.28 2015/12/04 04:19:25 beck Exp $ */
+/* $OpenBSD: tasn_dec.c,v 1.29 2015/12/12 21:05:11 beck Exp $ */
 /* Written by Dr Stephen N Henson (steve@openssl.org) for the OpenSSL
  * project 2000.
  */
@@ -676,6 +676,10 @@ asn1_d2i_ex_primitive(ASN1_VALUE **pval, const unsigned char **in, long inlen,
         const unsigned char *cont = NULL;
         long len;
 
+        buf.length = 0;
+        buf.max = 0;
+        buf.data = NULL;
+
         if (!pval) {
                 ASN1err(ASN1_F_ASN1_D2I_EX_PRIMITIVE, ASN1_R_ILLEGAL_NULL);
                 return 0; /* Should never happen */
@@ -753,9 +757,6 @@ asn1_d2i_ex_primitive(ASN1_VALUE **pval, const unsigned char **in, long inlen,
                         buf.data = NULL;
                 }
         } else if (cst) {
-                buf.length = 0;
-                buf.max = 0;
-                buf.data = NULL;
                 /* Should really check the internal tags are correct but
                  * some things may get this wrong. The relevant specs
                  * say that constructed string types should be OCTET STRINGs