When system calls indicate an error they return -1, not some arbitrary

value < 0.  errno is only updated in this case.  Change all (most?)
callers of syscalls to follow this better, and let's see if this strictness
helps us in the future.

1 files changed, 3 insertions, 3 deletions

diff --git a/src/lib/libc/net/rresvport.c b/src/lib/libc/net/rresvport.c
index 6b45000f7b..72c27c3a3f 100644
--- a/src/lib/libc/net/rresvport.c
+++ b/src/lib/libc/net/rresvport.c
@@ -1,4 +1,4 @@
-/* $OpenBSD: rresvport.c,v 1.11 2015/09/12 14:56:50 guenther Exp $ */
+/* $OpenBSD: rresvport.c,v 1.12 2019/06/28 13:32:42 deraadt Exp $ */
 /*
  * Copyright (c) 1995, 1996, 1998 Theo de Raadt.  All rights reserved.
  * Copyright (c) 1983, 1993, 1994
@@ -82,12 +82,12 @@ rresvport_af(int *alport, int af)
         sa->sa_family = af;
         
         s = socket(af, SOCK_STREAM, 0);
-        if (s < 0)
+        if (s == -1)
                 return (-1);
 
         *portp = htons(*alport);
         if (*alport < IPPORT_RESERVED - 1) {
-                if (bind(s, sa, sa->sa_len) >= 0)
+                if (bind(s, sa, sa->sa_len) != -1)
                         return (s);
                 if (errno != EADDRINUSE) {
                         (void)close(s);