When system calls indicate an error they return -1, not some arbitrary

value < 0.  errno is only updated in this case.  Change all (most?)
callers of syscalls to follow this better, and let's see if this strictness
helps us in the future.

1 files changed, 2 insertions, 2 deletions

diff --git a/src/lib/libc/net/ruserok.c b/src/lib/libc/net/ruserok.c
index cab6f96449..a399c013e2 100644
--- a/src/lib/libc/net/ruserok.c
+++ b/src/lib/libc/net/ruserok.c
@@ -131,11 +131,11 @@ again:
                  * user or root or if writeable by anyone but the owner, quit.
                  */
                 cp = NULL;
-                if (lstat(pbuf, &sbuf) < 0)
+                if (lstat(pbuf, &sbuf) == -1)
                         cp = ".rhosts lstat failed";
                 else if (!S_ISREG(sbuf.st_mode))
                         cp = ".rhosts not regular file";
-                else if (fstat(fileno(hostf), &sbuf) < 0)
+                else if (fstat(fileno(hostf), &sbuf) == -1)
                         cp = ".rhosts fstat failed";
                 else if (sbuf.st_uid && sbuf.st_uid != pwd->pw_uid)
                         cp = "bad .rhosts owner";