diff options
| author | tedu <> | 2014-05-30 02:52:11 +0000 |
|---|---|---|
| committer | tedu <> | 2014-05-30 02:52:11 +0000 |
| commit | c442171f7692d3610a7aa5a08593cabf7253c5af (patch) | |
| tree | a802460259115af2ecf6be49736b1b6a09173232 /src/lib/libcrypto/asn1/asn_mime.c | |
| parent | 60f672682a47559e679725da4d8dc8efa1ddceff (diff) | |
| download | openbsd-c442171f7692d3610a7aa5a08593cabf7253c5af.tar.gz openbsd-c442171f7692d3610a7aa5a08593cabf7253c5af.tar.bz2 openbsd-c442171f7692d3610a7aa5a08593cabf7253c5af.zip | |
no need for null check before free. from Brendan MacDonell
Diffstat (limited to 'src/lib/libcrypto/asn1/asn_mime.c')
| -rw-r--r-- | src/lib/libcrypto/asn1/asn_mime.c | 12 |
1 files changed, 4 insertions, 8 deletions
diff --git a/src/lib/libcrypto/asn1/asn_mime.c b/src/lib/libcrypto/asn1/asn_mime.c index 5d70b76f05..f123a7ddc0 100644 --- a/src/lib/libcrypto/asn1/asn_mime.c +++ b/src/lib/libcrypto/asn1/asn_mime.c | |||
| @@ -949,10 +949,8 @@ mime_param_find(MIME_HEADER *hdr, char *name) | |||
| 949 | static void | 949 | static void |
| 950 | mime_hdr_free(MIME_HEADER *hdr) | 950 | mime_hdr_free(MIME_HEADER *hdr) |
| 951 | { | 951 | { |
| 952 | if (hdr->name) | 952 | free(hdr->name); |
| 953 | free(hdr->name); | 953 | free(hdr->value); |
| 954 | if (hdr->value) | ||
| 955 | free(hdr->value); | ||
| 956 | if (hdr->params) | 954 | if (hdr->params) |
| 957 | sk_MIME_PARAM_pop_free(hdr->params, mime_param_free); | 955 | sk_MIME_PARAM_pop_free(hdr->params, mime_param_free); |
| 958 | free(hdr); | 956 | free(hdr); |
| @@ -961,10 +959,8 @@ mime_hdr_free(MIME_HEADER *hdr) | |||
| 961 | static void | 959 | static void |
| 962 | mime_param_free(MIME_PARAM *param) | 960 | mime_param_free(MIME_PARAM *param) |
| 963 | { | 961 | { |
| 964 | if (param->param_name) | 962 | free(param->param_name); |
| 965 | free(param->param_name); | 963 | free(param->param_value); |
| 966 | if (param->param_value) | ||
| 967 | free(param->param_value); | ||
| 968 | free(param); | 964 | free(param); |
| 969 | } | 965 | } |
| 970 | 966 | ||
