improve realloc/calloc/malloc patterns; ok guenther

1 files changed, 1 insertions, 6 deletions

diff --git a/src/lib/libcrypto/asn1/f_string.c b/src/lib/libcrypto/asn1/f_string.c
index d42bcdb6ea..c213c7a88d 100644
--- a/src/lib/libcrypto/asn1/f_string.c
+++ b/src/lib/libcrypto/asn1/f_string.c
@@ -150,12 +150,7 @@ a2i_ASN1_STRING(BIO *bp, ASN1_STRING *bs, char *buf, int size)
                 }
                 i /= 2;
                 if (num + i > slen) {
-                        if (s == NULL)
-                                sp = (unsigned char *)malloc(
-                                    (unsigned int)num + i * 2);
-                        else
-                                sp = (unsigned char *)realloc(s,
-                                    (unsigned int)num + i * 2);
+                        sp = realloc(s, (unsigned int)num + i * 2);
                         if (sp == NULL) {
                                 ASN1err(ASN1_F_A2I_ASN1_STRING,
                                     ERR_R_MALLOC_FAILURE);