normalize set/getsockopt usage.

Remove the remaining random casts on optval. Fixups for this can be handled by
the portability layer all in once place.

Remove remaining fake socklen_t unions, though beck@ points out that this also
removes support for socklen_t changing its length at runtime. RIP.

ok tedu@ beck@ miod@ deraadt@

1 files changed, 2 insertions, 3 deletions

diff --git a/src/lib/libcrypto/bio/b_sock.c b/src/lib/libcrypto/bio/b_sock.c
index 34e5d9830e..8f3c58fda2 100644
--- a/src/lib/libcrypto/bio/b_sock.c
+++ b/src/lib/libcrypto/bio/b_sock.c
@@ -1,4 +1,4 @@
-/* $OpenBSD: b_sock.c,v 1.58 2014/10/13 02:49:53 bcook Exp $ */
+/* $OpenBSD: b_sock.c,v 1.59 2014/11/26 05:37:26 bcook Exp $ */
 /* Copyright (C) 1995-1998 Eric Young (eay@cryptsoft.com)
  * All rights reserved.
  *
@@ -318,8 +318,7 @@ again:
         if (bind_mode == BIO_BIND_REUSEADDR) {
                 int i = 1;
 
-                ret = setsockopt(s, SOL_SOCKET, SO_REUSEADDR, (char *)&i,
-                    sizeof(i));
+                ret = setsockopt(s, SOL_SOCKET, SO_REUSEADDR, &i, sizeof(i));
                 bind_mode = BIO_BIND_NORMAL;
         }
         if (bind(s, &server.sa, addrlen) == -1) {