Replace all use of ERR_add_error_data with ERR_asprintf_error_data.

This avoids a lot of ugly gymnastics to do snprintfs before sending the
bag of strings to ERR, and eliminates at least one place in dso_dlfctn.c
where it was being called with the incorrect number of arguments and
using random things off the stack as addresses of strings.
ok krw@, jsing@

1 files changed, 1 insertions, 3 deletions

diff --git a/src/lib/libcrypto/conf/conf_def.c b/src/lib/libcrypto/conf/conf_def.c
index 22fe7a8f60..bc9f139e7e 100644
--- a/src/lib/libcrypto/conf/conf_def.c
+++ b/src/lib/libcrypto/conf/conf_def.c
@@ -218,7 +218,6 @@ def_load_bio(CONF *conf, BIO *in, long *line)
         char *s, *p, *end;
         int again;
         long eline = 0;
-        char btmp[DECIMAL_SIZE(eline) + 1];
         CONF_VALUE *v = NULL, *tv;
         CONF_VALUE *sv = NULL;
         char *section = NULL, *buf;
@@ -428,8 +427,7 @@ err:
                 free(section);
         if (line != NULL)
                 *line = eline;
-        snprintf(btmp, sizeof btmp, "%ld", eline);
-        ERR_add_error_data(2, "line ", btmp);
+        ERR_asprintf_error_data("line %ld", eline);
         if ((h != conf->data) && (conf->data != NULL)) {
                 CONF_free(conf->data);
                 conf->data = NULL;