summaryrefslogtreecommitdiff
path: root/src/lib/libcrypto/crypto
diff options
context:
space:
mode:
authorbcook <>2014-07-20 20:51:13 +0000
committerbcook <>2014-07-20 20:51:13 +0000
commitf34324d947b29b5a35a325bbd3901294355b4f39 (patch)
tree3cffc18607d7ee2f36193cbc2c6420f39f8d8d9f /src/lib/libcrypto/crypto
parent6f021fc4705d719c57993c7f3e916ed71f4480eb (diff)
downloadopenbsd-f34324d947b29b5a35a325bbd3901294355b4f39.tar.gz
openbsd-f34324d947b29b5a35a325bbd3901294355b4f39.tar.bz2
openbsd-f34324d947b29b5a35a325bbd3901294355b4f39.zip
Move more OS-specific functionality to arc4random.h headers.
Move <sys/mman.h> and raise(SIGKILL) calls to OS-specific headers. On OpenBSD, move thread_private.h as well to arc4random.h. On Windows, use TerminateProcess on getentropy failure. ok deraadt@
Diffstat (limited to 'src/lib/libcrypto/crypto')
-rw-r--r--src/lib/libcrypto/crypto/arc4random_linux.h11
-rw-r--r--src/lib/libcrypto/crypto/arc4random_osx.h11
-rw-r--r--src/lib/libcrypto/crypto/arc4random_solaris.h11
-rw-r--r--src/lib/libcrypto/crypto/arc4random_win.h8
4 files changed, 37 insertions, 4 deletions
diff --git a/src/lib/libcrypto/crypto/arc4random_linux.h b/src/lib/libcrypto/crypto/arc4random_linux.h
index 0da5a4a433..7acba3f78e 100644
--- a/src/lib/libcrypto/crypto/arc4random_linux.h
+++ b/src/lib/libcrypto/crypto/arc4random_linux.h
@@ -1,4 +1,4 @@
1/* $OpenBSD: arc4random_linux.h,v 1.6 2014/07/19 15:29:25 bcook Exp $ */ 1/* $OpenBSD: arc4random_linux.h,v 1.7 2014/07/20 20:51:13 bcook Exp $ */
2 2
3/* 3/*
4 * Copyright (c) 1996, David Mazieres <dm@uun.org> 4 * Copyright (c) 1996, David Mazieres <dm@uun.org>
@@ -22,7 +22,10 @@
22 * Stub functions for portability. 22 * Stub functions for portability.
23 */ 23 */
24 24
25#include <sys/mman.h>
26
25#include <pthread.h> 27#include <pthread.h>
28#include <signal.h>
26 29
27static pthread_mutex_t arc4random_mtx = PTHREAD_MUTEX_INITIALIZER; 30static pthread_mutex_t arc4random_mtx = PTHREAD_MUTEX_INITIALIZER;
28#define _ARC4_LOCK() pthread_mutex_lock(&arc4random_mtx) 31#define _ARC4_LOCK() pthread_mutex_lock(&arc4random_mtx)
@@ -36,6 +39,12 @@ extern int __register_atfork(void (*)(void), void(*)(void), void (*)(void), void
36#define _ARC4_ATFORK(f) pthread_atfork(NULL, NULL, (f)) 39#define _ARC4_ATFORK(f) pthread_atfork(NULL, NULL, (f))
37#endif 40#endif
38 41
42static inline void
43_getentropy_fail(void)
44{
45 raise(SIGKILL);
46}
47
39static volatile sig_atomic_t _rs_forked; 48static volatile sig_atomic_t _rs_forked;
40 49
41static inline void 50static inline void
diff --git a/src/lib/libcrypto/crypto/arc4random_osx.h b/src/lib/libcrypto/crypto/arc4random_osx.h
index aacbef9aae..c14e044fe2 100644
--- a/src/lib/libcrypto/crypto/arc4random_osx.h
+++ b/src/lib/libcrypto/crypto/arc4random_osx.h
@@ -1,4 +1,4 @@
1/* $OpenBSD: arc4random_osx.h,v 1.6 2014/07/19 15:29:25 bcook Exp $ */ 1/* $OpenBSD: arc4random_osx.h,v 1.7 2014/07/20 20:51:13 bcook Exp $ */
2 2
3/* 3/*
4 * Copyright (c) 1996, David Mazieres <dm@uun.org> 4 * Copyright (c) 1996, David Mazieres <dm@uun.org>
@@ -22,7 +22,10 @@
22 * Stub functions for portability. 22 * Stub functions for portability.
23 */ 23 */
24 24
25#include <sys/mman.h>
26
25#include <pthread.h> 27#include <pthread.h>
28#include <signal.h>
26 29
27static pthread_mutex_t arc4random_mtx = PTHREAD_MUTEX_INITIALIZER; 30static pthread_mutex_t arc4random_mtx = PTHREAD_MUTEX_INITIALIZER;
28#define _ARC4_LOCK() pthread_mutex_lock(&arc4random_mtx) 31#define _ARC4_LOCK() pthread_mutex_lock(&arc4random_mtx)
@@ -30,6 +33,12 @@ static pthread_mutex_t arc4random_mtx = PTHREAD_MUTEX_INITIALIZER;
30 33
31#define _ARC4_ATFORK(f) pthread_atfork(NULL, NULL, (f)) 34#define _ARC4_ATFORK(f) pthread_atfork(NULL, NULL, (f))
32 35
36static inline void
37_getentropy_fail(void)
38{
39 raise(SIGKILL);
40}
41
33static volatile sig_atomic_t _rs_forked; 42static volatile sig_atomic_t _rs_forked;
34 43
35static inline void 44static inline void
diff --git a/src/lib/libcrypto/crypto/arc4random_solaris.h b/src/lib/libcrypto/crypto/arc4random_solaris.h
index 18b1bd54e0..2082a4728f 100644
--- a/src/lib/libcrypto/crypto/arc4random_solaris.h
+++ b/src/lib/libcrypto/crypto/arc4random_solaris.h
@@ -1,4 +1,4 @@
1/* $OpenBSD: arc4random_solaris.h,v 1.6 2014/07/19 15:29:25 bcook Exp $ */ 1/* $OpenBSD: arc4random_solaris.h,v 1.7 2014/07/20 20:51:13 bcook Exp $ */
2 2
3/* 3/*
4 * Copyright (c) 1996, David Mazieres <dm@uun.org> 4 * Copyright (c) 1996, David Mazieres <dm@uun.org>
@@ -22,7 +22,10 @@
22 * Stub functions for portability. 22 * Stub functions for portability.
23 */ 23 */
24 24
25#include <sys/mman.h>
26
25#include <pthread.h> 27#include <pthread.h>
28#include <signal.h>
26 29
27static pthread_mutex_t arc4random_mtx = PTHREAD_MUTEX_INITIALIZER; 30static pthread_mutex_t arc4random_mtx = PTHREAD_MUTEX_INITIALIZER;
28#define _ARC4_LOCK() pthread_mutex_lock(&arc4random_mtx) 31#define _ARC4_LOCK() pthread_mutex_lock(&arc4random_mtx)
@@ -30,6 +33,12 @@ static pthread_mutex_t arc4random_mtx = PTHREAD_MUTEX_INITIALIZER;
30 33
31#define _ARC4_ATFORK(f) pthread_atfork(NULL, NULL, (f)) 34#define _ARC4_ATFORK(f) pthread_atfork(NULL, NULL, (f))
32 35
36static inline void
37_getentropy_fail(void)
38{
39 raise(SIGKILL);
40}
41
33static volatile sig_atomic_t _rs_forked; 42static volatile sig_atomic_t _rs_forked;
34 43
35static inline void 44static inline void
diff --git a/src/lib/libcrypto/crypto/arc4random_win.h b/src/lib/libcrypto/crypto/arc4random_win.h
index 1e044de109..b7a5a36013 100644
--- a/src/lib/libcrypto/crypto/arc4random_win.h
+++ b/src/lib/libcrypto/crypto/arc4random_win.h
@@ -1,4 +1,4 @@
1/* $OpenBSD: arc4random_win.h,v 1.3 2014/07/20 16:59:31 bcook Exp $ */ 1/* $OpenBSD: arc4random_win.h,v 1.4 2014/07/20 20:51:13 bcook Exp $ */
2 2
3/* 3/*
4 * Copyright (c) 1996, David Mazieres <dm@uun.org> 4 * Copyright (c) 1996, David Mazieres <dm@uun.org>
@@ -42,6 +42,12 @@ static volatile HANDLE arc4random_mtx = NULL;
42 42
43#define _ARC4_UNLOCK() ReleaseMutex(arc4random_mtx) 43#define _ARC4_UNLOCK() ReleaseMutex(arc4random_mtx)
44 44
45static inline void
46_getentropy_fail(void)
47{
48 TerminateProcess(GetCurrentProcess(), 0);
49}
50
45static inline int 51static inline int
46_rs_allocate(struct _rs **rsp, struct _rsx **rsxp) 52_rs_allocate(struct _rs **rsp, struct _rsx **rsxp)
47{ 53{