Unify *_up_ref() implementations

No need for an inconsistently named local variable and a ternary operator.

ok jsing

1 files changed, 2 insertions, 3 deletions

diff --git a/src/lib/libcrypto/dsa/dsa_lib.c b/src/lib/libcrypto/dsa/dsa_lib.c
index 65eb65288d..2727e220f9 100644
--- a/src/lib/libcrypto/dsa/dsa_lib.c
+++ b/src/lib/libcrypto/dsa/dsa_lib.c
@@ -1,4 +1,4 @@
-/* $OpenBSD: dsa_lib.c,v 1.46 2023/11/29 21:35:57 tb Exp $ */
+/* $OpenBSD: dsa_lib.c,v 1.47 2024/03/27 01:22:30 tb Exp $ */
 /* Copyright (C) 1995-1998 Eric Young (eay@cryptsoft.com)
  * All rights reserved.
  *
@@ -176,8 +176,7 @@ LCRYPTO_ALIAS(DSA_free);
 int
 DSA_up_ref(DSA *r)
 {
-        int i = CRYPTO_add(&r->references, 1, CRYPTO_LOCK_DSA);
-        return i > 1 ? 1 : 0;
+        return CRYPTO_add(&r->references, 1, CRYPTO_LOCK_DSA) > 1;
 }
 LCRYPTO_ALIAS(DSA_up_ref);