summaryrefslogtreecommitdiff
path: root/src/lib/libcrypto/ec/ec_lib.c
diff options
context:
space:
mode:
authortedu <>2014-05-30 02:52:11 +0000
committertedu <>2014-05-30 02:52:11 +0000
commit9598b4272312fc9b55154e675c1adb3a21b491b3 (patch)
treea802460259115af2ecf6be49736b1b6a09173232 /src/lib/libcrypto/ec/ec_lib.c
parent50df74c1961eaed1e88ea9c7bb4cfcab77d75043 (diff)
downloadopenbsd-9598b4272312fc9b55154e675c1adb3a21b491b3.tar.gz
openbsd-9598b4272312fc9b55154e675c1adb3a21b491b3.tar.bz2
openbsd-9598b4272312fc9b55154e675c1adb3a21b491b3.zip
no need for null check before free. from Brendan MacDonell
Diffstat (limited to 'src/lib/libcrypto/ec/ec_lib.c')
-rw-r--r--src/lib/libcrypto/ec/ec_lib.c9
1 files changed, 3 insertions, 6 deletions
diff --git a/src/lib/libcrypto/ec/ec_lib.c b/src/lib/libcrypto/ec/ec_lib.c
index b37efac246..3313573a05 100644
--- a/src/lib/libcrypto/ec/ec_lib.c
+++ b/src/lib/libcrypto/ec/ec_lib.c
@@ -130,8 +130,7 @@ EC_GROUP_free(EC_GROUP * group)
130 BN_free(&group->order); 130 BN_free(&group->order);
131 BN_free(&group->cofactor); 131 BN_free(&group->cofactor);
132 132
133 if (group->seed) 133 free(group->seed);
134 free(group->seed);
135 134
136 free(group); 135 free(group);
137} 136}
@@ -218,8 +217,7 @@ EC_GROUP_copy(EC_GROUP * dest, const EC_GROUP * src)
218 dest->asn1_form = src->asn1_form; 217 dest->asn1_form = src->asn1_form;
219 218
220 if (src->seed) { 219 if (src->seed) {
221 if (dest->seed) 220 free(dest->seed);
222 free(dest->seed);
223 dest->seed = malloc(src->seed_len); 221 dest->seed = malloc(src->seed_len);
224 if (dest->seed == NULL) 222 if (dest->seed == NULL)
225 return 0; 223 return 0;
@@ -227,8 +225,7 @@ EC_GROUP_copy(EC_GROUP * dest, const EC_GROUP * src)
227 return 0; 225 return 0;
228 dest->seed_len = src->seed_len; 226 dest->seed_len = src->seed_len;
229 } else { 227 } else {
230 if (dest->seed) 228 free(dest->seed);
231 free(dest->seed);
232 dest->seed = NULL; 229 dest->seed = NULL;
233 dest->seed_len = 0; 230 dest->seed_len = 0;
234 } 231 }