Replace all use of ERR_add_error_data with ERR_asprintf_error_data.

This avoids a lot of ugly gymnastics to do snprintfs before sending the
bag of strings to ERR, and eliminates at least one place in dso_dlfctn.c
where it was being called with the incorrect number of arguments and
using random things off the stack as addresses of strings.
ok krw@, jsing@

1 files changed, 3 insertions, 3 deletions

diff --git a/src/lib/libcrypto/engine/eng_cnf.c b/src/lib/libcrypto/engine/eng_cnf.c
index 95c4070015..afb704e93b 100644
--- a/src/lib/libcrypto/engine/eng_cnf.c
+++ b/src/lib/libcrypto/engine/eng_cnf.c
@@ -203,9 +203,9 @@ static int int_engine_configure(char *name, char *value, const CONF *cnf)
                 {
                 ENGINEerr(ENGINE_F_INT_ENGINE_CONFIGURE, ENGINE_R_ENGINE_CONFIGURATION_ERROR);
                 if (ecmd)
-                        ERR_add_error_data(6, "section=", ecmd->section, 
-                                                ", name=", ecmd->name,
-                                                ", value=", ecmd->value);
+                        ERR_asprintf_error_data
+                            ("section=%s, name=%s, value=%s",
+                            ecmd->section, ecmd->name, ecmd->value);
                 }
         if (e)
                 ENGINE_free(e);