Remove unused app_data from EVP_CIPHER

The EVP_CIPHER structs are static const data that the library returns when
you call EVP_aes_128_cbc(), for example. It makes no sense whatsoever to
hang user data off such a struct, but it's been there since forever.

ok jsing

1 files changed, 1 insertions, 7 deletions

diff --git a/src/lib/libcrypto/evp/e_des.c b/src/lib/libcrypto/evp/e_des.c
index 64d098ca14..7a0b24c1ab 100644
--- a/src/lib/libcrypto/evp/e_des.c
+++ b/src/lib/libcrypto/evp/e_des.c
@@ -1,4 +1,4 @@
-/* $OpenBSD: e_des.c,v 1.22 2023/07/07 19:37:53 beck Exp $ */
+/* $OpenBSD: e_des.c,v 1.23 2024/01/04 17:38:36 tb Exp $ */
 /* Copyright (C) 1995-1998 Eric Young (eay@cryptsoft.com)
  * All rights reserved.
  *
@@ -234,7 +234,6 @@ static const EVP_CIPHER des_cbc = {
         .set_asn1_parameters = EVP_CIPHER_set_asn1_iv,
         .get_asn1_parameters = EVP_CIPHER_get_asn1_iv,
         .ctrl = des_ctrl,
-        .app_data = NULL,
 };
 
 const EVP_CIPHER *
@@ -256,7 +255,6 @@ static const EVP_CIPHER des_cfb64 = {
         .set_asn1_parameters = EVP_CIPHER_set_asn1_iv,
         .get_asn1_parameters = EVP_CIPHER_get_asn1_iv,
         .ctrl = des_ctrl,
-        .app_data = NULL,
 };
 
 const EVP_CIPHER *
@@ -278,7 +276,6 @@ static const EVP_CIPHER des_ofb = {
         .set_asn1_parameters = EVP_CIPHER_set_asn1_iv,
         .get_asn1_parameters = EVP_CIPHER_get_asn1_iv,
         .ctrl = des_ctrl,
-        .app_data = NULL,
 };
 
 const EVP_CIPHER *
@@ -300,7 +297,6 @@ static const EVP_CIPHER des_ecb = {
         .set_asn1_parameters = EVP_CIPHER_set_asn1_iv,
         .get_asn1_parameters = EVP_CIPHER_get_asn1_iv,
         .ctrl = des_ctrl,
-        .app_data = NULL,
 };
 
 const EVP_CIPHER *
@@ -322,7 +318,6 @@ static const EVP_CIPHER des_cfb1 = {
         .set_asn1_parameters = EVP_CIPHER_set_asn1_iv,
         .get_asn1_parameters = EVP_CIPHER_get_asn1_iv,
         .ctrl = des_ctrl,
-        .app_data = NULL,
 };
 
 const EVP_CIPHER *
@@ -344,7 +339,6 @@ static const EVP_CIPHER des_cfb8 = {
         .set_asn1_parameters = EVP_CIPHER_set_asn1_iv,
         .get_asn1_parameters = EVP_CIPHER_get_asn1_iv,
         .ctrl = des_ctrl,
-        .app_data = NULL,
 };
 
 const EVP_CIPHER *