Remove unused app_data from EVP_CIPHER

The EVP_CIPHER structs are static const data that the library returns when
you call EVP_aes_128_cbc(), for example. It makes no sense whatsoever to
hang user data off such a struct, but it's been there since forever.

ok jsing

1 files changed, 1 insertions, 5 deletions

diff --git a/src/lib/libcrypto/evp/e_idea.c b/src/lib/libcrypto/evp/e_idea.c
index b2129dc990..025a1f5087 100644
--- a/src/lib/libcrypto/evp/e_idea.c
+++ b/src/lib/libcrypto/evp/e_idea.c
@@ -1,4 +1,4 @@
-/* $OpenBSD: e_idea.c,v 1.20 2023/07/07 19:37:53 beck Exp $ */
+/* $OpenBSD: e_idea.c,v 1.21 2024/01/04 17:38:36 tb Exp $ */
 /* Copyright (C) 1995-1998 Eric Young (eay@cryptsoft.com)
  * All rights reserved.
  *
@@ -189,7 +189,6 @@ static const EVP_CIPHER idea_cbc = {
         .set_asn1_parameters = EVP_CIPHER_set_asn1_iv,
         .get_asn1_parameters = EVP_CIPHER_get_asn1_iv,
         .ctrl = NULL,
-        .app_data = NULL,
 };
 
 const EVP_CIPHER *
@@ -211,7 +210,6 @@ static const EVP_CIPHER idea_cfb64 = {
         .set_asn1_parameters = EVP_CIPHER_set_asn1_iv,
         .get_asn1_parameters = EVP_CIPHER_get_asn1_iv,
         .ctrl = NULL,
-        .app_data = NULL,
 };
 
 const EVP_CIPHER *
@@ -233,7 +231,6 @@ static const EVP_CIPHER idea_ofb = {
         .set_asn1_parameters = EVP_CIPHER_set_asn1_iv,
         .get_asn1_parameters = EVP_CIPHER_get_asn1_iv,
         .ctrl = NULL,
-        .app_data = NULL,
 };
 
 const EVP_CIPHER *
@@ -255,7 +252,6 @@ static const EVP_CIPHER idea_ecb = {
         .set_asn1_parameters = EVP_CIPHER_set_asn1_iv,
         .get_asn1_parameters = EVP_CIPHER_get_asn1_iv,
         .ctrl = NULL,
-        .app_data = NULL,
 };
 
 const EVP_CIPHER *