Remove unused app_data from EVP_CIPHER

The EVP_CIPHER structs are static const data that the library returns when
you call EVP_aes_128_cbc(), for example. It makes no sense whatsoever to
hang user data off such a struct, but it's been there since forever.

ok jsing

1 files changed, 1 insertions, 7 deletions

diff --git a/src/lib/libcrypto/evp/e_rc2.c b/src/lib/libcrypto/evp/e_rc2.c
index d859ad2a15..6f8c051cff 100644
--- a/src/lib/libcrypto/evp/e_rc2.c
+++ b/src/lib/libcrypto/evp/e_rc2.c
@@ -1,4 +1,4 @@
-/* $OpenBSD: e_rc2.c,v 1.25 2023/12/02 19:06:22 tb Exp $ */
+/* $OpenBSD: e_rc2.c,v 1.26 2024/01/04 17:38:36 tb Exp $ */
 /* Copyright (C) 1995-1998 Eric Young (eay@cryptsoft.com)
  * All rights reserved.
  *
@@ -172,7 +172,6 @@ static const EVP_CIPHER rc2_cbc = {
         .set_asn1_parameters = rc2_set_asn1_type_and_iv,
         .get_asn1_parameters = rc2_get_asn1_type_and_iv,
         .ctrl = rc2_ctrl,
-        .app_data = NULL,
 };
 
 const EVP_CIPHER *
@@ -194,7 +193,6 @@ static const EVP_CIPHER rc2_cfb64 = {
         .set_asn1_parameters = rc2_set_asn1_type_and_iv,
         .get_asn1_parameters = rc2_get_asn1_type_and_iv,
         .ctrl = rc2_ctrl,
-        .app_data = NULL,
 };
 
 const EVP_CIPHER *
@@ -216,7 +214,6 @@ static const EVP_CIPHER rc2_ofb = {
         .set_asn1_parameters = rc2_set_asn1_type_and_iv,
         .get_asn1_parameters = rc2_get_asn1_type_and_iv,
         .ctrl = rc2_ctrl,
-        .app_data = NULL,
 };
 
 const EVP_CIPHER *
@@ -238,7 +235,6 @@ static const EVP_CIPHER rc2_ecb = {
         .set_asn1_parameters = rc2_set_asn1_type_and_iv,
         .get_asn1_parameters = rc2_get_asn1_type_and_iv,
         .ctrl = rc2_ctrl,
-        .app_data = NULL,
 };
 
 const EVP_CIPHER *
@@ -262,7 +258,6 @@ static const EVP_CIPHER r2_64_cbc_cipher = {
         rc2_set_asn1_type_and_iv,
         rc2_get_asn1_type_and_iv,
         rc2_ctrl,
-        NULL
 };
 
 static const EVP_CIPHER r2_40_cbc_cipher = {
@@ -276,7 +271,6 @@ static const EVP_CIPHER r2_40_cbc_cipher = {
         rc2_set_asn1_type_and_iv,
         rc2_get_asn1_type_and_iv,
         rc2_ctrl,
-        NULL
 };
 
 const EVP_CIPHER *