Remove unused app_data from EVP_CIPHER

The EVP_CIPHER structs are static const data that the library returns when
you call EVP_aes_128_cbc(), for example. It makes no sense whatsoever to
hang user data off such a struct, but it's been there since forever.

ok jsing

1 files changed, 1 insertions, 6 deletions

diff --git a/src/lib/libcrypto/evp/e_sm4.c b/src/lib/libcrypto/evp/e_sm4.c
index 9db45a87f6..85b4d3ca04 100644
--- a/src/lib/libcrypto/evp/e_sm4.c
+++ b/src/lib/libcrypto/evp/e_sm4.c
@@ -1,4 +1,4 @@
-/*      $OpenBSD: e_sm4.c,v 1.11 2024/01/02 19:54:43 tb Exp $   */
+/*      $OpenBSD: e_sm4.c,v 1.12 2024/01/04 17:38:36 tb Exp $   */
 /*
  * Copyright (c) 2017, 2019 Ribose Inc
  *
@@ -157,7 +157,6 @@ static const EVP_CIPHER sm4_cbc = {
         .set_asn1_parameters = NULL,
         .get_asn1_parameters = NULL,
         .ctrl = NULL,
-        .app_data = NULL,
 };
 
 const EVP_CIPHER *
@@ -179,7 +178,6 @@ static const EVP_CIPHER sm4_cfb128 = {
         .set_asn1_parameters = NULL,
         .get_asn1_parameters = NULL,
         .ctrl = NULL,
-        .app_data = NULL,
 };
 
 const EVP_CIPHER *
@@ -201,7 +199,6 @@ static const EVP_CIPHER sm4_ofb = {
         .set_asn1_parameters = NULL,
         .get_asn1_parameters = NULL,
         .ctrl = NULL,
-        .app_data = NULL,
 };
 
 const EVP_CIPHER *
@@ -223,7 +220,6 @@ static const EVP_CIPHER sm4_ecb = {
         .set_asn1_parameters = NULL,
         .get_asn1_parameters = NULL,
         .ctrl = NULL,
-        .app_data = NULL,
 };
 
 const EVP_CIPHER *
@@ -256,7 +252,6 @@ static const EVP_CIPHER sm4_ctr_mode = {
         .set_asn1_parameters = NULL,
         .get_asn1_parameters = NULL,
         .ctrl = NULL,
-        .app_data = NULL,
 };
 
 const EVP_CIPHER *